~leon_plickat/lavalauncher

1

lavalauncher: bug in signal handling?

Iaroslav Lelkin <ilelkin@icloud.com>
Details
Message ID
<2FAB49E8-2CBB-4160-A092-9C1ED34333D6@icloud.com>
DKIM signature
missing
Download raw message
Hello, 

src/misc-event-sources.c has the following piece of code:

if ( fdsi.ssi_signo == SIGINT || fdsi.ssi_signo == SIGQUIT )
{
  log_message(1, "[loop] Received SIGTERM or SIGQUIT; Exiting.\n");
  return false;
}

I believe it should be either SIGTERM in condition or SIGINT in body.

How to properly terminate lavalauncher anyway?

Cheers,
Details
Message ID
<CW8BZ4G3OSY7.35N1I360DMJ1L@stud.uni-goettingen.de>
In-Reply-To
<2FAB49E8-2CBB-4160-A092-9C1ED34333D6@icloud.com> (view parent)
DKIM signature
missing
Download raw message
On Sat Oct 14, 2023 at 12:24 PM CEST, Iaroslav Lelkin wrote:
> Hello, 
>
> src/misc-event-sources.c has the following piece of code:
>
> if ( fdsi.ssi_signo == SIGINT || fdsi.ssi_signo == SIGQUIT )
> {
>   log_message(1, "[loop] Received SIGTERM or SIGQUIT; Exiting.\n");
>   return false;
> }
>
> I believe it should be either SIGTERM in condition or SIGINT in body.

You are right.

Unfortunately, I have decided to stop maintaining lavalauncher quite
a while ago, so there probably won't be an upstream fix.

> How to properly terminate lavalauncher anyway?

It should automatically quit when the Wayland server exits. Also
`killall` is always an option.


>
> Cheers,



-- 
Friendly greetings,
Leon Henrik Plickat
Reply to thread Export thread (mbox)