~leon_plickat/lavalauncher

Re: LavaLauncher 2.1.1 SVG icon size issue

Carl Chave <online@chave.us>
Details
Message ID
<CAGP1gyMq-E=KgAZSLqfoxe0Cf36j5q9bT9K_q5G4Qr1VTFD+Cg@mail.gmail.com>
DKIM signature
missing
Download raw message
Hello,

I don't believe that this is necessarily a good patch as-is, but, it
does seem to fix this issue, at least with limited testing by myself
and the package maintainer for Alpine Linux. See this merge request
and linked discussion in a previous (closed) merge request:
https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/29033

It appears that the smaller than desired icons were svg files that
included viewbox information while the correctly sized ones did not,
they only had width and height.

The patch:

```
--- lavalauncher-v2.1.1/src/types/image_t.c.orig
+++ lavalauncher-v2.1.1/src/types/image_t.c
@@ -212,8 +212,14 @@
             cairo_scale(cairo, (float)width / rsvg_width.length,
                     (float)width / rsvg_height.length);
             GError *gerror = NULL;
+            RsvgRectangle viewport = {
+                .x = 0.0,
+                .y = 0.0,
+                .width = rsvg_width.length,
+                .height = rsvg_height.length,
+            };
             rsvg_handle_render_document(image->rsvg_handle, cairo,
-                    &viewbox, &gerror);
+                    &viewport, &gerror);
             // TODO check value of gerror
         }
     }
```

Thanks,
Carl Chave
Reply to thread Export thread (mbox)