Hi Ploum,
I'm the author of the "dépêche" you commented on here:
https://linuxfr.org/news/l-installation-et-la-distribution-de-paquets-python-1-4#comment-1940663
I skimmed at your problem. I admit I have not read all packaging-related
threads on this mailing list. If I understand correctly, you want
to keep using the (relatively non-standard) current setup of
Offpunk, namely a bunch of scripts at the root of the source tree.
You can't do that with Flit, because it's an opinionated tool
which insists that you do it the more standard way. So here's
a simple patch that does it with hatchling instead.
You might also want to review the dependency list in pyproject.toml.
I see "timg>=1.3.2", but the latest version of timg on PyPI
is 1.1.6.
Best,
Jean
On 23/11/07 11:46, Jean Abou Samra wrote:
>Hi Ploum,>>I'm the author of the "dépêche" you commented on here:>>https://linuxfr.org/news/l-installation-et-la-distribution-de-paquets-python-1-4#comment-1940663
Hi Jean,
Thanks a lot for taking the time to look into the problem and proposing
a patch. This is really helpful.
>>I skimmed at your problem. I admit I have not read all packaging-related>threads on this mailing list. If I understand correctly, you want>to keep using the (relatively non-standard) current setup of>Offpunk, namely a bunch of scripts at the root of the source tree.>>You can't do that with Flit, because it's an opinionated tool>which insists that you do it the more standard way. So here's>a simple patch that does it with hatchling instead.
I’ve reviewed the patch and I do really appreciate because it doesn’t
touch anything in offpunk code. So my only question: would it solves the
problem for distribution packagers?
Is hatchling something "strange" or, for packagers, is it transparent?
What are the drawbacks of using hatchling?
I’m really curious to have opinions of others on this list, including
Anna Cybertailor and Austreelis.
If this patch fixes the problem for packagers, that would be wonderful!
I own you several drinks ;-)
>>You might also want to review the dependency list in pyproject.toml.>I see "timg>=1.3.2", but the latest version of timg on PyPI>is 1.1.6.
Will have a look. Timg should be used only when there’s no chafa. Maybe
I should at some point remove timg completely.
Thanks a lot,
Time to investigate this.
>>Best,>Jean>
--
Ploum - Lionel Dricot
Blog: https://www.ploum.net
Livres: https://ploum.net/livres.html
Hi,
> Le 8 nov. 2023 à 10:32, sourcehut23@ploum.eu a écrit :> > I’ve reviewed the patch and I do really appreciate because it doesn’t > touch anything in offpunk code. So my only question: would it solves the > problem for distribution packagers?
Yes, it should.
Since pyproject builds [*] are the standard for building Python packages today, any distro with many Python packages needs some way to create a distro package from a compliant source tree.
[*] You might know them as PEP 517 builds, but I try to avoid referring to things by PEP number.
> Is hatchling something "strange" or, for packagers, is it transparent?
It is a pretty common build backend. More so than Flit, I think.
> What are the drawbacks of using hatchling?
To my knowledge, none.
Best,
Jean
Hatchling patch has been pushed and released as 2.0-beta2.
A huge thanks for that!
On 23/11/07 11:46, Jean Abou Samra wrote:
>Hi Ploum,>>I'm the author of the "dépêche" you commented on here:>>https://linuxfr.org/news/l-installation-et-la-distribution-de-paquets-python-1-4#comment-1940663>>I skimmed at your problem. I admit I have not read all packaging-related>threads on this mailing list. If I understand correctly, you want>to keep using the (relatively non-standard) current setup of>Offpunk, namely a bunch of scripts at the root of the source tree.>>You can't do that with Flit, because it's an opinionated tool>which insists that you do it the more standard way. So here's>a simple patch that does it with hatchling instead.>>You might also want to review the dependency list in pyproject.toml.>I see "timg>=1.3.2", but the latest version of timg on PyPI>is 1.1.6.>>Best,>Jean>
--
Ploum - Lionel Dricot
Blog: https://www.ploum.net
Livres: https://ploum.net/livres.html
Since I already have the setup ready I'll be able to check if the nix package works. I don't think there's a reason it shouldn't.
Thanks for the patch ! This is definitely better than mines (and I'll note that hatchling exists now :P )
--
Cheers ~
Austreelis [xe/xer]
Ploum wrote:
> So my only question: would it solves the problem for distribution packagers? > > Is hatchling something "strange" or, for packagers, is it transparent?
On ArchLinux/AUR I just swapped the dependency `python-flit` for `python-hatchling` in PKGBUILD, and for the first time in what seems like months we have a working `offpunk-git` package. 🤸
So a BIG thanks for the change. 🙏
Cheers,
--
Kʟᴀᴜꜱ Aʟᴇxᴀɴᴅᴇʀ Sᴇɪꜱᴛʀᴜᴘ 🇩🇰
https://magnetic-ink.dk/kas
On 23/11/08 03:28, Klaus Alexander Seistrup wrote:
>Ploum wrote:>>> So my only question: would it solves the problem for distribution packagers?>>>> Is hatchling something "strange" or, for packagers, is it transparent?>>On ArchLinux/AUR I just swapped the dependency `python-flit` for `python-hatchling` in PKGBUILD, and for the first time in what seems like months we have a working `offpunk-git` package. 🤸>>So a BIG thanks for the change. 🙏
That’s awesome!
Could confirm that:
1) offpunk is working properly
2) the other tools are also in the path: netcache, ansicat and opnk ?
Thanks!
Ploum wrote:
> Could confirm that:> > 1) offpunk is working properly
I haven't tried all functionality, but yes I can browse a remote Gemini site.
(I'd prefer if a hostname given without a protocol would just mean gemini://$HOST but that's another story.)
> 2) the other tools are also in the path: netcache, ansicat and opnk ?
```sh
$ pacman --query --list offpunk-git | rg /usr/bin
offpunk-git /usr/bin/
offpunk-git /usr/bin/ansicat
offpunk-git /usr/bin/netcache
offpunk-git /usr/bin/offpunk
offpunk-git /usr/bin/opnk
```
Indeed they are, and I can call each of them with `-h` and see their help text, but that's all I have tried.
So everything looks cool here.
--
Kʟᴀᴜꜱ Aʟᴇxᴀɴᴅᴇʀ Sᴇɪꜱᴛʀᴜᴘ 🇩🇰
https://magnetic-ink.dk/kas
The nix package is working when replacing the flit dependency to hatchling (offpunk works and `ansicat`, `netcache` & `opnk` are in $PATH) :)
--
Cheers ~
Austreelis [xe/xer]