~lkcamp/patches

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH v3] x86/cpu: Include missing header

Details
Message ID
<20220922023712.1356345-1-lucianorsleao@gmail.com>
DKIM signature
missing
Download raw message
Patch: +1 -1
Include the header containing the prototype of a global function,
solving the following warning:

 arch/x86/kernel/cpu/feat_ctl.c:112:6: warning: no previous prototype for
 'init_ia32_feat_ctl'
 [-Wmissing-prototypes]

This warning appeared after commit 5d5103595e9e5 ("x86/cpu: Reinitialize
IA32_FEAT_CTL MSR on BSP during wakeup") had moved function
init_ia32_feat_ctl()'s prototype from arch/x86/kernel/cpu/cpu.h to
arch/x86/include/asm/cpu.h.

Note that, before the commit mentioned above, header "cpu.h"
(arch/x86/kernel/cpu/cpu.h) was added by commit 0e79ad863df43 ("x86/cpu:
Fix a -Wmissing-prototypes warning for init_ia32_feat_ctl()")
solely to fix init_ia32_feat_ctl()'s missing prototype. So, header
"cpu.h" is no longer necessary.

Fixes: 5d5103595e9e5 ("x86/cpu: Reinitialize IA32_FEAT_CTL MSR on
BSP during wakeup")
Signed-off-by: Luciano Leão <lucianorsleao@gmail.com>
---
 arch/x86/kernel/cpu/feat_ctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/feat_ctl.c b/arch/x86/kernel/cpu/feat_ctl.c
index 993697e71854..03851240c3e3 100644
--- a/arch/x86/kernel/cpu/feat_ctl.c
+++ b/arch/x86/kernel/cpu/feat_ctl.c
@@ -1,11 +1,11 @@
// SPDX-License-Identifier: GPL-2.0
#include <linux/tboot.h>

#include <asm/cpu.h>
#include <asm/cpufeature.h>
#include <asm/msr-index.h>
#include <asm/processor.h>
#include <asm/vmx.h>
#include "cpu.h"

#undef pr_fmt
#define pr_fmt(fmt)	"x86/cpu: " fmt
-- 
2.30.2
Details
Message ID
<20220922034211.ghbbsavgijm722l7@notapiano>
In-Reply-To
<20220922023712.1356345-1-lucianorsleao@gmail.com> (view parent)
DKIM signature
missing
Download raw message
Hi Luciano,

On Wed, Sep 21, 2022 at 11:37:12PM -0300, Luciano Leão wrote:
> Include the header containing the prototype of a global function,
> solving the following warning:
> 
>  arch/x86/kernel/cpu/feat_ctl.c:112:6: warning: no previous prototype for
>  'init_ia32_feat_ctl'
>  [-Wmissing-prototypes]
> 
> This warning appeared after commit 5d5103595e9e5 ("x86/cpu: Reinitialize
> IA32_FEAT_CTL MSR on BSP during wakeup") had moved function
> init_ia32_feat_ctl()'s prototype from arch/x86/kernel/cpu/cpu.h to
> arch/x86/include/asm/cpu.h.
> 
> Note that, before the commit mentioned above, header "cpu.h"
> (arch/x86/kernel/cpu/cpu.h) was added by commit 0e79ad863df43 ("x86/cpu:
> Fix a -Wmissing-prototypes warning for init_ia32_feat_ctl()")
> solely to fix init_ia32_feat_ctl()'s missing prototype. So, header
> "cpu.h" is no longer necessary.
> 
> Fixes: 5d5103595e9e5 ("x86/cpu: Reinitialize IA32_FEAT_CTL MSR on
> BSP during wakeup")

While you did right in folding the commit message around 80 columns or so, the
trailer tags, like Fixes:, Signed-off-by:, etc, are exceptions to this rule,
that is, they shouldn't be wrapped. So please keep the whole Fixes tag in a
single line (this simplifies the life of automated tools searching for these
tags).

With this addressed, I don't see anything else to improve on, so feel free to
include my review tag when submitting the patch to the kernel:

Reviewed-by: Nícolas F. R. A. Prado <n@nfraprado.net>

Good job :^).

Thanks,
Nícolas
Reply to thread Export thread (mbox)