~lkcamp/patches

drm: checkpatch: fix warnings and errors v1 PROPOSED

Anderson Fraga: 1
 drm: checkpatch: fix warnings and errors

 1 files changed, 14 insertions(+), 14 deletions(-)
Export patchset (mbox)
How do I use this?

Copy & paste the following snippet into your terminal to import this patchset into git:

curl -s https://lists.sr.ht/~lkcamp/patches/patches/26828/mbox | git am -3
Learn more about email & git

[PATCH] drm: checkpatch: fix warnings and errors Export this patch

From: aaafraga <aaafraga@gmail.com>

This commit fixes several warnings and errors caught by checkpatch about
missing type in unsigned parameters.

Co-developed-by: Djakson C. G. Filho <djakson.filho@gmail.com>
Signed-off-by: Djakson C. G. Filho <djakson.filho@gmail.com>
Signed-off-by: Anderson Fraga <kaspa@onionmail.org>
---
 .../gpu/drm/selftests/test-drm_plane_helper.c | 28 +++++++++----------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/selftests/test-drm_plane_helper.c b/drivers/gpu/drm/selftests/test-drm_plane_helper.c
index a08e8c3e9cd2..7c2670adc13e 100644
--- a/drivers/gpu/drm/selftests/test-drm_plane_helper.c
+++ b/drivers/gpu/drm/selftests/test-drm_plane_helper.c
@@ -14,17 +14,17 @@

#include "drm_selftest.h"
struct drm_selftest tests[] = {
       {
               .enabled = true,
               .name = "drm_igt_check_plane_state",
               .func = igt_check_plane_state,
       },
	{
		.enabled = true,
		.name = "drm_igt_check_plane_state",
		.func = igt_check_plane_state,
	},
};
#include "drm_selftest.c"

static void set_src(struct drm_plane_state *plane_state,
		    unsigned src_x, unsigned src_y,
		    unsigned src_w, unsigned src_h)
		    unsigned int src_x, unsigned int src_y,
		    unsigned int src_w, unsigned int src_h)
{
	plane_state->src_x = src_x;
	plane_state->src_y = src_y;
@@ -33,8 +33,8 @@ static void set_src(struct drm_plane_state *plane_state,
}

static bool check_src_eq(struct drm_plane_state *plane_state,
			 unsigned src_x, unsigned src_y,
			 unsigned src_w, unsigned src_h)
			 unsigned int src_x, unsigned int src_y,
			 unsigned int src_w, unsigned int src_h)
{
	if (plane_state->src.x1 < 0) {
		pr_err("src x coordinate %x should never be below 0.\n", plane_state->src.x1);
@@ -60,7 +60,7 @@ static bool check_src_eq(struct drm_plane_state *plane_state,

static void set_crtc(struct drm_plane_state *plane_state,
		     int crtc_x, int crtc_y,
		     unsigned crtc_w, unsigned crtc_h)
		     unsigned int crtc_w, unsigned int crtc_h)
{
	plane_state->crtc_x = crtc_x;
	plane_state->crtc_y = crtc_y;
@@ -70,7 +70,7 @@ static void set_crtc(struct drm_plane_state *plane_state,

static bool check_crtc_eq(struct drm_plane_state *plane_state,
			  int crtc_x, int crtc_y,
			  unsigned crtc_w, unsigned crtc_h)
			  unsigned int crtc_w, unsigned int crtc_h)
{
	if (plane_state->dst.x1 != crtc_x ||
	    plane_state->dst.y1 != crtc_y ||
@@ -231,11 +231,11 @@ int igt_check_plane_state(void *ignored)

static int __init test_drm_plane_helper_init(void)
{
       int err;
	int err;

       err = run_selftests(tests, ARRAY_SIZE(tests), NULL);
	err = run_selftests(tests, ARRAY_SIZE(tests), NULL);

       return err > 0 ? 0 : err;
	return err > 0 ? 0 : err;
}

static void __exit test_drm_plane_helper_exit(void)
-- 
2.30.2
Hi,

This should be part of a series that would include the other patch that
you've sent to our mailing list: "drm: selftest: convert
drm_plane_helper selftest to KUnit".

You've submitted two separate patches. But as they are correlated,
maintainers would benefit from reviewing and merging them together.

In this particular case in which you have only 2 commits this is not
problematic, but imagine that your changes consists of 20 commits. It's
much better for maintainers to receive them in a single series, as they
can see the big picture.

Thanks,
Leandro Ribeiro.

On 11/24/21 21:47, Anderson Fraga wrote: