Why are you pasing -DDBG_RX_SIGNAL_DISPLAY_RAW_DATA? Is there some document
somewhere which says to do that? Normally we would just say "Nothing ever
enables DDBG_RX_SIGNAL_DISPLAY_RAW_DATA so just delete that code" and delete
it. But if there is some external document which says to enable it, and it's
useful stuff then maybe we should keep it?
drivers/staging/rtl8723bs/hal/hal_com.c: In function ‘rtw_store_phy_info’:
drivers/staging/rtl8723bs/hal/hal_com.c:927:43: error: ‘PODM_PHY_INFO_T’ undeclared (first use in this function)
927 | struct odm_phy_info *pPhyInfo = (PODM_PHY_INFO_T)(&pattrib->phy_info);
| ^~~~~~~~~~~~~~~
drivers/staging/rtl8723bs/hal/hal_com.c:927:43: note: each undeclared identifier is reported only once for each function it appears in
drivers/staging/rtl8723bs/hal/hal_com.c:940:73: error: ‘struct odm_phy_info’ has no member named ‘RxPwr’; did you mean ‘rx_pwr’?
940 | psample_pkt_rssi->ofdm_pwr[rf_path] = pPhyInfo->RxPwr[rf_path];
| ^~~~~
| rx_pwr
drivers/staging/rtl8723bs/hal/hal_com.c:941:71: error: ‘struct odm_phy_info’ has no member named ‘RxSNR’
941 | psample_pkt_rssi->ofdm_snr[rf_path] = pPhyInfo->RxSNR[rf_path];
Actually it's not exaclty in the same line of pr_debug/netdev_dbg replacement. Do you think
we can do the replacement at:
Originally, I didn't replace this because at dvobj of sdio_alloc_irq(struct dvobj_priv *dvobj)
there are two adapter fields:
struct dvobj_priv {
struct adapter *if1; /* PRIMARY_ADAPTER */
...
struct adapter *padapters;
...
}
Checking the "counter part" function of sdio_alloc_irq(), the sdio_free_irq() (which is not used),
the if1 (primary) is used for debug purpose:
netdev_err(dvobj->if1->pnetdev...
And checking the initialization path, if1 should be ok at this point.
But since I can't test this, do you suggest to replace anyway?
Most drivers/staging patches are not tested before sending. The printk
conversions are a leading source of bugs. The common bug with these conversions
looks like this:
if (!dev)
netdev_err(dev, "no device\n");
Anyway, it's fine to send untested patches so long as you've looked at the
initialization path and it's okay as you said.
regards,
dan carpenter
I've enabled this in an arbitrary way just to check the rtw_dump_raw_rssi_info()
because I was doing the debug replacement within the isolated code. Looking again,
I didn't find any documentation about this and the history of some files, the #ifdef
macro is very old...from 7years ago. We can remove this for sure.
As part of TODO file for future work, use dyn debug api for
remaining printk statements.
Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
---
I didn't use the netdev_dbg() over drivers/staging/rtl8723bs/hal/hal_com.c
because I noticed now that rtw_dump_raw_rssi_info() and the hal file is a
little broken with -DDBG_RX_SIGNAL_DISPLAY_RAW_DATA, maybe we can
fix that in a next patch.