~ludovicchabant

Recent activity

Re: [PATCH hg.sr.ht] hgsrht: Fix repository deletion notices 17 days ago

From Ludovic Chabant to ~sircmpwn/sr.ht-dev

Merged as b4d5c6f7058e, thanks!

Re: [PATCH hg.sr.ht] api: Add settings field to version 17 days ago

From Ludovic Chabant to ~sircmpwn/sr.ht-dev

> While it is true that the config has the "git.sr.ht::dispatch" entry,
> the actual code uses "hg.sr.ht::dispatch" as the section [0][1]

Ah right, I believe that code is wrong indeed.

Thanks for the patches! Merged v2 of this, and the other one, as
f70a9cacb505 and 6584a267226c

Re: [PATCH hg.sr.ht v3] Drop source_repo_id and upstream_uri from repository 17 days ago

From Ludovic Chabant to ~sircmpwn/sr.ht-dev

> For git.sr.ht, these fields are not used for cloning. Instead, that 
> information is stored in the repository by git.

Right, thanks. Merged as 6584a267226c

Re: [PATCH hg.sr.ht v3] Drop source_repo_id and upstream_uri from repository 27 days ago

From Ludovic Chabant to ~sircmpwn/sr.ht-dev

Since this stuff is already there, would it be worth it to implement the
cloning + upstream URI feature on hgsrht?

Re: [PATCH hg.sr.ht] hgsrht/templates/user: Remove extraneous paragraph 27 days ago

From Ludovic Chabant to ~sircmpwn/sr.ht-dev

Merged as 2fccda00141f, thanks!

Re: [PATCH hg.sr.ht] api: Add settings field to version 27 days ago

From Ludovic Chabant to ~sircmpwn/sr.ht-dev

> +     sshUser, _ := conf.Get("hg.sr.ht::dispatch", "/usr/bin/hgsrht-keys")
> +     sshUser = strings.Split(sshUser, ":")[0]

It's unintuitive, but I believe all the ssh key executables are under
`git.sr.ht::dispatch` for historical reasons. So I don't think this will
ever get anything, unless something has changed that I don't know about?

Re: [PATCH 2 of 2 hg.sr.ht v3] hgsrht: Use GraphQL for repository CRUD operations a month ago

From Ludovic Chabant to ~sircmpwn/sr.ht-dev

All of Adnan's patches have been deployed. Great work and thanks again!

Re: [PATCH 2 of 2 hg.sr.ht v3] hgsrht: Use GraphQL for repository CRUD operations a month ago

From Ludovic Chabant to ~sircmpwn/sr.ht-dev

> Ah, looks like I forgot to register the @private directive for
> git.sr.ht as well. If you want to patch it in, you can find how
> meta.sr.ht does it in api/server.go. Otherwise, I can send an
> updated patch.

Ah, great. I saw your patches coming for gitsrht, it's just a one-liner
so I'll take care of it for hgsrht. Thanks again.


> Nothing that I can think of besides making sure that the database is
> updated to the latest alembic revision.

I think that's done automatically on deploy so I think we're good.

Re: [PATCH 2 of 2 hg.sr.ht v3] hgsrht: Use GraphQL for repository CRUD operations a month ago

From Ludovic Chabant to ~sircmpwn/sr.ht-dev

All your patches look good, thanks a lot. I just had to fix a couple
things like a missing '!' in the gql schema.

The only problem is that @private fields don't work... hgsrht doesn't
know that directive. I can't figure out how gitsrht makes it known to
its own api? Both services seem to have that directive in the generated
config. Any ideas?

Also, anything we should know before we deploy everything?

Re: [PATCH hg.sr.ht] hgsrht/repos.py: Fix variable name a month ago

From Ludovic Chabant to ~sircmpwn/sr.ht-dev

Merged as c75fecfb8f88, thanks!