On Tue, Jul 19, 2022 at 03:26:50PM +0000, Tom Schwindl wrote:
> The last commit (cbeda11801c95687498e2deb6a0144b562581d16)
> introduced an edge case where two non-existing files were not recognized
> as the same due to the inode comparison.
> 
> ---
> I sent this on it's own so nobody has to scrape the patch out
> of the other mail.
> ---
>  vis.c | 17 ++++++++++++-----
>  1 file changed, 12 insertions(+), 5 deletions(-)
> 
> diff --git a/vis.c b/vis.c
> index 152a594a8c85..6ee9f227e216 100644

On Sun, Jul 10, 2022 at 07:30:22PM +0000, Tom Schwindl wrote:
> The `file_new` function checks if a file is already opened by comparing
> the names of the files. This is unsafe and shouldn't be used anymore.
> ---
> I already opened a pull request on Github with the same patch because
> I wasn't aware of this mailing list.

Hi,

Thanks for your contribution! I think that the patch as applied has
a problem.

> ---
>  vis.c | 11 ++++++++---

Hi,

I'm pleased to announce vis-0.7:

 https://www.brain-dump.org/projects/vis/vis-0.7.tar.gz
 
This is mostly a bugfix release with fixes for a few cases of undefined
behavior[1] and preliminary work for experimentation with different core
text management data structures[2] and general editor architecture[3].

Changes include:

 - fix UB in core text management data structure
 - text refactoring, splitting out reusable text iterator and I/O components

On Fri, Sep 25, 2020 at 08:40:16AM -0700, Evan Gates wrote:
> @@ -1363,15 +1370,26 @@ static const char *selections_match_next(Vis *vis, const char *keys, const Arg *
>  	if (!buf)
>  		return keys;
>  
> -	Filerange word = find_next(txt, sel.end, buf);
> -	if (text_range_valid(&word) && selection_new_primary(view, &word))
> -		goto out;
> +	bool match_all = arg->b;
> +
> +	for (;;) {
> +		sel = view_selections_get(s);

This could be simplified, you don't need to look up the selection range

On Thu, Sep 24, 2020 at 02:48:30PM -0700, Evan Gates wrote:
> Add new vis-selection-new-match-all command, default keybinding <C-a>
> in visual mode.  Refactor selections_next_match to find all matches if
> arg.b is true.  This does not affect existing configs as arg.b defaults
> to false.

I think this should keep the primary selection, i.e. the viewport should
not change just select all the other matches.

What do you think?

Marc

On Thu, Sep 24, 2020 at 02:48:29PM -0700, Evan Gates wrote:
> A lot of code from selections_match_next was duplicated in
> selections_match_next_literal.  Add text_literal_find_next (and prev)
> that mirrors text_object_word_find_next so they can be swapped out in
> a single function.

The new utility functions should be placed in text-objects.[ch] as
text_object_find_{next,prev}, they might be useful eslsewhere. A separate
patch introducing them would be nice, otherwise this looks OK.

Marc

Hi

I'm pleased to announce a new version of the vis editor, combining modal
editing with built-in support for multiple selections, structural regular
expressions and Lua scripting capabilities.

 https://www.brain-dump.org/projects/vis/vis-0.6.tar.gz

Changes include:

 - bounded time syntax highlighting using the `:set redrawtime` option
 - support optional count for sam's text commands e.g. `:i3/-/`
 - make `<C-n>` in visual mode match next occurence of existing selection
 - warn when attempting to write to an existing file

Hi

This is the development mailing list of vis, dvtm, abduco and related
projects. Feel free to submit patches, peform code reviews, suggest
improvements, report bugs and discuss design decisions ...

Marc