https://github.com/martanne/vis/pull/769

I think it should be rather trivial yea-or-nay
decision and it is the last item on the TODO list in
https://github.com/martanne/vis/issues/1001, which could be then
truly done.

Best,

Matěj

-- 
http://matej.ceplovi.cz/blog/, @mcepl@floss.social
GPG Finger: 3C76 A027 CA45 AD70 98B5  BC1D 7920 5802 880B C9D8
 
The law, in its majestic equality, forbids the rich as well as
the poor to sleep under bridges, to beg in the streets, and to
steal bread.
    -- Anatole France

Matěj Cepl <mcepl@cepl.eu> wrote:
> https://github.com/martanne/vis/pull/769
> 
> I think it should be rather trivial yea-or-nay
> decision and it is the last item on the TODO list in
> https://github.com/martanne/vis/issues/1001, which could be then
> truly done.

For what it's worth, this LGTM!

I have added my review on Github as well.

Cheers,
Silvan

"Silvan Jegen" <me@sillymon.ch> wrote:
> Matěj Cepl <mcepl@cepl.eu> wrote:
> > https://github.com/martanne/vis/pull/769
> > 
> > I think it should be rather trivial yea-or-nay
> > decision and it is the last item on the TODO list in
> > https://github.com/martanne/vis/issues/1001, which could be then
> > truly done.
> 
> For what it's worth, this LGTM!
> 
> I have added my review on Github as well.
> 
> Cheers,
> Silvan

Were either of you able to recreate the issue this reports to fix?
From my testing this patch doesn't give any noticeable results.

- Randy

-- 
https://rnpnr.xyz/
GPG Fingerprint: B8F0 CF4C B6E9 415C 1B27 A8C4 C8D2 F782 86DF 2DC5

Randy Palamar <randy@rnpnr.xyz> wrote:
> "Silvan Jegen" <me@sillymon.ch> wrote:
> > Matěj Cepl <mcepl@cepl.eu> wrote:
> > > https://github.com/martanne/vis/pull/769
> > > 
> > > I think it should be rather trivial yea-or-nay
> > > decision and it is the last item on the TODO list in
> > > https://github.com/martanne/vis/issues/1001, which could be then
> > > truly done.
> > 
> > For what it's worth, this LGTM!
> > 
> > I have added my review on Github as well.
> > 
> > Cheers,
> > Silvan
> 
> Were either of you able to recreate the issue this reports to fix?
> From my testing this patch doesn't give any noticeable results.

Admittedly, I haven't tried to reproduce the original issue. I have just
checked that regular vis usage is still working after applying that patch
and that the change seemed potentially relevant for the issue the author
brought up.

Maybe it would be better to close the PR until the original author gets
back to tell us whether they still need this change or not?

Cheers,
Silvan



> 
> - Randy