~martijnbraam/public-inbox

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

himitsu-keyring: Odd casing in protocol group labels

Details
Message ID
<20221021235904.y5tqoy4qntx2d45g@victory>
DKIM signature
missing
Download raw message
For some odd reason, the casing of the protocol "titles" (e.g.: the labels on
the top of each protocol) is mixed up; the first one is shown all uppercase
("SMTP"), while others are title-case ("Imaps", "Smtps", etc).

A screenshot might be much clearer, but emails with image/png attachment are
rejected from this list.

I've no idea what could be causing this. IMHO, all uppercase ("SMTP") or all
lowercase ("smtp") are best. "Title Case" can be confusing for things like
"IMAP" where "Imap" looks too much like "lmap" on a sans-serif font (which is
used by GTK by default).

-- 
Hugo Osvaldo Barrera
Details
Message ID
<db2a66ff-6025-4ca8-c9f5-daf004b03c10@brixit.nl>
In-Reply-To
<20221021235904.y5tqoy4qntx2d45g@victory> (view parent)
DKIM signature
missing
Download raw message
This behavior is because it's title-casing it with a few exceptions.

https://git.sr.ht/~martijnbraam/keyring/tree/master/item/himitsu_gtk/window.py#L83

I did not account for imaps vs imap here, mainly there's not really a 
spec for this part. The title casing works a lot better with everything 
that's not an acronym like the web protocol.

On 10/22/22 01:59, Hugo Osvaldo Barrera wrote:
> For some odd reason, the casing of the protocol "titles" (e.g.: the labels on
> the top of each protocol) is mixed up; the first one is shown all uppercase
> ("SMTP"), while others are title-case ("Imaps", "Smtps", etc).
>
> A screenshot might be much clearer, but emails with image/png attachment are
> rejected from this list.
>
> I've no idea what could be causing this. IMHO, all uppercase ("SMTP") or all
> lowercase ("smtp") are best. "Title Case" can be confusing for things like
> "IMAP" where "Imap" looks too much like "lmap" on a sans-serif font (which is
> used by GTK by default).
>

[PATCH] Fix inconsistent case in title for some protocols

Details
Message ID
<20221025090213.7353-1-hugo@whynothugo.nl>
In-Reply-To
<db2a66ff-6025-4ca8-c9f5-daf004b03c10@brixit.nl> (view parent)
DKIM signature
missing
Download raw message
Patch: +2 -0
---
 himitsu_gtk/window.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/himitsu_gtk/window.py b/himitsu_gtk/window.py
index cdd6212..2886b5e 100644
--- a/himitsu_gtk/window.py
+++ b/himitsu_gtk/window.py
@@ -83,7 +83,9 @@ class KeyringWindow:
        titles = {
            'ssh': 'SSH',
            'imap': 'IMAP',
            'imaps': 'IMAPS',
            'smtp': 'SMTP',
            'smtps': 'SMTPS',
            'xmpp': 'XMPP',
            'irc': 'IRC',
        }
-- 
2.38.1
Reply to thread Export thread (mbox)