Hi Martijn,
Do you have any feedback on these patches sent a month ago?
- Use GtkSpinbox instead of GtkAdjustment to get integer value
- Gracefully handle doubles in URLs
They fix usage of custom period for TOTP in numberstation, otherwise
it's not possible to add TOTP with custom period through UI or URL.
On 22-12-04 00:43, Andrey Skvortsov wrote:
> Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>> ---> numberstation/window.py | 8 ++++----> 1 file changed, 4 insertions(+), 4 deletions(-)> > diff --git a/numberstation/window.py b/numberstation/window.py> index bdcf2bd..59fc9e7 100644> --- a/numberstation/window.py> +++ b/numberstation/window.py> @@ -42,8 +42,8 @@ class NumberstationWindow:> self.add_secret = builder.get_object("add_secret")> self.add_totp = builder.get_object("add_totp")> self.add_counter = builder.get_object("add_counter")> - self.add_length_adj = builder.get_object("add_length_adj")> - self.add_timer_adj = builder.get_object("add_timer_adj")> + self.add_length = builder.get_object("add_length")> + self.add_timer = builder.get_object("add_timer")> self.add_save = builder.get_object("add_save")> > self.hamburgermenu = builder.get_object("hamburgermenu")> @@ -291,8 +291,8 @@ class NumberstationWindow:> name = self.add_name.get_text().strip()> type = 'totp' if self.add_totp.get_active() else 'hotp'> secret = self.add_secret.get_text().strip()> - duration = self.add_timer_adj.get_value()> - length = self.add_length_adj.get_value()> + duration = self.add_timer.get_value_as_int()> + length = self.add_length.get_value_as_int()> counter = self.add_counter.get_text().strip()> if counter == '':> counter = None> -- > 2.35.1>
--
Best regards,
Andrey Skvortsov
Re: [PATCH numberstation] Use GtkSpinbox instead of GtkAdjustment to get integer value
Hi Andrey,
Sorry for the delay, I've applied your patches.
I had not encountered otp urls with decimals in them before, they don't
really make sense for things like length but better to handle it than
not I guess.
Greetings,
Martijn Braam
On 1/14/23 11:33, Andrey Skvortsov wrote:
> Hi Martijn,>> Do you have any feedback on these patches sent a month ago?> - Use GtkSpinbox instead of GtkAdjustment to get integer value> - Gracefully handle doubles in URLs>> They fix usage of custom period for TOTP in numberstation, otherwise> it's not possible to add TOTP with custom period through UI or URL.> > On 22-12-04 00:43, Andrey Skvortsov wrote:>> Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>>> --->> numberstation/window.py | 8 ++++---->> 1 file changed, 4 insertions(+), 4 deletions(-)>>>> diff --git a/numberstation/window.py b/numberstation/window.py>> index bdcf2bd..59fc9e7 100644>> --- a/numberstation/window.py>> +++ b/numberstation/window.py>> @@ -42,8 +42,8 @@ class NumberstationWindow:>> self.add_secret = builder.get_object("add_secret")>> self.add_totp = builder.get_object("add_totp")>> self.add_counter = builder.get_object("add_counter")>> - self.add_length_adj = builder.get_object("add_length_adj")>> - self.add_timer_adj = builder.get_object("add_timer_adj")>> + self.add_length = builder.get_object("add_length")>> + self.add_timer = builder.get_object("add_timer")>> self.add_save = builder.get_object("add_save")>> >> self.hamburgermenu = builder.get_object("hamburgermenu")>> @@ -291,8 +291,8 @@ class NumberstationWindow:>> name = self.add_name.get_text().strip()>> type = 'totp' if self.add_totp.get_active() else 'hotp'>> secret = self.add_secret.get_text().strip()>> - duration = self.add_timer_adj.get_value()>> - length = self.add_length_adj.get_value()>> + duration = self.add_timer.get_value_as_int()>> + length = self.add_length.get_value_as_int()>> counter = self.add_counter.get_text().strip()>> if counter == '':>> counter = None>> -- >> 2.35.1>>