~martijnbraam/public-inbox

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH logbookd] Fix -g option

Details
Message ID
<20231207220918.2016-1-clayton@craftyguy.net>
DKIM signature
missing
Download raw message
Patch: +1 -0
Without this, the falls through to the next case and throws an
error.

All credit goes to Caleb Connelly for spotting this!
---
 main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/main.c b/main.c
index b617bfc..9335c17 100644
--- a/main.c
+++ b/main.c
@@ -738,6 +738,7 @@ main(int argc, char *argv[])
					exit(1);
				}
				garbage_collect_threshold = ((int) res) * 1024;
				break;
			case '?':
				if (optopt == 'd' || optopt == 'l') {
					fprintf(stderr, "Option -%c requires an argument.\n", optopt);
-- 
2.43.0
Details
Message ID
<64279794-7eb0-4110-bf3e-64143bdb7fcf@brixit.nl>
In-Reply-To
<20231207220918.2016-1-clayton@craftyguy.net> (view parent)
DKIM signature
missing
Download raw message
Thanks, applied

On 12/7/23 23:09, Clayton Craft wrote:
> Without this, the falls through to the next case and throws an
> error.
>
> All credit goes to Caleb Connelly for spotting this!
> ---
>   main.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/main.c b/main.c
> index b617bfc..9335c17 100644
> --- a/main.c
> +++ b/main.c
> @@ -738,6 +738,7 @@ main(int argc, char *argv[])
>   					exit(1);
>   				}
>   				garbage_collect_threshold = ((int) res) * 1024;
> +				break;
>   			case '?':
>   				if (optopt == 'd' || optopt == 'l') {
>   					fprintf(stderr, "Option -%c requires an argument.\n", optopt);
Reply to thread Export thread (mbox)