Hello Martijn,

this is the second version after I found that the tests did not pass
[1].

The original message:

> I found out some changes I prepared last year to improve tests in the
> bare-py project. It would be nice if you have a bit of time for the
> review.

Thank you,
jiri

[1]: https://lists.sr.ht/~martijnbraam/public-inbox/patches/56525

Jiri Vlasak (6):
  Fix test_int typo
  Remove unused import
  Compare none using "is" (accomply to PEP8)
  Fix unpack varint test comment
  Extend varint tests with data from RFC's appendix
  Improve clarity of min/max values in integer tests

 bare/test_primitives.py | 22 ++++++++++-----------
 bare/test_varint.py     | 44 ++++++++++++++++++++++++++++++++---------
 2 files changed, 46 insertions(+), 20 deletions(-)

-- 
2.30.2

---
 bare/test_primitives.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bare/test_primitives.py b/bare/test_primitives.py
index 5315629..e18314e 100644
--- a/bare/test_primitives.py
@@ -81,7 +81,7 @@ class Test(TestCase):
         assert result == number
 
     @given(integers())
-    def test_i64(self, number):
+    def test_int(self, number):
         ast = BarePrimitive(TypeKind.INT)
         packed = _pack_primitive(ast, number)
         note(packed)
-- 
2.30.2

---
 bare/test_primitives.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bare/test_primitives.py b/bare/test_primitives.py
index e18314e..620b108 100644
--- a/bare/test_primitives.py
@@ -1,7 +1,7 @@
 from math import isnan
 from unittest import TestCase
 
-from hypothesis import given, note, seed
+from hypothesis import given, note
 from hypothesis.strategies import integers, floats, booleans, binary, tuples, text
 
 from bare import _pack_primitive, _unpack_primitive, BarePrimitive, TypeKind
-- 
2.30.2

---
 bare/test_primitives.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bare/test_primitives.py b/bare/test_primitives.py
index 620b108..b5f477e 100644
--- a/bare/test_primitives.py
@@ -155,4 +155,4 @@ class Test(TestCase):
         ast = BarePrimitive(TypeKind.Void)
         packed = _pack_primitive(ast, None)
         result = _unpack_primitive(ast, packed, 0)[0]
-        assert result == None
+        assert result is None
-- 
2.30.2

---
 bare/test_varint.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bare/test_varint.py b/bare/test_varint.py
index d3cd034..61e71f9 100644
--- a/bare/test_varint.py
@@ -27,7 +27,7 @@ class Test(TestCase):
         self.assertEqual(_unpack_varint(b'\0', 0, signed=True)[0], 0, 'int 0')
         self.assertEqual(_unpack_varint(b'\x02', 0, signed=True)[0], 1, 'int 1')
         self.assertEqual(_unpack_varint(b'\x01', 0, signed=True)[0], -1, 'int -1')
-        self.assertEqual(_unpack_varint(b'\xf1\x14', 0, signed=True)[0], -1337, 'int -1')
+        self.assertEqual(_unpack_varint(b'\xf1\x14', 0, signed=True)[0], -1337, 'int -1337')
 
     @given(integers(min_value=0))
     def test_unsigned_varint(self, number):
-- 
2.30.2

---
 bare/test_varint.py | 42 ++++++++++++++++++++++++++++++++++--------
 1 file changed, 34 insertions(+), 8 deletions(-)

diff --git a/bare/test_varint.py b/bare/test_varint.py
index 61e71f9..c20d065 100644
--- a/bare/test_varint.py
@@ -8,25 +8,51 @@ from bare import _pack_varint, _unpack_varint
 
 class Test(TestCase):
     def test__pack_varint(self):
-        self.assertEqual(_pack_varint(0), b'\0', 'uint zero')
-        self.assertEqual(_pack_varint(0x7F), b'\x7f', 'uint 0x7f')
+        self.assertEqual(_pack_varint(0), b'\x00', 'uint 0')
+        self.assertEqual(_pack_varint(1), b'\x01', 'uint 1')
+        self.assertEqual(_pack_varint(126), b'\x7e', 'uint 126')
+        self.assertEqual(_pack_varint(127), b'\x7f', 'uint 127')
+        self.assertEqual(_pack_varint(128), b'\x80\x01', 'uint 128')
+        self.assertEqual(_pack_varint(129), b'\x81\x01', 'uint 129')
         self.assertEqual(_pack_varint(0x1337), b'\xb7\x26', 'uint 0x1337')
+        self.assertEqual(_pack_varint(255), b'\xff\x01', 'uint 255')
 
-        self.assertEqual(_pack_varint(42, signed=True), b'\x54', 'int 42')
-        self.assertEqual(_pack_varint(0, signed=True), b'\0', 'int 0')
+        self.assertEqual(_pack_varint(0, signed=True), b'\x00', 'int 0')
         self.assertEqual(_pack_varint(1, signed=True), b'\x02', 'int 1')
         self.assertEqual(_pack_varint(-1, signed=True), b'\x01', 'int -1')
+        self.assertEqual(_pack_varint(42, signed=True), b'\x54', 'int 42')
+        self.assertEqual(_pack_varint(63, signed=True), b'\x7e', 'int 63')
+        self.assertEqual(_pack_varint(-63, signed=True), b'\x7d', 'int -63')
+        self.assertEqual(_pack_varint(64, signed=True), b'\x80\x01', 'int 64')
+        self.assertEqual(_pack_varint(-64, signed=True), b'\x7f', 'int -64')
+        self.assertEqual(_pack_varint(65, signed=True), b'\x82\x01', 'int 65')
+        self.assertEqual(_pack_varint(-65, signed=True), b'\x81\x01', 'int -65')
+        self.assertEqual(_pack_varint(255, signed=True), b'\xfe\x03', 'int 255')
+        self.assertEqual(_pack_varint(-255, signed=True), b'\xfd\x03', 'int -255')
         self.assertEqual(_pack_varint(-1337, signed=True), b'\xf1\x14', 'int -1337')
 
     def test__unpack_varint(self):
-        self.assertEqual(_unpack_varint(b'\0', 0)[0], 0, 'uint zero')
-        self.assertEqual(_unpack_varint(b'\x7f', 0)[0], 0x7f, 'uint 0x7f')
+        self.assertEqual(_unpack_varint(b'\x00', 0)[0], 0, 'uint 0')
+        self.assertEqual(_unpack_varint(b'\x01', 0)[0], 1, 'uint 1')
+        self.assertEqual(_unpack_varint(b'\x7e', 0)[0], 126, 'uint 126')
+        self.assertEqual(_unpack_varint(b'\x7f', 0)[0], 127, 'uint 127')
+        self.assertEqual(_unpack_varint(b'\x80\x01', 0)[0], 128, 'uint 128')
+        self.assertEqual(_unpack_varint(b'\x81\x01', 0)[0], 129, 'uint 129')
         self.assertEqual(_unpack_varint(b'\xb7\x26', 0)[0], 0x1337, 'uint 0x1337')
+        self.assertEqual(_unpack_varint(b'\xff\x01', 0)[0], 255, 'uint 255')
 
-        self.assertEqual(_unpack_varint(b'\x54', 0, signed=True)[0], 42, 'int 42')
-        self.assertEqual(_unpack_varint(b'\0', 0, signed=True)[0], 0, 'int 0')
+        self.assertEqual(_unpack_varint(b'\x00', 0, signed=True)[0], 0, 'int 0')
         self.assertEqual(_unpack_varint(b'\x02', 0, signed=True)[0], 1, 'int 1')
         self.assertEqual(_unpack_varint(b'\x01', 0, signed=True)[0], -1, 'int -1')
+        self.assertEqual(_unpack_varint(b'\x54', 0, signed=True)[0], 42, 'int 42')
+        self.assertEqual(_unpack_varint(b'\x7e', 0, signed=True)[0], 63, 'int 63')
+        self.assertEqual(_unpack_varint(b'\x7d', 0, signed=True)[0], -63, 'int -63')
+        self.assertEqual(_unpack_varint(b'\x80\x01', 0, signed=True)[0], 64, 'int 64')
+        self.assertEqual(_unpack_varint(b'\x7f', 0, signed=True)[0], -64, 'int -64')
+        self.assertEqual(_unpack_varint(b'\x82\x01', 0, signed=True)[0], 65, 'int 65')
+        self.assertEqual(_unpack_varint(b'\x81\x01', 0, signed=True)[0], -65, 'int -65')
+        self.assertEqual(_unpack_varint(b'\xfe\x03', 0, signed=True)[0], 255, 'int 255')
+        self.assertEqual(_unpack_varint(b'\xfd\x03', 0, signed=True)[0], -255, 'int -255')
         self.assertEqual(_unpack_varint(b'\xf1\x14', 0, signed=True)[0], -1337, 'int -1337')
 
     @given(integers(min_value=0))
-- 
2.30.2

---
 bare/test_primitives.py | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/bare/test_primitives.py b/bare/test_primitives.py
index b5f477e..badec6f 100644
--- a/bare/test_primitives.py
@@ -8,7 +8,7 @@ from bare import _pack_primitive, _unpack_primitive, BarePrimitive, TypeKind
 
 
 class Test(TestCase):
-    @given(integers(min_value=0, max_value=255))
+    @given(integers(min_value=0, max_value=2**8 - 1))
     def test_u8(self, number):
         ast = BarePrimitive(TypeKind.U8)
         packed = _pack_primitive(ast, number)
@@ -16,7 +16,7 @@ class Test(TestCase):
         result = _unpack_primitive(ast, packed, 0)[0]
         assert result == number
 
-    @given(integers(min_value=0, max_value=65535))
+    @given(integers(min_value=0, max_value=2**16 - 1))
     def test_u16(self, number):
         ast = BarePrimitive(TypeKind.U16)
         packed = _pack_primitive(ast, number)
@@ -24,7 +24,7 @@ class Test(TestCase):
         result = _unpack_primitive(ast, packed, 0)[0]
         assert result == number
 
-    @given(integers(min_value=0, max_value=4294967296))
+    @given(integers(min_value=0, max_value=2**32 - 1))
     def test_u32(self, number):
         ast = BarePrimitive(TypeKind.U32)
         packed = _pack_primitive(ast, number)
@@ -32,7 +32,7 @@ class Test(TestCase):
         result = _unpack_primitive(ast, packed, 0)[0]
         assert result == number
 
-    @given(integers(min_value=0, max_value=18446744073709551615))
+    @given(integers(min_value=0, max_value=2**64 - 1))
     def test_u64(self, number):
         ast = BarePrimitive(TypeKind.U64)
         packed = _pack_primitive(ast, number)
@@ -48,7 +48,7 @@ class Test(TestCase):
         result = _unpack_primitive(ast, packed, 0)[0]
         assert result == number
 
-    @given(integers(min_value=-128, max_value=127))
+    @given(integers(min_value=-2**7, max_value=2**7 - 1))
     def test_i8(self, number):
         ast = BarePrimitive(TypeKind.I8)
         packed = _pack_primitive(ast, number)
@@ -56,7 +56,7 @@ class Test(TestCase):
         result = _unpack_primitive(ast, packed, 0)[0]
         assert result == number
 
-    @given(integers(min_value=-32768, max_value=32767))
+    @given(integers(min_value=-2**15, max_value=2**15 - 1))
     def test_i16(self, number):
         ast = BarePrimitive(TypeKind.I16)
         packed = _pack_primitive(ast, number)
@@ -64,7 +64,7 @@ class Test(TestCase):
         result = _unpack_primitive(ast, packed, 0)[0]
         assert result == number
 
-    @given(integers(min_value=-2147483648, max_value=2147483647))
+    @given(integers(min_value=-2**31, max_value=2**31 - 1))
     def test_i32(self, number):
         ast = BarePrimitive(TypeKind.I32)
         packed = _pack_primitive(ast, number)
@@ -72,7 +72,7 @@ class Test(TestCase):
         result = _unpack_primitive(ast, packed, 0)[0]
         assert result == number
 
-    @given(integers(min_value=-9223372036854775808, max_value=9223372036854775807))
+    @given(integers(min_value=-2**63, max_value=2**63 - 1))
     def test_i64(self, number):
         ast = BarePrimitive(TypeKind.I64)
         packed = _pack_primitive(ast, number)
-- 
2.30.2

bare-py/patches/.build.yml: FAILED in 1m13s

[Improve tests][0] v2 from [Jiri Vlasak][1]

[0]: https://lists.sr.ht/~martijnbraam/public-inbox/patches/56528
[1]: jiri.hubacek@gmail.com

✗ #1392462 FAILED bare-py/patches/.build.yml https://builds.sr.ht/~martijnbraam/job/1392462

18. 12. 2024 23:41:29 builds.sr.ht <builds@sr.ht>:

> bare-py/patches/.build.yml: FAILED in 1m13s
>
> [Improve tests][0] v2 from [Jiri Vlasak][1]
>
> [0]: https://lists.sr.ht/~martijnbraam/public-inbox/patches/56528
> [1]: jiri.hubacek@gmail.com
>
> ✗ #1392462 FAILED bare-py/patches/.build.yml 
> https://builds.sr.ht/~martijnbraam/job/1392462

It looks there were some difficulties with srht bulds when the patchset 
was submitted. Re-triggering the build succeeded: 
https://builds.sr.ht/~qeef/job/1397661