~matklad

Recent activity

On code reviews 4 months ago

From Aleksey Kladov to ~bmp/inbox

Thanks for writing https://www.bitquabit.com/post/how-i-do-github-prs/
down! This is _exactly_ how I do code reviews! Some slight
differences:

For checking stuff out locally, I use the following script:

    fn pr(&self, pr: &str, review: bool) -> anyhow::Result<()> {
        let remote = self.remote;
        let main = self.main_branch;
        cmd!(self.sh, "git fetch {remote}").run()?;
        cmd!(self.sh, "git fetch {remote} refs/pull/{pr}/head").run()?;
        cmd!(self.sh, "git switch --detach FETCH_HEAD").run()?;
        if review {
            let base = cmd!(self.sh, "git merge-base FETCH_HEAD