~maxgyver83

Stuttgart, Germany

https://maximilian-schillinger.de

~maxgyver83/z.rc

Last active 4 days ago

~maxgyver83/emailbook

Last active 17 days ago

~maxgyver83/hare-jump.vim

Last active 6 months ago
View more

Recent activity

[PATCH hare-message v2] message::read_header: Skip header fields with invalid values 17 hours ago

From Max Schillinger to ~sircmpwn/hare-users

Signed-off-by: Max Schillinger <max@mxsr.de>
---
This is <https://lists.sr.ht/~sircmpwn/hare-users/patches/51405> rebased to
master.

 message/header.ha | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/message/header.ha b/message/header.ha
index 1f75513..5d1fdd5 100644
--- a/message/header.ha
+++ b/message/header.ha
@@ -1,6 +1,7 @@
use ascii;
[message trimmed]

Re: [PATCH hare v3] bufio: remove scanner inefficiency a day ago

From Max Schillinger to ~sircmpwn/hare-dev

On Sun May 26, 2024 at 7:11 PM CEST, Jose Lombera wrote:
> I just don't want to appear as the author of this modified version 
> because it's not the version I wrote nor have time to review it and 
> say I'm ok with whatever changes were required on top of my patch.

No problem. I can put myself as author of this patch. (I never wanted 
you to take over responsibility for my changes. I just didn't want to 
take credits for your work.)

> For the same reason, I don't want my sign-off to appear in something I 
> didn't review.

This still sounds like signing off means to you giving an approval. I 
also understand it like Lorenz wrote: It only means giving away the

Re: [PATCH hare v3] bufio: remove scanner inefficiency 3 days ago

From Max Schillinger to ~sircmpwn/hare-dev

On Sat May 25, 2024 at 6:22 AM CEST, Lorenz (xha) wrote:
> this version is OK. thank you!

Thank you for your fix!


Apart from that: I still don't understand how sourcehut works. My e-mail 
with v3 of this patch shows up on 
<https://lists.sr.ht/~sircmpwn/hare-dev> between `[PATCH hare v5] 
NetBSD: port Hare to NetBSD/amd64` and `[PATCH hare v6] NetBSD: port 
Hare to NetBSD/amd64`. But it's missing on the patches page:
<https://lists.sr.ht/~sircmpwn/hare-dev/patches>

Is this a bug in sourcehut? Or is something missing my e-mail header?

Re: [PATCH hare v2 1/1] bufio: remove scanner inefficiency 3 days ago

From Max Schillinger to ~sircmpwn/hare-dev

On Thu May 23, 2024 at 7:59 PM CEST, Lorenz (xha) wrote:
> i would remove "buf_len"; it's confusing because there is (1) a
> variable "buf" in this scope and (2) obscures code, len(scan.buffer)
> is much more readable in the two places it's used anyways.
>
> > +
> > +	if ((start + pending) >= buf_len) {

Thank your for his hint. I think it's the C way trying not to call the 
same [str]len twice. :-)


> the logic in this else branch is completely broken; here's an example:

[PATCH hare v3] bufio: remove scanner inefficiency 3 days ago

From Max Schillinger to ~sircmpwn/hare-dev

[PATCH hare v3] bufio: remove scanner inefficiency

v3 includes Lorenz' fix as provided as comment on v2:

https://lists.sr.ht/~sircmpwn/hare-dev/patches/50792

[PATCH hare v3] bufio: remove scanner inefficiency 3 days ago

From Max Schillinger to ~sircmpwn/hare-dev

From: Jose Lombera <jose@lombera.dev>

The new scanner with an internal read-ahead buffer contains an
inefficiency in which the underlying buffer is shifted left every time a
token is consumed.

Fix this by delaying the shift until an actual read-ahead from the
source IO handle is made, and only if the shift is required.

Co-authored-by: Max Schillinger <max@mxsr.de>
Co-authored-by: Lorenz (xha) <me@xha.li>
Signed-off-by: Jose Lombera <jose@lombera.dev>
Signed-off-by: Max Schillinger <max@mxsr.de>
---
[message trimmed]

Re: [PATCH lists.sr.ht] Use format=flowed for automatic answer e-mails 5 days ago

From Max Schillinger to ~sircmpwn/public-inbox

On Wed May 22, 2024 at 7:26 PM CEST, Max Schillinger wrote:
> I think that either a Python module turns LF into CRLF automatically 
> or aerc "fixed" it on the receiving end. I'll try to find it out.

`lists.sr.ht/listssrht/process.py` sends e-mails via 
`smtplib.SMTP.send_message`. And this seems to use CRLF as line 
separator automatically:

> `send_message` serializes `msg` using BytesGenerator with `\r\n` as 
> the linesep, and calls `sendmail()` to transmit the resulting message.

https://docs.python.org/3/library/smtplib.html#smtplib.SMTP.send_message

Then I can leave the line endings as they are, right?

Re: [PATCH lists.sr.ht] Use format=flowed for automatic answer e-mails 5 days ago

From Max Schillinger to ~sircmpwn/public-inbox

On Wed May 22, 2024 at 2:44 PM CEST, Drew DeVault wrote:
> This patch looks good to me, but per the comments perhaps this would be
> a good opportunity to use CRLF here. Can you respin the patch with that
> addition? Just stick \r at the end of every line and call it a day.

Are you sure, the '\r' is really missing? I can't find the original 
e-mail anymore but a similar e-mail with an `unknown_mailing_list_error` 
seems to contain CRLF line endings:


$ cat --show-all /tmp/mail
Hi Max Schillinger!^M$
^M$
We received your email, but were unable to deliver it because the^M$

Re: Another FTBFS on rc 14 days ago

From Max Schillinger to ~sircmpwn/hare-users

On Mon May 13, 2024 at 8:59 AM CEST, Matěj Cepl wrote:
> On Mon May 13, 2024 at 8:32 AM CEST, Max Schillinger wrote:
> > have you added the madeline directory to your HAREPATH?
>
> No, fixed madeline package
> (https://build.opensuse.org/projects/home:mcepl:hare/packages/madeline/files/madeline.spec)
> to install properly into /usr/src/hare/third-party.
>
> Best,
>
> Matěj

I see. I should have updated my inbox before answering :-) I got your 
mail about how you fixed this after sending my mail.

Re: Another FTBFS on rc 15 days ago

From Max Schillinger to ~sircmpwn/hare-users

Am 13. Mai 2024 01:20:56 MESZ schrieb "Matěj Cepl" <mcepl@cepl.eu>:
>Do I do something wrong, or there is just a bug in rc?

Hi Matěj,

have you added the madeline directory to your HAREPATH?

Best,
Max