~mil/mepo-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH mepo] unpin zig patch number

Details
Message ID
<20230201144230.42194-1-laalsaas@systemli.org>
DKIM signature
missing
Download raw message
Patch: +2 -2
A patch release shouldn't have any breaking changes. However, pinning
the patch means reducing the tolerance for different zig versions in
software repositorys to zero.
---
NixOS only has zig 0.10.1, however mepo 1.1.1 still pins zig 0.10.0,
while mepo 1.1.2 isn't released yet.

 src/main.zig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main.zig b/src/main.zig
index 513038e..33c78f2 100644
--- a/src/main.zig
+++ b/src/main.zig
@@ -11,8 +11,8 @@ const utildbg = @import("./util/utildbg.zig");
pub fn main() !void {
    comptime {
        const v = builtin.zig_version;
        if (v.major != 0 or v.minor != 10 or v.patch != 1)
            @panic("Must be built against Zig 0.10.1");
        if (v.major != 0 or v.minor != 10)
            @panic("Must be built against Zig 0.10.x");
    }

    const allocator = std.heap.c_allocator;
-- 
2.38.1
Details
Message ID
<9428e696-b207-4cd2-90ac-e630cc1f5744@app.fastmail.com>
In-Reply-To
<20230201144230.42194-1-laalsaas@systemli.org> (view parent)
DKIM signature
missing
Download raw message
On Wed, Feb 1, 2023, at 9:42 AM, laalsaas wrote:
> A patch release shouldn't have any breaking changes. However, pinning
> the patch means reducing the tolerance for different zig versions in
> software repositorys to zero.
> ---
> NixOS only has zig 0.10.1, however mepo 1.1.1 still pins zig 0.10.0,
> while mepo 1.1.2 isn't released yet.
>
>  src/main.zig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/main.zig b/src/main.zig
> index 513038e..33c78f2 100644
> --- a/src/main.zig
> +++ b/src/main.zig
> @@ -11,8 +11,8 @@ const utildbg = @import("./util/utildbg.zig");
>  pub fn main() !void {
>      comptime {
>          const v = builtin.zig_version;
> -        if (v.major != 0 or v.minor != 10 or v.patch != 1)
> -            @panic("Must be built against Zig 0.10.1");
> +        if (v.major != 0 or v.minor != 10)
> +            @panic("Must be built against Zig 0.10.x");
>      }
> 
>      const allocator = std.heap.c_allocator;
> -- 
> 2.38.1

Thanks for pointing this out. Good point that we shouldn't be pinning
against patch versions for zig. I hadn't realized zig had a policy to
not introduce standard library changes between patch versions and only
for major/minor versions.

Going forward and for future releases, your patch has been applied and
we'll target only zig major/minor versions.

In regards to current tags in the interim, sorry for any confusion,
tags should be published:
- Mepo 1.1.2 -> builds against Zig 0.10.1
- Mepo 1.1.1 -> builds against Zig 0.10.0

Miles
Reply to thread Export thread (mbox)