~mil/sxmo-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 3

[PATCH sxmo-utils] enable bluetooth and modem drivers during crust suspend

Details
Message ID
<20201027201449.12587-1-anjan@momi.ca>
DKIM signature
missing
Download raw message
Patch: +0 -14
With the megi 5.9 kernel and other suspend-related merge requests in
postmarketos, disabling these drivers is no longer needed. All of this
should result in a more reliable suspending system.

Source: https://gitlab.com/postmarketOS/pmaports/-/merge_requests/1651
---
 programs/sxmo_screenlock.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/programs/sxmo_screenlock.c b/programs/sxmo_screenlock.c
index 30a3e13..514b956 100644
--- a/programs/sxmo_screenlock.c
+++ b/programs/sxmo_screenlock.c
@@ -90,20 +90,6 @@ configuresuspendsettingsandwakeupsources()
		"enabled"
	);

	// Temporary hack to disable USB driver that doesn't suspend
	fprintf(stderr, "Disabling buggy USB driver\n");
	writefile(
		"/sys/devices/platform/soc/1c19000.usb/driver/unbind",
		"1c19000.usb"
	);

	// Temporary hack to disable Bluetooth driver that crashes on suspend 1/5th the time
	fprintf(stderr, "Disabling buggy Bluetooth driver\n");
	writefile(
		"/sys/bus/serial/drivers/hci_uart_h5/unbind",
		"serial0-0"
	);

	// E.g. make sure we're using CRUST
	fprintf(stderr, "Flip mem_sleep setting to use crust\n");
	writefile("/sys/power/mem_sleep", "deep");
-- 
2.29.1
Details
Message ID
<20201030231831.r5ovj6ixrwirckoo@worker.anaproy.lxd>
In-Reply-To
<20201027201449.12587-1-anjan@momi.ca> (view parent)
DKIM signature
missing
Download raw message
This looks good to me, the less temporary hacks the better. Have you
been testing this the past few days? Does it indeed not negatively
impact the suspension? Since the 5.9 upgrade it does all seem more
reliable and less crashy.


On 20-10-27 04:14, Anjandev Momi wrote:
> With the megi 5.9 kernel and other suspend-related merge requests in
> postmarketos, disabling these drivers is no longer needed. All of this
> should result in a more reliable suspending system.
>
> Source: https://gitlab.com/postmarketOS/pmaports/-/merge_requests/1651
> ---
>  programs/sxmo_screenlock.c | 14 --------------
>  1 file changed, 14 deletions(-)
>
> diff --git a/programs/sxmo_screenlock.c b/programs/sxmo_screenlock.c
> index 30a3e13..514b956 100644
> --- a/programs/sxmo_screenlock.c
> +++ b/programs/sxmo_screenlock.c
> @@ -90,20 +90,6 @@ configuresuspendsettingsandwakeupsources()
>  		"enabled"
>  	);
>
> -	// Temporary hack to disable USB driver that doesn't suspend
> -	fprintf(stderr, "Disabling buggy USB driver\n");
> -	writefile(
> -		"/sys/devices/platform/soc/1c19000.usb/driver/unbind",
> -		"1c19000.usb"
> -	);
> -
> -	// Temporary hack to disable Bluetooth driver that crashes on suspend 1/5th the time
> -	fprintf(stderr, "Disabling buggy Bluetooth driver\n");
> -	writefile(
> -		"/sys/bus/serial/drivers/hci_uart_h5/unbind",
> -		"serial0-0"
> -	);
> -
>  	// E.g. make sure we're using CRUST
>  	fprintf(stderr, "Flip mem_sleep setting to use crust\n");
>  	writefile("/sys/power/mem_sleep", "deep");
> --
> 2.29.1
Details
Message ID
<87pn4zch9e.fsf@momi.ca>
In-Reply-To
<20201030231831.r5ovj6ixrwirckoo@worker.anaproy.lxd> (view parent)
DKIM signature
missing
Download raw message
Maarten van Gompel <proycon@anaproy.nl> writes:

> This looks good to me, the less temporary hacks the better. Have you
> been testing this the past few days? Does it indeed not negatively
> impact the suspension? Since the 5.9 upgrade it does all seem more
> reliable and less crashy.

I have been testing for the last couple days. The issue with this patch
is that if the modem is on, I suspend the phone, and then unsuspend, I
cannot use any of the modem's functions. I must reboot the phone before
I can send texts again. I dont remember that being the case without this
patch.

Please try out this patch and let me know.

Cheers,
Anjan Momi
-- 
w:] www.momi.ca
pgp:] https://momi.ca/publickey.txt
Details
Message ID
<3K6A3SPBJ7ADF.3ES6WZXLG8L88@milesalan.com>
In-Reply-To
<20201030231831.r5ovj6ixrwirckoo@worker.anaproy.lxd> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
Maarten van Gompel <proycon@anaproy.nl> wrote:
> This looks good to me, the less temporary hacks the better. Have you
> been testing this the past few days? Does it indeed not negatively
> impact the suspension? Since the 5.9 upgrade it does all seem more
> reliable and less crashy.
> 
> 
> On 20-10-27 04:14, Anjandev Momi wrote:
> > With the megi 5.9 kernel and other suspend-related merge requests in
> > postmarketos, disabling these drivers is no longer needed. All of this
> > should result in a more reliable suspending system.
> >

Thanks Anjan - this is way more reliable from my testing. I've applied
for now, if we have issues we can always look back into blacklisting.

Also a nice thing about this is I noticed instablity previously when
receiving calls from CRUST without this; but with re-enabling the USB
driver things work fine as modemmanager is able to handle.

Miles
Reply to thread Export thread (mbox)