~mil/sxmo-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH sxmo-utils] do not use sxmo_hooks.sh for the icon hook (the hook variables don't live long enough)

Details
Message ID
<20210722175035.386177-1-proycon@anaproy.nl>
DKIM signature
missing
Download raw message
Patch: +1 -1
The current icons hook via sxmo_hooks.sh never worked, we need to really
source it. See also the discussion in the IRC channel today:

---
 scripts/core/sxmo_common.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/core/sxmo_common.sh b/scripts/core/sxmo_common.sh
index d2e10bd..44317b8 100644
--- a/scripts/core/sxmo_common.sh
+++ b/scripts/core/sxmo_common.sh
@@ -255,4 +255,4 @@ icon_bok=""
icon_map=""

#allow the user to override icons
sxmo_hooks.sh icons
[ -x "$XDG_CONFIG_HOME/sxmo/hooks/icons" ] && source "$XDG_CONFIG_HOME/sxmo/hooks/icons"
--
2.32.0

[sxmo-utils/patches/.build.yml] build failed

builds.sr.ht
Details
Message ID
<CCZV00SQY38U.2HHWV8O802FWO@cirno>
In-Reply-To
<20210722175035.386177-1-proycon@anaproy.nl> (view parent)
DKIM signature
missing
Download raw message
sxmo-utils/patches/.build.yml: FAILED in 21s

[do not use sxmo_hooks.sh for the icon hook (the hook variables don't live long enough)][0] from [Maarten van Gompel][1]

[0]: https://lists.sr.ht/~mil/sxmo-devel/patches/23936
[1]: proycon@anaproy.nl

✗ #550257 FAILED sxmo-utils/patches/.build.yml https://builds.sr.ht/~mil/job/550257

Re: [PATCH sxmo-utils] do not use sxmo_hooks.sh for the icon hook (the hook variables don't live long

Details
Message ID
<3LX770FRBW2NP.27THD8NL3YNMT@stacyharper.net>
In-Reply-To
<20210722175035.386177-1-proycon@anaproy.nl> (view parent)
DKIM signature
pass
Download raw message
Nice catch

To git.sr.ht:~mil/sxmo-utils
   044e756..d1f4561  d1f4561 -> master
Reply to thread Export thread (mbox)