~mil/sxmo-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH sxmo-utils] fix Save context menu entry in vim/vis/kakoune

Details
Message ID
<20220302143055.378905-1-bruno.dupuis@protonmail.com>
DKIM signature
missing
Download raw message
Patch: +1 -1
This is more than cosmetic. In sxmo_appmenu.sh this line:

```
CMD="$(printf "%s\n" "$CHOICES" | grep -m1 -F "$PICKED" | cut -d '^' -f3)"
```

finds the command of the first entry that has `$PICKED` prefix.
Before this change it would pick `$icon_cls Save and Quit`.

The bug is realy sxmo_appmenu.sh, but it's hard to change the
`grep -F` into a `grep -e "^$PICKED\s^ [01] ^"` while guarantying
nothing breaks.

---
 configs/default_hooks/sxmo_hook_contextmenu.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configs/default_hooks/sxmo_hook_contextmenu.sh b/configs/default_hooks/sxmo_hook_contextmenu.sh
index 6501dc3..fd8796b 100644
--- a/configs/default_hooks/sxmo_hook_contextmenu.sh
+++ b/configs/default_hooks/sxmo_hook_contextmenu.sh
@@ -188,7 +188,7 @@ case "$WMCLASS" in
			#Vim in foot
			CHOICES="
				$icon_cls Save and Quit    ^ 0 ^ sxmo_type -k Escape -s 300 ':wq' -k Return
				$icon_cls Save             ^ 0 ^ sxmo_type -k Escape -s 300 ':w' -k Return
				$icon_sav Save             ^ 0 ^ sxmo_type -k Escape -s 300 ':w' -k Return
				$icon_cls Quit without saving  ^ 0 ^ sxmo_type -k Escape -s 300 ':q!' -k Return
				$icon_aru Scroll up        ^ 1 ^ sxmo_type -M Ctrl u
				$icon_ard Scroll down      ^ 1 ^ sxmo_type -M Ctrl d
-- 
2.35.1

[sxmo-utils/patches/.build.yml] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CI9GCY34RTN6.12U0Q9A22EN34@cirno2>
In-Reply-To
<20220302143055.378905-1-bruno.dupuis@protonmail.com> (view parent)
DKIM signature
missing
Download raw message
sxmo-utils/patches/.build.yml: SUCCESS in 22s

[fix Save context menu entry in vim/vis/kakoune][0] from [Bruno Dupuis][1]

[0]: https://lists.sr.ht/~mil/sxmo-devel/patches/29936
[1]: bruno.dupuis@protonmail.com

✓ #707138 SUCCESS sxmo-utils/patches/.build.yml https://builds.sr.ht/~mil/job/707138
Details
Message ID
<2GEEWBB6RHKS8.2H4CII461X05J@stacyharper.net>
In-Reply-To
<20220302143055.378905-1-bruno.dupuis@protonmail.com> (view parent)
DKIM signature
missing
Download raw message
Okay I understand the issue. I would prefer that we fix this detection
issue completly but for the moment I merge this. Thanks for digging into
it !

To git.sr.ht:~mil/sxmo-utils
   d96297f5..19709686  19709686 -> master
Reply to thread Export thread (mbox)