~mil/sxmo-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH sxmo-utils] shellcheck: check all scripts

Details
Message ID
<20220524181613.1270137-1-aren@peacevolution.org>
DKIM signature
pass
Download raw message
Patch: +1 -1
Hooks, migrations, sxmo_init.sh, and setup_config_version.sh weren't
being checked by shellcheck.

The --shell parameter is necessary to be able to run shellcheck on
shellspec test files, since they don't have a shebang line.
---

Notes:
    The ci configuration will also need to be updated to check these files.
    It might make sense to only check files that were changed from the
    origin, so we don't get false test failures until they're cleaned up.
    This snippet should do that:

    git diff -z --name-only origin/master..HEAD |
    	grep -z '\.sh$' |
    	xargs -0 shellcheck --shell=sh -x

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index c8dc2b4..28133ba 100644
--- a/Makefile
+++ b/Makefile
@@ -16,7 +16,7 @@ all: $(PROGRAMS)
test: shellcheck

shellcheck:
	shellcheck -x scripts/*/*.sh
	find . -type f -name '*.sh' -print0 | xargs -0 shellcheck -x --shell=sh

programs/sxmo_vibrate: programs/sxmo_vibrate.c
	$(CC) -o programs/sxmo_vibrate programs/sxmo_vibrate.c
-- 
2.36.1

[sxmo-utils/patches/.build.yml] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CK874S4WUCWD.1OX9QM5SVE099@cirno2>
In-Reply-To
<20220524181613.1270137-1-aren@peacevolution.org> (view parent)
DKIM signature
missing
Download raw message
sxmo-utils/patches/.build.yml: SUCCESS in 25s

[shellcheck: check all scripts][0] from [ArenM][1]

[0]: https://lists.sr.ht/~mil/sxmo-devel/patches/32496
[1]: aren@peacevolution.org

✓ #765597 SUCCESS sxmo-utils/patches/.build.yml https://builds.sr.ht/~mil/job/765597
Details
Message ID
<28EG9DYI3KGP4.3VZP7DH4DR9LM@stacyharper.net>
In-Reply-To
<20220524181613.1270137-1-aren@peacevolution.org> (view parent)
DKIM signature
pass
Download raw message
Applied with additional patchs to fix some issues and to adapt the build
recipe.

About the side note, I dont think we have / want to ignore issues
that existed before the submitted patch.

Thanks a lot for this !

To git.sr.ht:~mil/sxmo-utils
   c3558e1e..7899904e  7899904e -> master
Reply to thread Export thread (mbox)