~mil/sxmo-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
4 4

[PATCH sxmo-utils v2] Add device profile for Samsung devices

Details
Message ID
<20230531124231.45508-1-raymondhackley@protonmail.com>
DKIM signature
missing
Download raw message
Patch: +8 -0
Add device profile for the following Samsung devices:
- Samsung Galaxy E7 (samsung,e7)
- Samsung Galaxy Grand Max (samsung,grandmax)
- Samsung Galaxy J5 2015 and 2016 (samsung,j5(x))

v2: Add missing scripts/deviceprofiles/sxmo_deviceprofile_samsung,*.sh
---
 configs/default_hooks/samsung,e7                              | 1 +
 configs/default_hooks/samsung,grandmax                        | 1 +
 configs/default_hooks/samsung,j5                              | 1 +
 configs/default_hooks/samsung,j5x                             | 1 +
 scripts/deviceprofiles/sxmo_deviceprofile_samsung,e7.sh       | 1 +
 scripts/deviceprofiles/sxmo_deviceprofile_samsung,grandmax.sh | 1 +
 scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5.sh       | 1 +
 scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5x.sh      | 1 +
 8 files changed, 8 insertions(+)
 create mode 120000 configs/default_hooks/samsung,e7
 create mode 120000 configs/default_hooks/samsung,grandmax
 create mode 120000 configs/default_hooks/samsung,j5
 create mode 120000 configs/default_hooks/samsung,j5x
 create mode 120000 scripts/deviceprofiles/sxmo_deviceprofile_samsung,e7.sh
 create mode 120000 scripts/deviceprofiles/sxmo_deviceprofile_samsung,grandmax.sh
 create mode 120000 scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5.sh
 create mode 120000 scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5x.sh

diff --git a/configs/default_hooks/samsung,e7 b/configs/default_hooks/samsung,e7
new file mode 120000
index 0000000..678f8b1
--- /dev/null
+++ b/configs/default_hooks/samsung,e7
@@ -0,0 +1 @@
three_button_touchscreen
\ No newline at end of file
diff --git a/configs/default_hooks/samsung,grandmax b/configs/default_hooks/samsung,grandmax
new file mode 120000
index 0000000..678f8b1
--- /dev/null
+++ b/configs/default_hooks/samsung,grandmax
@@ -0,0 +1 @@
three_button_touchscreen
\ No newline at end of file
diff --git a/configs/default_hooks/samsung,j5 b/configs/default_hooks/samsung,j5
new file mode 120000
index 0000000..678f8b1
--- /dev/null
+++ b/configs/default_hooks/samsung,j5
@@ -0,0 +1 @@
three_button_touchscreen
\ No newline at end of file
diff --git a/configs/default_hooks/samsung,j5x b/configs/default_hooks/samsung,j5x
new file mode 120000
index 0000000..678f8b1
--- /dev/null
+++ b/configs/default_hooks/samsung,j5x
@@ -0,0 +1 @@
three_button_touchscreen
\ No newline at end of file
diff --git a/scripts/deviceprofiles/sxmo_deviceprofile_samsung,e7.sh b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,e7.sh
new file mode 120000
index 0000000..07e4ae9
--- /dev/null
+++ b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,e7.sh
@@ -0,0 +1 @@
sxmo_deviceprofile_samsung,a5u-eur.sh
\ No newline at end of file
diff --git a/scripts/deviceprofiles/sxmo_deviceprofile_samsung,grandmax.sh b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,grandmax.sh
new file mode 120000
index 0000000..07e4ae9
--- /dev/null
+++ b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,grandmax.sh
@@ -0,0 +1 @@
sxmo_deviceprofile_samsung,a5u-eur.sh
\ No newline at end of file
diff --git a/scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5.sh b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5.sh
new file mode 120000
index 0000000..07e4ae9
--- /dev/null
+++ b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5.sh
@@ -0,0 +1 @@
sxmo_deviceprofile_samsung,a5u-eur.sh
\ No newline at end of file
diff --git a/scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5x.sh b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5x.sh
new file mode 120000
index 0000000..07e4ae9
--- /dev/null
+++ b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5x.sh
@@ -0,0 +1 @@
sxmo_deviceprofile_samsung,a5u-eur.sh
\ No newline at end of file
-- 
2.30.2

[sxmo-utils/patches/test.yml] build failed

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CT0H01L2FP7P.CNBJOANWP8VL@cirno2>
In-Reply-To
<20230531124231.45508-1-raymondhackley@protonmail.com> (view parent)
DKIM signature
missing
Download raw message
sxmo-utils/patches/test.yml: FAILED in 18s

[Add device profile for Samsung devices][0] v2 from [Raymond Hackley][1]

[0]: https://lists.sr.ht/~mil/sxmo-devel/patches/41542
[1]: raymondhackley@protonmail.com

✗ #999051 FAILED sxmo-utils/patches/test.yml https://builds.sr.ht/~mil/job/999051
Details
Message ID
<c52vvvtoj63peexnym5gbgfm23lv4qg6y7vqjhvilobp2ez64o@6ftf74gzz4hy>
In-Reply-To
<20230531124231.45508-1-raymondhackley@protonmail.com> (view parent)
DKIM signature
missing
Download raw message
On Wed, May 31, 2023 at 12:42:42PM +0000, Raymond Hackley wrote:
> Add device profile for the following Samsung devices:
> - Samsung Galaxy E7 (samsung,e7)
> - Samsung Galaxy Grand Max (samsung,grandmax)
> - Samsung Galaxy J5 2015 and 2016 (samsung,j5(x))

Can you include the full contents of /proc/device-tree/compatible for
these phones (it's null delimited, so you might want to do something
like `tr '\0' '|' < /proc/device-tree/compatible`)? I have some ideas
for refactoring that would make it possible for these to be merged into
one msm8916 entry.

> 
> v2: Add missing scripts/deviceprofiles/sxmo_deviceprofile_samsung,*.sh
> ---
>  configs/default_hooks/samsung,e7                              | 1 +
>  configs/default_hooks/samsung,grandmax                        | 1 +
>  configs/default_hooks/samsung,j5                              | 1 +
>  configs/default_hooks/samsung,j5x                             | 1 +
>  scripts/deviceprofiles/sxmo_deviceprofile_samsung,e7.sh       | 1 +
>  scripts/deviceprofiles/sxmo_deviceprofile_samsung,grandmax.sh | 1 +
>  scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5.sh       | 1 +
>  scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5x.sh      | 1 +
>  8 files changed, 8 insertions(+)
>  create mode 120000 configs/default_hooks/samsung,e7
>  create mode 120000 configs/default_hooks/samsung,grandmax
>  create mode 120000 configs/default_hooks/samsung,j5
>  create mode 120000 configs/default_hooks/samsung,j5x
>  create mode 120000 scripts/deviceprofiles/sxmo_deviceprofile_samsung,e7.sh
>  create mode 120000 scripts/deviceprofiles/sxmo_deviceprofile_samsung,grandmax.sh
>  create mode 120000 scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5.sh
>  create mode 120000 scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5x.sh
> 
> diff --git a/configs/default_hooks/samsung,e7 b/configs/default_hooks/samsung,e7
> new file mode 120000
> index 0000000..678f8b1
> --- /dev/null
> +++ b/configs/default_hooks/samsung,e7
> @@ -0,0 +1 @@
> +three_button_touchscreen
> \ No newline at end of file
> diff --git a/configs/default_hooks/samsung,grandmax b/configs/default_hooks/samsung,grandmax
> new file mode 120000
> index 0000000..678f8b1
> --- /dev/null
> +++ b/configs/default_hooks/samsung,grandmax
> @@ -0,0 +1 @@
> +three_button_touchscreen
> \ No newline at end of file
> diff --git a/configs/default_hooks/samsung,j5 b/configs/default_hooks/samsung,j5
> new file mode 120000
> index 0000000..678f8b1
> --- /dev/null
> +++ b/configs/default_hooks/samsung,j5
> @@ -0,0 +1 @@
> +three_button_touchscreen
> \ No newline at end of file
> diff --git a/configs/default_hooks/samsung,j5x b/configs/default_hooks/samsung,j5x
> new file mode 120000
> index 0000000..678f8b1
> --- /dev/null
> +++ b/configs/default_hooks/samsung,j5x
> @@ -0,0 +1 @@
> +three_button_touchscreen
> \ No newline at end of file
> diff --git a/scripts/deviceprofiles/sxmo_deviceprofile_samsung,e7.sh b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,e7.sh
> new file mode 120000
> index 0000000..07e4ae9
> --- /dev/null
> +++ b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,e7.sh
> @@ -0,0 +1 @@
> +sxmo_deviceprofile_samsung,a5u-eur.sh
> \ No newline at end of file
> diff --git a/scripts/deviceprofiles/sxmo_deviceprofile_samsung,grandmax.sh b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,grandmax.sh
> new file mode 120000
> index 0000000..07e4ae9
> --- /dev/null
> +++ b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,grandmax.sh
> @@ -0,0 +1 @@
> +sxmo_deviceprofile_samsung,a5u-eur.sh
> \ No newline at end of file
> diff --git a/scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5.sh b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5.sh
> new file mode 120000
> index 0000000..07e4ae9
> --- /dev/null
> +++ b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5.sh
> @@ -0,0 +1 @@
> +sxmo_deviceprofile_samsung,a5u-eur.sh
> \ No newline at end of file
> diff --git a/scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5x.sh b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5x.sh
> new file mode 120000
> index 0000000..07e4ae9
> --- /dev/null
> +++ b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5x.sh
> @@ -0,0 +1 @@
> +sxmo_deviceprofile_samsung,a5u-eur.sh
> \ No newline at end of file
> -- 
> 2.30.2
> 
> 
Details
Message ID
<20230602165248.14793-1-raymondhackley@protonmail.com>
In-Reply-To
<c52vvvtoj63peexnym5gbgfm23lv4qg6y7vqjhvilobp2ez64o@6ftf74gzz4hy> (view parent)
DKIM signature
missing
Download raw message
Hi Aren,

On Wed, May 31, 2023 at 15:42:30 UTC you wrote:
> On Wed, May 31, 2023 at 12:42:42PM +0000, Raymond Hackley wrote:
> > Add device profile for the following Samsung devices:
> > - Samsung Galaxy E7 (samsung,e7)
> > - Samsung Galaxy Grand Max (samsung,grandmax)
> > - Samsung Galaxy J5 2015 and 2016 (samsung,j5(x))
> 
> Can you include the full contents of /proc/device-tree/compatible for
> these phones (it's null delimited, so you might want to do something
> like `tr '\0' '|' < /proc/device-tree/compatible`)? I have some ideas
> for refactoring that would make it possible for these to be merged into
> one msm8916 entry.
> 

```
$ tr '\0' '|' < /proc/device-tree/compatible; echo
samsung,e7|qcom,msm8916|
```

However, not every "qcom,msm8916" device has 3-buttons layout, which is
common on Samsung devices.

Reference:
https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/qcom/msm8916-samsung-e5.dts#L22
https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/qcom/msm8916-samsung-e7.dts#L22
https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts#L9
https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/qcom/msm8916-samsung-j5x.dts#L9
https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/qcom/msm8916-samsung-grandmax.dts#L23

Regards,
Raymond

> > v2: Add missing scripts/deviceprofiles/sxmo_deviceprofile_samsung,*.sh
> > ---
> > 
> >  configs/default_hooks/samsung,e7                              | 1 +
> >  configs/default_hooks/samsung,grandmax                        | 1 +
> >  configs/default_hooks/samsung,j5                              | 1 +
> >  configs/default_hooks/samsung,j5x                             | 1 +
> >  scripts/deviceprofiles/sxmo_deviceprofile_samsung,e7.sh       | 1 +
> >  scripts/deviceprofiles/sxmo_deviceprofile_samsung,grandmax.sh | 1 +
> >  scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5.sh       | 1 +
> >  scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5x.sh      | 1 +
> >  8 files changed, 8 insertions(+)
> >  create mode 120000 configs/default_hooks/samsung,e7
> >  create mode 120000 configs/default_hooks/samsung,grandmax
> >  create mode 120000 configs/default_hooks/samsung,j5
> >  create mode 120000 configs/default_hooks/samsung,j5x
> >  create mode 120000
> >  scripts/deviceprofiles/sxmo_deviceprofile_samsung,e7.sh
> >  create mode 120000
> >  scripts/deviceprofiles/sxmo_deviceprofile_samsung,grandmax.sh create
> >  mode 120000 scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5.sh
> >  create mode 120000
> >  scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5x.sh> 
> > diff --git a/configs/default_hooks/samsung,e7
> > b/configs/default_hooks/samsung,e7 new file mode 120000
> > index 0000000..678f8b1
> > --- /dev/null
> > +++ b/configs/default_hooks/samsung,e7
> > @@ -0,0 +1 @@
> > +three_button_touchscreen
> > \ No newline at end of file
> > diff --git a/configs/default_hooks/samsung,grandmax
> > b/configs/default_hooks/samsung,grandmax new file mode 120000
> > index 0000000..678f8b1
> > --- /dev/null
> > +++ b/configs/default_hooks/samsung,grandmax
> > @@ -0,0 +1 @@
> > +three_button_touchscreen
> > \ No newline at end of file
> > diff --git a/configs/default_hooks/samsung,j5
> > b/configs/default_hooks/samsung,j5 new file mode 120000
> > index 0000000..678f8b1
> > --- /dev/null
> > +++ b/configs/default_hooks/samsung,j5
> > @@ -0,0 +1 @@
> > +three_button_touchscreen
> > \ No newline at end of file
> > diff --git a/configs/default_hooks/samsung,j5x
> > b/configs/default_hooks/samsung,j5x new file mode 120000
> > index 0000000..678f8b1
> > --- /dev/null
> > +++ b/configs/default_hooks/samsung,j5x
> > @@ -0,0 +1 @@
> > +three_button_touchscreen
> > \ No newline at end of file
> > diff --git a/scripts/deviceprofiles/sxmo_deviceprofile_samsung,e7.sh
> > b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,e7.sh new file mode
> > 120000
> > index 0000000..07e4ae9
> > --- /dev/null
> > +++ b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,e7.sh
> > @@ -0,0 +1 @@
> > +sxmo_deviceprofile_samsung,a5u-eur.sh
> > \ No newline at end of file
> > diff --git a/scripts/deviceprofiles/sxmo_deviceprofile_samsung,grandmax.sh
> > b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,grandmax.sh new file
> > mode 120000
> > index 0000000..07e4ae9
> > --- /dev/null
> > +++ b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,grandmax.sh
> > @@ -0,0 +1 @@
> > +sxmo_deviceprofile_samsung,a5u-eur.sh
> > \ No newline at end of file
> > diff --git a/scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5.sh
> > b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5.sh new file mode
> > 120000
> > index 0000000..07e4ae9
> > --- /dev/null
> > +++ b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5.sh
> > @@ -0,0 +1 @@
> > +sxmo_deviceprofile_samsung,a5u-eur.sh
> > \ No newline at end of file
> > diff --git a/scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5x.sh
> > b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5x.sh new file mode
> > 120000
> > index 0000000..07e4ae9
> > --- /dev/null
> > +++ b/scripts/deviceprofiles/sxmo_deviceprofile_samsung,j5x.sh
> > @@ -0,0 +1 @@
> > +sxmo_deviceprofile_samsung,a5u-eur.sh
> > \ No newline at end of file
> > --
> > 2.30.2
Details
Message ID
<CT4OT8JQ2Q12.236XKW8KK5FJH@yellow-orcess>
In-Reply-To
<20230531124231.45508-1-raymondhackley@protonmail.com> (view parent)
DKIM signature
missing
Download raw message
Thanks!

To git@git.sr.ht:~mil/sxmo-utils
   7ea019e..bb0c557  master -> master
Reply to thread Export thread (mbox)