~mil/sxmo-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH wvkbd] Regression fix: keyboard didn't re-show on SIGUSR2 anymore

Details
Message ID
<20230917094259.3121437-2-proycon@anaproy.nl>
DKIM signature
pass
Download raw message
Patch: +6 -1
The problem was introduced in b1890848d51640d286f3e962b37e5d66a7c2dfad

Ref: https://github.com/jjsullivan5196/wvkbd/issues/41
---
 main.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/main.c b/main.c
index 01452c3..784e58a 100644
--- a/main.c
+++ b/main.c
@@ -701,7 +701,12 @@ show()
                                       NULL);
    wl_surface_commit(draw_surf.surf);

    hidden = false;
    if (hidden) {
        wl_display_roundtrip(display);
        drwsurf_flip(&draw_surf);
        hidden = false;
    }

}

void
-- 
2.42.0
Details
Message ID
<CVLEXJE28E7U.QW76HUVINTKL@yellow-orcess>
In-Reply-To
<20230917094259.3121437-2-proycon@anaproy.nl> (view parent)
DKIM signature
pass
Download raw message
On Sun Sep 17, 2023 at 11:43 AM CEST, Maarten van Gompel wrote:
> The problem was introduced in b1890848d51640d286f3e962b37e5d66a7c2dfad
>
> Ref: https://github.com/jjsullivan5196/wvkbd/issues/41
> ---
>  main.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/main.c b/main.c
> index 01452c3..784e58a 100644
> --- a/main.c
> +++ b/main.c
> @@ -701,7 +701,12 @@ show()
>                                         NULL);
>      wl_surface_commit(draw_surf.surf);
>  
> -    hidden = false;
> +    if (hidden) {
> +        wl_display_roundtrip(display);
> +        drwsurf_flip(&draw_surf);
> +        hidden = false;
> +    }
> +

I investigated the Wayland debug output and found a better way to solve
this. It was very close to works, only the check in layer_surface_configure
was problematic.

>  }
>  
>  void
Details
Message ID
<CVM51AW3GG88.3PNHU3TFKKT4E@pollux>
In-Reply-To
<CVLEXJE28E7U.QW76HUVINTKL@yellow-orcess> (view parent)
DKIM signature
pass
Download raw message
> I investigated the Wayland debug output and found a better way to solve
> this. It was very close to works, only the check in layer_surface_configure
> was problematic.

Great! Marking this one as superseded
Reply to thread Export thread (mbox)