On Sun, Feb 18, 2024 at 11:09:05PM +0530, Patriot-06 wrote:
> Signed-off-by: Patriot-06 <mbmc172@gmail.com>> ---> configs/default_hooks/xiaomi,mido | 1 +> .../deviceprofiles/sxmo_deviceprofile_xiaomi,mido.sh | 10 ++++++++++> 2 files changed, 11 insertions(+)> create mode 120000 configs/default_hooks/xiaomi,mido> create mode 100755 scripts/deviceprofiles/sxmo_deviceprofile_xiaomi,mido.sh> > diff --git a/configs/default_hooks/xiaomi,mido b/configs/default_hooks/xiaomi,mido> new file mode 120000> index 0000000..678f8b1> --- /dev/null> +++ b/configs/default_hooks/xiaomi,mido> @@ -0,0 +1 @@> +three_button_touchscreen
Please remove this link, three_button_touchscreen has become the
default, so this will create a broken symlink on the master branch.
> \ No newline at end of file> diff --git a/scripts/deviceprofiles/sxmo_deviceprofile_xiaomi,mido.sh b/scripts/deviceprofiles/sxmo_deviceprofile_xiaomi,mido.sh> new file mode 100755> index 0000000..4bb839a> --- /dev/null> +++ b/scripts/deviceprofiles/sxmo_deviceprofile_xiaomi,mido.sh> @@ -0,0 +1,10 @@> +#!/bin/sh> +# redmi note 4> +# SPDX-License-Identifier: AGPL-3.0-only> +# Copyright 2022 Sxmo Contributors> +> +export SXMO_DISABLE_LEDS="1"> +export SXMO_MONITOR="DSI-1"> +export SXMO_POWER_BUTTON="0:0:pm8941_pwrkey"> +export SXMO_VOLUME_BUTTON="1:1:gpio-keys 0:0:pm8941_resin"> +export SXMO_SWAY_SCALE="1"
nit: if you have a chance, it'd be great to check if this is different
from what sway detects. I'd like to move the scale logic out of sxmo to
a more generic algorithm. Not adding it would help with that, but that's
not at all necessary for this patch.
> -- > 2.43.2>
When sending multiple versions of a patch it's helpful to include the
revision number in the subject by passing "-v<n>" to git format-pach (or
git semd-email if you use that directly). It helps to tell which version
of a patch is the newest.
LGTM, besides the extra symlink (the rest of this email is just me being
a perfectionist).
Acked-by: Aren Moynihan <aren@peacevolution.org>
Hey, this seems like a patchset that is an earlier version of another
patchset in this mailing list. I am marking this patchset as superseded. Please
ping me in irc (my nick is anjan) if I am mistaken.
Thank you for your contribution.
Best,
Anjandev Momi
--
w:] www.momi.ca
pgp:] https://momi.ca/publickey.txt