[PATCH] removed the disable_led since flashlight/torch works nicely

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch

[PATCH] removed the disable_led since flashlight/torch works nicely

magdesign <hallo@magdesign.ch>

Details

Message ID: <20240422105824.18973-1-hallo@magdesign.ch>
DKIM signature: permerror

Download raw message

7 months ago

Patch: +0 -1

---
 scripts/deviceprofiles/sxmo_deviceprofile_oneplus,enchilada.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/scripts/deviceprofiles/sxmo_deviceprofile_oneplus,enchilada.sh b/scripts/deviceprofiles/sxmo_deviceprofile_oneplus,enchilada.sh
index f41fd5d..8b9c62b 100755
--- a/scripts/deviceprofiles/sxmo_deviceprofile_oneplus,enchilada.sh
+++ b/scripts/deviceprofiles/sxmo_deviceprofile_oneplus,enchilada.sh
@@ -5,7 +5,6 @@
 export SXMO_VOLUME_BUTTON="1:1:Volume_keys"
 export SXMO_POWER_BUTTON="0:0:pm8941_pwrkey"
 export SXMO_MONITOR="DSI-1"
-export SXMO_DISABLE_LEDS="1"
 export SXMO_VIBRATE_DEV="/dev/input/by-path/platform-c440000.spmi-platform-c440000.spmi:pmic@3:haptics@c000-event"
 export SXMO_VIBRATE_STRENGTH="5000"
 export SXMO_SWAY_SCALE="3"
-- 
2.44.0

Aren <aren@peacevolution.org>

Details

Message ID: <t4rwjyy2k2yhxeskem6dxezcoyv4pjn6gt2zmzxnxjjqhok7wh@fazantae5tsm>
In-Reply-To: <20240422105824.18973-1-hallo@magdesign.ch> (view parent)
DKIM signature: pass

Download raw message

7 months ago

Does this device have a working status led? e.g. does
`sxmo_led.sh blink red blue` have some obviously noticeable effect?

Currently SXMO_DISABLE_LEDS being unset means both that there is a
functional status led, and a functional flash led.

p.s please add `--subjectPrefix="PATCH sxmo-utils"` to your git
send-email command, or set it as a config option in the repository
you're sending patches from.

On Mon, Apr 22, 2024 at 12:58:24PM +0200, magdesign wrote:
> ---
>  scripts/deviceprofiles/sxmo_deviceprofile_oneplus,enchilada.sh | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/scripts/deviceprofiles/sxmo_deviceprofile_oneplus,enchilada.sh b/scripts/deviceprofiles/sxmo_deviceprofile_oneplus,enchilada.sh
> index f41fd5d..8b9c62b 100755
> --- a/scripts/deviceprofiles/sxmo_deviceprofile_oneplus,enchilada.sh
> +++ b/scripts/deviceprofiles/sxmo_deviceprofile_oneplus,enchilada.sh
> @@ -5,7 +5,6 @@
>  export SXMO_VOLUME_BUTTON="1:1:Volume_keys"
>  export SXMO_POWER_BUTTON="0:0:pm8941_pwrkey"
>  export SXMO_MONITOR="DSI-1"
> -export SXMO_DISABLE_LEDS="1"
>  export SXMO_VIBRATE_DEV="/dev/input/by-path/platform-c440000.spmi-platform-c440000.spmi:pmic@3:haptics@c000-event"
>  export SXMO_VIBRATE_STRENGTH="5000"
>  export SXMO_SWAY_SCALE="3"
> -- 
> 2.44.0
>

Aren <aren@peacevolution.org>

Details

Message ID: <2mvrqedgrmzc5fgtf6myw4tws6q4gjv77yleao5oh2q45fohjr@zldvrrujoacv>
In-Reply-To: <20240422105824.18973-1-hallo@magdesign.ch> (view parent)
DKIM signature: pass

Download raw message

7 months ago

superseded by https://lists.sr.ht/~mil/sxmo-devel/patches/51346