On Wed Dec 11, 2024 at 6:26 PM PST, hazardchem wrote:
> Signed-off-by: hazardchem <hazardchem@disroot.org>> ---> configs/default_hooks/sxmo_hook_inputhandler.sh | 7 +++++++> 1 file changed, 7 insertions(+)>> diff --git a/configs/default_hooks/sxmo_hook_inputhandler.sh b/configs/default_hooks/sxmo_hook_inputhandler.sh> index a443e1a0..c5c2d184 100755> --- a/configs/default_hooks/sxmo_hook_inputhandler.sh> +++ b/configs/default_hooks/sxmo_hook_inputhandler.sh> @@ -140,6 +140,13 @@ case "$WMCLASS" in> ;;> esac> ;;> + *"firefox"*)> + case "$ACTION" in> + # you're probably dragging the scrollbar> + *"uprightedge") exit 0 ;;> + *"downrightedge") exit 0 ;;> + esac> + ;;> *"foot"*|*"st"*|*"vte"*|"terminal") # Terminals> case "$WMCLASS" in # Handle programs without touch support> *"st"*)
I dont use the scrollbar when Im using firefox...
I usually swipe up and down in the middle of the screen.
Infact, I would prefer disabling the scrollbar on sxmo via the firefox
mobile config on alpine.
I dont think we should have different gestures behaviour on the right
side of the screen when firefox is in focus, that will be confusing for
users - what if I really wanted to lower my volume while using firefox?
> I dont use the scrollbar when Im using firefox...> I usually swipe up and down in the middle of the screen.> > Infact, I would prefer disabling the scrollbar on sxmo via the firefox> mobile config on alpine.
Scrollbar is very useful if you are viewing a large page and want to jump back
to a specific location.
> I dont think we should have different gestures behaviour on the right> side of the screen when firefox is in focus, that will be confusing for> users - what if I really wanted to lower my volume while using firefox?
Right hand side input is up and down arrow keys, which was causing jarring
behaviour when using scrolling or scrollbar from the right hand side.
Volume controls are on the left hand side which are unaffected by this patch.
We already disable this specific gesture for some other programs. Also,
I agree that the Firefox scrollbar is valuable. Those right gesture
by default only trigger some Up or Down keys.
Thanks!
To git@git.sr.ht:~mil/sxmo-utils
b9821b93..b1ed8c8a master -> master