~mil/sxmo-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
4 3

[PATCH sxmo-utils 0/2] desktop mode: minor improvements

Details
Message ID
<20241218191158.20503-4-contact@willowbarraco.fr>
DKIM signature
pass
Download raw message
I've recently received my Starlab Starlite device. It is a tabled with
a detachable keyboard. And obviously I immediately installed my dear
Sxmo typical setup on it. With very minor config I was pleased to
discover it worked very well.

Here a minor patchset to upstream what I did.

[PATCH sxmo-utils 1/2] desktop mode: do not disable features by default

Details
Message ID
<20241218191158.20503-5-contact@willowbarraco.fr>
In-Reply-To
<20241218191158.20503-4-contact@willowbarraco.fr> (view parent)
DKIM signature
pass
Download raw message
Patch: +0 -3
While it is true that on most desktops, thoses features would be
useless. Some of them can still have a modem, a touchscreen, or hardware
buttons.

I think we should let the user disable them if necessary on their
profile script, or disable them more specifically. By example
SXMO_NO_VIRTUAL_KEYBOARD is mostly usefull on keyboard attached mobile
devices.

Signed-off-by: Willow Barraco <contact@willowbarraco.fr>
---
 scripts/deviceprofiles/sxmo_deviceprofile_desktop.sh | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/scripts/deviceprofiles/sxmo_deviceprofile_desktop.sh b/scripts/deviceprofiles/sxmo_deviceprofile_desktop.sh
index 22dee730..765fd94c 100755
--- a/scripts/deviceprofiles/sxmo_deviceprofile_desktop.sh
+++ b/scripts/deviceprofiles/sxmo_deviceprofile_desktop.sh
@@ -1,6 +1,3 @@
export SXMO_STATUS_DATE_FORMAT="%Y-%m-%d %H:%M"
export SXMO_DISABLE_KEYBINDS=1
export SXMO_STATES="unlock locker"
export SXMO_UNLOCK_IDLE_TIME=300
export SXMO_NO_MODEM=1
export SXMO_NO_VIRTUAL_KEYBOARD=1
-- 
2.47.1

[PATCH sxmo-utils 2/2] desktop mode: enlarge the workspace wrapping

Details
Message ID
<20241218191158.20503-6-contact@willowbarraco.fr>
In-Reply-To
<20241218191158.20503-4-contact@willowbarraco.fr> (view parent)
DKIM signature
pass
Download raw message
Patch: +1 -0
For the same reason we setup a larger date format, we wrap the workspace
wrapping to 10.

Signed-off-by: Willow Barraco <contact@willowbarraco.fr>
---
 scripts/deviceprofiles/sxmo_deviceprofile_desktop.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/deviceprofiles/sxmo_deviceprofile_desktop.sh b/scripts/deviceprofiles/sxmo_deviceprofile_desktop.sh
index 765fd94c..b58de65a 100755
--- a/scripts/deviceprofiles/sxmo_deviceprofile_desktop.sh
+++ b/scripts/deviceprofiles/sxmo_deviceprofile_desktop.sh
@@ -1,3 +1,4 @@
export SXMO_STATUS_DATE_FORMAT="%Y-%m-%d %H:%M"
export SXMO_STATES="unlock locker"
export SXMO_UNLOCK_IDLE_TIME=300
export SXMO_WORKSPACE_WRAPPING=10
-- 
2.47.1

[sxmo-utils/patches/test.yml] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<D6F2CWZCUI0J.3NWGDZE92I1ZM@fra01>
In-Reply-To
<20241218191158.20503-6-contact@willowbarraco.fr> (view parent)
DKIM signature
missing
Download raw message
sxmo-utils/patches/test.yml: SUCCESS in 25s

[desktop mode: minor improvements][0] from [Willow Barraco][1]

[0]: https://lists.sr.ht/~mil/sxmo-devel/patches/56519
[1]: contact@willowbarraco.fr

✓ #1392293 SUCCESS sxmo-utils/patches/test.yml https://builds.sr.ht/~mil/job/1392293

Re: [PATCH sxmo-utils 2/2] desktop mode: enlarge the workspace wrapping

Details
Message ID
<clvu4nfagn4uyucstpnpls6rwrxryx6fikphus52hhn6lor32o@lhiu3lyeljw4>
In-Reply-To
<20241218191158.20503-6-contact@willowbarraco.fr> (view parent)
DKIM signature
pass
Download raw message
LGTM, Applied

To git.sr.ht:~mil/sxmo-utils
   f059c9b..ac13f77  master -> master
Reply to thread Export thread (mbox)