sxmo-utils: sxmo_init.sh: use mkrundir if available v1 NEEDS REVISION

Willow Barraco: 1
 sxmo_init.sh: use mkrundir if available

 1 files changed, 5 insertions(+), 0 deletions(-)

I've merged the patch with the reviewed change. Thanks!

[PATCH sxmo-utils] sxmo_init.sh: use mkrundir if available Export this patch

mkrundir is a simple program by whynothugo that simply create the
rundir.

This patch is enough for Sxmo to use /run/user-$uid as XDG_RUNTIME_DIR. Even if
this is still less common that /run/user/$uid, it still is preferable, and more
compatible than our /dev/shm/user/$uid (ex: flatpak refuse to bind mount /dev/
paths).

Signed-off-by: Willow Barraco <contact@willowbarraco.fr>
---
 configs/profile.d/sxmo_init.sh | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/configs/profile.d/sxmo_init.sh b/configs/profile.d/sxmo_init.sh
index 785d235f..83d50ea6 100644
--- a/configs/profile.d/sxmo_init.sh
+++ b/configs/profile.d/sxmo_init.sh
@@ -48,6 +48,11 @@ _sxmo_find_runtime_dir() {
 		fi
 	done
 
+	if type mkrundir > /dev/null 2>&1; then
+		mkrundir

Aren <aren@peacevolution.org>

5 months ago

Does this need to be "XDG_RUNTIME_DIR=$(mkrundir)"?

Willow Barraco <contact@willowbarraco.fr>

5 months ago

Now, this is the _sxmo_find_runtime_dir that just output what should be
used. It is then used by _sxmo_load_environments or _sxmo_grab_session.

Next

Also is there a reason to use type instead of command -v like we do
elsewhere?

Willow Barraco <contact@willowbarraco.fr>

5 months ago

No, I should rather use command -v. Fixed my tree. Thanks!

Next

Besides that, looks good to me.

------------------------------------------------------------------------

Has there been any progress on hare getting 32bit support? It would be
nice if we could have a single fallback for XDG_RUNTIME_DIR if it's not
set, but 32bit support will prevent mkrundir from doing that.

Willow Barraco <contact@willowbarraco.fr>

5 months ago

I agree, but no there is still no progress on this yet..

Thanks Aren!
Willow

 - Aren

+		return
+	fi
+
 	# Fallback to a shared memory location
 	printf "/dev/shm/user/%s" "$(id -u)"
 }
-- 
2.44.0

builds.sr.ht <builds@sr.ht>

5 months ago

sxmo-utils/patches/test.yml: SUCCESS in 32s

[sxmo_init.sh: use mkrundir if available][0] from [Willow Barraco][1]

[0]: https://lists.sr.ht/~mil/sxmo-devel/patches/50441
[1]: mailto:contact@willowbarraco.fr

✓ #1178150 SUCCESS sxmo-utils/patches/test.yml https://builds.sr.ht/~mil/job/1178150