sxmo-utils: sxmo_hook_inputhandler.sh: firefox - removed right hand side actions as it conflicts with the scrollbar. v1 APPLIED

hazardchem: 1
 sxmo_hook_inputhandler.sh: firefox - removed right hand side actions as it conflicts with the scrollbar.

 1 files changed, 7 insertions(+), 0 deletions(-)

[PATCH sxmo-utils] sxmo_hook_inputhandler.sh: firefox - removed right hand side actions as it conflicts with the scrollbar. Export this patch

Signed-off-by: hazardchem <hazardchem@disroot.org>
---
 configs/default_hooks/sxmo_hook_inputhandler.sh | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/configs/default_hooks/sxmo_hook_inputhandler.sh b/configs/default_hooks/sxmo_hook_inputhandler.sh
index a443e1a0..c5c2d184 100755
--- a/configs/default_hooks/sxmo_hook_inputhandler.sh
+++ b/configs/default_hooks/sxmo_hook_inputhandler.sh
@@ -140,6 +140,13 @@ case "$WMCLASS" in
 				;;
 		esac
 		;;
+	*"firefox"*)
+		case "$ACTION" in
+			# you're probably dragging the scrollbar
+			*"uprightedge") exit 0 ;;
+			*"downrightedge") exit 0 ;;
+		esac
+		;;
 	*"foot"*|*"st"*|*"vte"*|"terminal") # Terminals
 		case "$WMCLASS" in # Handle programs without touch support
 			*"st"*)

Anjandev Momi <anjan@momi.ca>

2 months ago

I dont use the scrollbar when Im using firefox...
I usually swipe up and down in the middle of the screen.

Infact, I would prefer disabling the scrollbar on sxmo via the firefox
mobile config on alpine.

hazardchem <hazardchem@disroot.org>

2 months ago

Scrollbar is very useful if you are viewing a large page and want to jump back
to a specific location.

Next

I dont think we should have different gestures behaviour on the right
side of the screen when firefox is in focus, that will be confusing for
users - what if I really wanted to lower my volume while using firefox?

-- 
2.45.2

Willow Barraco <contact@willowbarraco.fr>

2 months ago

We already disable this specific gesture for some other programs. Also,
I agree that the Firefox scrollbar is valuable. Those right gesture
by default only trigger some Up or Down keys.

Thanks!

To git@git.sr.ht:~mil/sxmo-utils
   b9821b93..b1ed8c8a  master -> master

builds.sr.ht <builds@sr.ht>

4 months ago

sxmo-utils/patches/test.yml: SUCCESS in 24s

[sxmo_hook_inputhandler.sh: firefox - removed right hand side actions as it conflicts with the scrollbar.][0] from [hazardchem][1]

[0]: https://lists.sr.ht/~mil/sxmo-devel/patches/56387
[1]: mailto:hazardchem@disroot.org

✓ #1388091 SUCCESS sxmo-utils/patches/test.yml https://builds.sr.ht/~mil/job/1388091