~mjclancy

Recent activity

Re: [WIP] Remove hard coded path everywhere 3 months ago

From Michael Clancy to ~sircmpwn/aerc

On Sat Jun 27, 2020 at 11:41 AM BST, Reto wrote:
> > What is the desired behaviour of aerc when an email has a pgp signed/encrypted
> > body part inside a pgp encrypted body part? (As is the case with the
> > test email).
>
> What do you mean exactly?
> Aerc doesn't support nested emails yet.
> In my opinion we should strip and validate exactly one signature from
> the message.
> If a part is then further encrypted, that should be the task of a filter
> of some sort.

What I mean is that some emails may have a pgp-signature body part
inside a pgp-encrypted message, as is the case for the sr.ht pgp test

Re: [WIP] Remove hard coded path everywhere 3 months ago

From Michael Clancy to ~sircmpwn/aerc

Hi Reto,

I have been looking into why the test pgp email does not appear properly
and it seems it is because go-pgpmail does not look for more pgp
encrypted body parts inside a pgp encrypted message. I am working on a
fix for this, but had a question:

What is the desired behaviour of aerc when an email has a pgp signed/encrypted
body part inside a pgp encrypted body part? (As is the case with the
test email).

If the inner message has been encrypted with a different public key than
the outer message, which key should be displayed in the encryption
status of aerc?

Re: [WIP] Remove hard coded path everywhere 3 months ago

From Michael Clancy to ~sircmpwn/aerc

Hi Reto,

Thanks for sending this over, am beginning to get a much better
understanding of how aerc functions.

> * still fails for some emails, ironically for the gpg test email from
> sr.ht for example

I sent myself the test pgp email but was able to open this fine. Do you
mean that some of the email is not being displayed?

I was also curious as to whether you knew of a tool to send raw email,
with the ability to add new MIME message parts, for testing purposes.

Re: [PATCH aerc] Added nil checks before reading header. 3 months ago

From Michael Clancy to ~sircmpwn/aerc

Hi,

Thanks for getting back to me!

> Hi,
> Thanks for the patch.
> However I think this is the wrong approach.

I agree this is likely the wrong approach. As a first port of call I
decided to copy the fix already implemented elsewhere for this.

> Aerc does something invalid in that it often fallsback to the []int{1}
> path or however the bodypart path is called.
>

[PATCH aerc] Added nil checks before reading header. 3 months ago

From Michael Clancy to ~sircmpwn/aerc

textProto.ReadHeader expects a non-nil section reader passed to it, and
panics otherwise.
---
 worker/imap/fetch.go | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/worker/imap/fetch.go b/worker/imap/fetch.go
index def0da8..6a56cfb 100644
--- a/worker/imap/fetch.go
+++ b/worker/imap/fetch.go
@@ -3,7 +3,6 @@ package imap
import (
	"bufio"
	"fmt"
[message trimmed]

Empty header crash 3 months ago

From Michael Clancy to ~sircmpwn/aerc

Hi Drew,

I have encountered aerc crashing when opening a particular email. On
debugging, it seems that it is caused by _msg.GetBody returning nil then
this result being passed onto something which expects a byte literal, with
no checks for nil involved.

This is at worker/imap/fetch.go:92

The crash can be prevented by checking for nil and returning an error,
which would result in the email being unopenable. 

Alternatively the header body could be replaced with an empty byte literal, which would
allow the email body to be read. A warning could also be displayed.

[PATCH v2] Second attempt at sending git-email 3 months ago

From Michael Clancy to ~sircmpwn/email-test-drive

---
 mclancy | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 mclancy

diff --git a/mclancy b/mclancy
new file mode 100644
index 0000000..66cb3d4
--- /dev/null
+++ b/mclancy
@@ -0,0 +1 @@
I have successfully used git send-email!
-- 
2.27.0
[message trimmed]

[PATCH] Second attempt at sending git-email 3 months ago

From Michael Clancy to ~sircmpwn/email-test-drive

---
 mclancy | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 mclancy

diff --git a/mclancy b/mclancy
new file mode 100644
index 0000000..b4380e4
--- /dev/null
+++ b/mclancy
@@ -0,0 +1 @@
I'm about to try git send-email!
-- 
2.27.0
[message trimmed]

[PATCH] First commit with git-send-email 3 months ago

From Michael Clancy to ~sircmpwn/email-test-drive

---
 mclancy | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 mclancy

diff --git a/mclancy b/mclancy
new file mode 100644
index 0000000..2f8ed1a
--- /dev/null
+++ b/mclancy
@@ -0,0 +1 @@
Trying git-send-email
-- 
2.27.0
[message trimmed]