~mpu/qbe

2 2

freebsd build is broken

Lorenz (xha) <me@xha.li>
Details
Message ID
<20231203065525.hlx3nncrizjixexw@xha.li>
DKIM signature
missing
Download raw message
Patch: +1 -0
hi,

just wanted to let you know that the freebsd build is broken; the
freebsd people decided to change the make variable $(CC) from "cc"
(13.2) to "c99" (14).

i am not sure why they did it but the diff below should fix it since qbe
always depends on $(CC) == "cc" anways i think.

what do you think?

https://builds.sr.ht/~sircmpwn/job/1105888

diff --git a/Makefile b/Makefile
index 3266c76..f5e8a76 100644
--- a/Makefile
+++ b/Makefile
@@ -13,6 +13,7 @@ OBJ      = $(COMMOBJ) $(AMD64OBJ) $(ARM64OBJ) $(RV64OBJ)

SRCALL   = $(OBJ:.o=.c)

CC       = cc
CFLAGS   = -std=c99 -g -Wall -Wextra -Wpedantic

qbe: $(OBJ)
Quentin Rameau <quinq@fifth.space>
Details
Message ID
<20231203135644.786c4564.quinq@fifth.space>
In-Reply-To
<20231203065525.hlx3nncrizjixexw@xha.li> (view parent)
DKIM signature
missing
Download raw message
> hi,

Hi,

> just wanted to let you know that the freebsd build is broken; the
> freebsd people decided to change the make variable $(CC) from "cc"
> (13.2) to "c99" (14).
> 
> i am not sure why they did it

That's actually a correct fix on FreeBSD side, as the Makefile explicitly
requires a portable make implementation,
where CC is defined as c99.

> but the diff below should fix it since qbe
> always depends on $(CC) == "cc" anways i think.
> 
> what do you think?

I don't think that's a correct fix,
instead CFLAGS should be fixed to not pass -std=c99,
as the complier is always a c99 implementation.

> https://builds.sr.ht/~sircmpwn/job/1105888
> 
> diff --git a/Makefile b/Makefile
> index 3266c76..f5e8a76 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -13,6 +13,7 @@ OBJ      = $(COMMOBJ) $(AMD64OBJ) $(ARM64OBJ) $(RV64OBJ)
>  
>  SRCALL   = $(OBJ:.o=.c)
>  
> +CC       = cc
>  CFLAGS   = -std=c99 -g -Wall -Wextra -Wpedantic
>  
>  qbe: $(OBJ)
Lorenz (xha) <me@xha.li>
Details
Message ID
<20231203181636.qdbfbdiohm2cuv5y@xha.li>
In-Reply-To
<20231203135644.786c4564.quinq@fifth.space> (view parent)
DKIM signature
missing
Download raw message
sure, if you think that is the correct way of doing things i can do
this. please put me into cc because i am not subscribed to this list,
thanks :)

i'll send a patch.
Reply to thread Export thread (mbox)