~mpu/qbe

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
4 3

[PATCH] Print total number of tests run to get a better view of how much is broken.

Details
Message ID
<20240123110407.544-3-me@tobhe.de>
DKIM signature
missing
Download raw message
Patch: +3 -1
---
This seems to be quite helpful when working on a new backend.

Before: 14 test(s) failed!
After: 14 test(s) of 51 failed!

 tools/test.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/test.sh b/tools/test.sh
index fa782c3..b57a024 100755
--- a/tools/test.sh
+++ b/tools/test.sh
@@ -196,15 +196,17 @@ fi
case "$1" in
"all")
	fail=0
	count=0
	for t in $dir/../test/[!_]*.ssa
	do
		once $t
		fail=`expr $fail + $?`
		count=`expr $count + 1`
	done
	if test $fail -ge 1
	then
		echo
		echo "$fail test(s) failed!"
		echo "$fail test(s) of $count failed!"
	else
		echo
		echo "All is fine!"
-- 
2.43.0
Details
Message ID
<CYM9P98RWRPG.MRU6ECKFDXF3@d2evs.net>
In-Reply-To
<20240123110407.544-3-me@tobhe.de> (view parent)
DKIM signature
pass
Download raw message
On Tue Jan 23, 2024 at 11:04 AM UTC, Tobias Heider wrote:
> Before: 14 test(s) failed!
> After: 14 test(s) of 51 failed!

minor nit: "14 of 51 test(s) failed!" reads better to my ears
Details
Message ID
<Za/6GwaY+jbVKRFc@tobhe.de>
In-Reply-To
<CYM9P98RWRPG.MRU6ECKFDXF3@d2evs.net> (view parent)
DKIM signature
missing
Download raw message
On Tue, Jan 23, 2024 at 05:38:41PM +0000, Ember Sawady wrote:
> On Tue Jan 23, 2024 at 11:04 AM UTC, Tobias Heider wrote:
> > Before: 14 test(s) failed!
> > After: 14 test(s) of 51 failed!
> 
> minor nit: "14 of 51 test(s) failed!" reads better to my ears

Right, I agree. I'll send an update.
Details
Message ID
<20240123180843.42952-2-me@tobhe.de>
In-Reply-To
<CYM9P98RWRPG.MRU6ECKFDXF3@d2evs.net> (view parent)
DKIM signature
missing
Download raw message
Patch: +3 -1
---
 tools/test.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/test.sh b/tools/test.sh
index fa782c3..8c3802a 100755
--- a/tools/test.sh
+++ b/tools/test.sh
@@ -196,15 +196,17 @@ fi
case "$1" in
"all")
	fail=0
	count=0
	for t in $dir/../test/[!_]*.ssa
	do
		once $t
		fail=`expr $fail + $?`
		count=`expr $count + 1`
	done
	if test $fail -ge 1
	then
		echo
		echo "$fail test(s) failed!"
		echo "$fail of $count test(s) failed!"
	else
		echo
		echo "All is fine!"
-- 
2.43.0
Details
Message ID
<074be20d-d757-4c71-9cfd-4bcd22105916@app.fastmail.com>
In-Reply-To
<20240123180843.42952-2-me@tobhe.de> (view parent)
DKIM signature
pass
Download raw message
Eh, why not? I merged a slightly modified version in master.

Cheers.
Reply to thread Export thread (mbox)