Recent activity

[PATCH] cmd/gogio: don't hang on some e2e test errors 9 days ago

From Daniel Martí to ~eliasnaur/gio-patches

For example, if the test app fails to start on wayland, we'd block
~forever (ten minutes) waiting for it to render its first frame.

We don't have a good solution right now. But at least we can use a
relatively short timeout, to help out the human who rightfully expects
a result within ten seconds.

While at it, remove a sway "get_seats" command, which was a leftover
from my debugging of what input devices are available when running
headless.

Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
---
 cmd/gogio/e2e_test.go     | 18 ++++++++++++++++++
[message trimmed]

[PATCH] cmd: update the chromedp version a month ago

From Daniel Martí to ~eliasnaur/gio-patches

It's a bugfix release, and we want some of the stability fixes in it.
Starting Chrome processes is more reliable now, for example.

See https://github.com/chromedp/chromedp/releases/tag/v0.5.2.

Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
---
 cmd/go.mod |  5 +++--
 cmd/go.sum | 14 ++++++++------
 2 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/cmd/go.mod b/cmd/go.mod
index 6d163f8..eec80c2 100644
--- a/cmd/go.mod
[message trimmed]

[PATCH] cmd/gogio: remove an unnecessary wait in the js e2e test a month ago

From Daniel Martí to ~eliasnaur/gio-patches

We already wait for the app to render itself via the "frame ready"
stdout prints. Waiting for the canvas to be ready isn't really necessary
anymore. It helped us while we had to rely on sleeps, but that's no
longer the case.

Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
---
 cmd/gogio/js_test.go | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/cmd/gogio/js_test.go b/cmd/gogio/js_test.go
index f01fd6f..0929aa0 100644
--- a/cmd/gogio/js_test.go
+++ b/cmd/gogio/js_test.go
[message trimmed]

[PATCH] cmd: remove js runtime workaround a month ago

From Daniel Martí to ~eliasnaur/gio-patches

The js/wasm bug meant that printing to stdout in the e2e app would crash
the runtime, so we couldn't synchronize with the app like in the other
drivers.

Now that the bug is fixed, we can do the same as the other drivers just
fine.

Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
---
 cmd/gogio/js_test.go      | 22 +++++++++++++++++-----
 cmd/gogio/testdata/red.go |  8 --------
 2 files changed, 17 insertions(+), 13 deletions(-)

diff --git a/cmd/gogio/js_test.go b/cmd/gogio/js_test.go
[message trimmed]

[PATCH] app: use the new pathfinder repo url 2 months ago

From Daniel Martí to ~eliasnaur/gio-patches

While at it, make a freedesktop.org url https, since their site supports
it.

Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
---
 app/internal/gpu/path.go                | 2 +-
 app/internal/window/wayland_xdg_shell.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/internal/gpu/path.go b/app/internal/gpu/path.go
index 97b7379..afe8140 100644
--- a/app/internal/gpu/path.go
+++ b/app/internal/gpu/path.go
@@ -3,7 +3,7 @@
[message trimmed]

[PATCH] cmd/gogio: start using testing.T.Cleanup 2 months ago

From Daniel Martí to ~eliasnaur/gio-patches

Now that we use tip due to breaking changes in Go's JS APIs, let's
replace our hacky cleanup list code with 1.14's upcoming
testing.T.Cleanup.

Adding more deliberate uses of tip would ususally be best avoided, but
these will only affect developers working on gio's tests, not regular
users of gio.

While at it, remove some debug t.Logf calls I forgot to remove.

Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
---
 cmd/gogio/e2e_test.go     | 11 ++---------
 cmd/gogio/js_test.go      | 12 +++++-------
[message trimmed]

[PATCH] cmd/gogio: join all endtoend tests as subtests 2 months ago

From Daniel Martí to ~eliasnaur/gio-patches

This means we can deduplicate some of the logic, and keep it all in one
place.

Start expanding the logic too; the tests are slow, so they should be
skipped on 'go test -short'. The ones we have so far all run in a matter
of seconds on an average laptop today, but future tests will probably
require heavier work like wine or kvm.

Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
---
 cmd/gogio/e2e_test.go     | 26 ++++++++++++++++++++++++++
 cmd/gogio/js_test.go      |  6 ------
 cmd/gogio/wayland_test.go |  6 ------
 cmd/gogio/x11_test.go     |  6 ------
[message trimmed]

[PATCH v2] cmd/gogio: simplify the test -race setup 2 months ago

From Daniel Martí to ~eliasnaur/gio

In an earlier commit, we made it possible to run the e2e tests with the
race detector enabled everywhere via GOFLAGS=-race go test.

However, that's not at all standard; most users will simply use 'go test
-race'. Moreover, having 'go test -race' run the test program with the
race detector, but not the e2e gio app, is a bit useless.

Instead, have the tests detect when they run with the race detector, and
enable the race detector in the test app too. As before, the JS test is
skipped whenever -race is used.

This also means we can test with -race in the same way in each of the
modules, which simplifies CI.
[message trimmed]

[PATCH] cmd/gogio: fix a couple of staticcheck positives 2 months ago

From Daniel Martí to ~eliasnaur/gio

Spotted the javac one by chance when reading the code, so I ran the tool
and fixed another small bug while at it.

Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
---
 cmd/gogio/androidbuild.go | 3 +++
 cmd/gogio/main.go         | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/cmd/gogio/androidbuild.go b/cmd/gogio/androidbuild.go
index 435e263..b651728 100644
--- a/cmd/gogio/androidbuild.go
+++ b/cmd/gogio/androidbuild.go
@@ -151,6 +151,9 @@ func compileAndroid(tmpDir string, tools *androidTools, bi *buildInfo) (err erro
[message trimmed]

[PATCH] cmd/gogio: simplify the test -race setup 2 months ago

From Daniel Martí to ~eliasnaur/gio

In an earlier commit, we made it possible to run the e2e tests with the
race detector enabled everywhere via GOFLAGS=-race go test.

However, that's not at all standard; most users will simply use 'go test
-race'. Moreover, having 'go test -race' run the test program with the
race detector, but not the e2e gio app, is a bit useless.

Instead, have the tests detect when they run with the race detector, and
enable the race detector in the test app too. As before, the JS test is
skipped whenever -race is used.

This also means we can test with -race in the same way in each of the
modules, which simplifies CI.
[message trimmed]