~natrys

Recent activity

Re: [Bug?] Unable to override *some* named colours, when combining with a preset 1 year, 8 months ago

From Imran Khan to ~protesilaos/modus-themes

Protesilaos Stavrou <info@protesilaos.com> writes:

>> From: Imran Khan <contact@imrankhan.live>
>> Date: Wed,  4 Jan 2023 15:26:59 +0600
>
>> [... 17 lines elided]
>
>>>> (also apologies if you are aware of this, or if I am missing something in
>>>> the documentation)
>>>
>>> The documentation can probably be improved though I think here we need
>>> something on the coding front that "just works".
>>
>> Beyond a guard, I wonder if the assumption that user didn't mean to

Re: [Bug?] Unable to override *some* named colours, when combining with a preset 1 year, 8 months ago

From Imran Khan to ~protesilaos/modus-themes

Protesilaos Stavrou <info@protesilaos.com> writes:

>> I feel like this is an issue in reconciliation with the preset, though I
>> can't tell how `bg-hl-line` is any different to `bg-magenta-intense`.
>> The `modus-themes-list-colors` command lists `bg-hl-line` too so it is a
>> named colour right?  It shouldn't be susceptible to recursion
>> limitation.
>
> The reason is that the preset remaps 'bg-hl-line' to 'bg-cyan-subtle',
> thus undoing the original named colour and introducing recursion.
>
> Maybe there is a smart way to guard against this but I need to think
> more about it.  Any ideas are most welcome!

[Bug?] Unable to override *some* named colours, when combining with a preset 1 year, 8 months ago

From Imran Khan to ~protesilaos/modus-themes

Hello Prot,

In the manual one of the example looks like,

```
(setq modus-themes-common-palette-overrides
      `((bg-paren-match bg-magenta-intense)
        ,@modus-themes-preset-overrides-intense))
```

And this works. But if I change `bg-magenta-intense` to say `bg-hl-line`
then load-theme call fails with an error.  But that's surprising because
if I am not splicing the preset override there,