~ne02ptzero

~ne02ptzero/libfloat

Last active 2 months ago
View more

Recent activity

Re: [PATCH v5] raft: add soft snapshot feature 11 months ago

From Louis Solofrizzo to ~ne02ptzero/libfloat

LGTM

-- 
Louis Solofrizzo

> QOTD:
>  "Say, you look pretty athletic. What say we put a pair of tennis
>  shoes on you and run you into the wall?"

Re: [PATCH v2] raft: add soft snapshot feature 11 months ago

From Louis Solofrizzo to ~ne02ptzero/libfloat

> +
> +        if (ctx->conf.soft_compact_every_n_log != 0)
> +        {
> +            /* If soft compact is enabled, let's check if the timing is right */
> +            if (ctx->last_log_time + ctx->conf.soft_compact_time < ctx->time(NULL) && ctx->persistent.commit_index - ctx->persistent.snapshot.index >= ctx->conf.soft_compact_every_n_log)
> +            {
> +                ctx->append_snapshot_log(ctx, ctx->persistent.commit_index, ctx->persistent.term);
> +            }
> +        }

Please split the main condition in two different conditions for reading
simplicity:

> +            if (ctx->last_log_time + ctx->conf.soft_compact_time < ctx->time(NULL))

Re: [PATCH v3] Ensure libfloat is resistant to clock drifting 11 months ago

From Louis Solofrizzo to ~ne02ptzero/libfloat

LGTM

-- 
Louis Solofrizzo
Team Storage

> Shick's Law:
>  There is no problem a good miracle can't solve.

Re: [PATCH v2] Ensure libfloat is resistant to clock drifting 11 months ago

From Louis Solofrizzo to ~ne02ptzero/libfloat

On Tue, Jul 11, 2023 at 03:17:37PM +0200, Julien Egloff wrote:
> @@ -393,7 +395,7 @@ void libfloat_del_node(libfloat_ctx_t *ctx, libfloat_node_id_t id);
>   * \param[in] ctx Libfloat context
>   * \param[in] time Time elapsed between this call and the previous, in milliseconds
>   */
> -void libfloat_periodic(libfloat_ctx_t *ctx, uint32_t time);
> +void libfloat_periodic(libfloat_ctx_t *ctx, libfloat_millisecond_t time);
API Breaking changes, please keep the uint32_t.

>  
>  /*!
>   * \brief Append a log to the cluster
> @@ -673,4 +675,11 @@ void libfloat_update_leader_check(libfloat_ctx_t *ctx, libfloat_node_id_t id, bo
>   */

Re: [PATCH] periodic: force election from followers in case of a total leader loss 1 year, 6 months ago

From Louis Solofrizzo to ~ne02ptzero/libfloat

On Wed, Dec 14, 2022 at 04:45:58PM +0100, Patrik Cyvoct wrote:
> Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
> ---
>  periodic.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/periodic.c b/periodic.c
> index 40004b4..a64fe67 100644
> --- a/periodic.c
> +++ b/periodic.c
> @@ -30,7 +30,7 @@ void libfloat_periodic(libfloat_ctx_t *ctx, uint32_t time)
>                      * Hmmm, we might be partitionned, or at the very least we don't have a quorum anymore.
>                      * Time to step down!
>                      */

Re: [PATCH] Reset status node when node become leader 2 years ago

From Louis Solofrizzo to ~ne02ptzero/libfloat

LGTM

-- 
Louis Solofrizzo
Team Storage

> There is no sin but ignorance.
>  -- Christopher Marlowe

Re: [PATCH] Investiguate replication stuck 2 years ago

From Louis Solofrizzo to ~ne02ptzero/libfloat

LGTM

-- 
Louis Solofrizzo
Team Storage

> People are going to scream bloody murder about that.
>  -- Seen on linux-kernel

Re: [PATCH] Check qorum is ok in periodic check 2 years ago

From Louis Solofrizzo to ~ne02ptzero/libfloat

On Mon, Dec 20, 2021 at 05:05:46PM +0000, Michael Bonfils wrote:
> +                        nodes_reachables ++;
> +                    }
> +                    else if (node->last_update + ctx->conf.sanity_timeout > ctx->time(NULL))
> +                    {
> +                        nodes_reachables ++;

node_reachables++;

LGTM
-- 
Louis Solofrizzo
Team Storage

Re: [PATCH] Snapshot: remove internal state 2 years ago

From Louis Solofrizzo to ~ne02ptzero/libfloat

LGTM

-- 
Louis Solofrizzo

> <woot> Put *that* in you .sig and smoke it, Knghtbrd.
> <Culus> You know he will read this :>
> <woot> heheheheh.

Re: [PATCH] Don't try to retrieve term if log is 0 2 years ago

From Louis Solofrizzo to ~ne02ptzero/libfloat

LG

-- 
Louis Solofrizzo
Team Storage

> It's interesting to think that many quite distinguished people have
> bodies similar to yours.