~ne02ptzero/libfloat

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH] node: do not delete my own node from a cluster

Louis Solofrizzo <lsolofrizzo@scaleway.com>
Details
Message ID
<20240823135134.721214-1-lsolofrizzo@scaleway.com>
DKIM signature
pass
Download raw message
6 months ago
Patch: +8 -1 
Because it will break the ctx->me pointer in the context, and will crash
horribly.

Signed-off-by: Louis Solofrizzo <lsolofrizzo@scaleway.com>
---
 log.c  | 2 +-
 node.c | 7 +++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/log.c b/log.c
index 9f43c18..544c344 100644
--- a/log.c
+++ b/log.c
@@ -181,7 +181,7 @@ bool libfloat_add_log(libfloat_ctx_t *ctx, libfloat_commit_type_t commit_type, l
        /* User asked for snapshots, let's check it */
        if (ctx->persistent.commit_index - ctx->persistent.snapshot.index >= ctx->conf.compact_every_n_log)
        {
            ctx->soft_compact_last_log = ctx->persistent.commit_index + 1;                                                  
            ctx->soft_compact_last_log = ctx->persistent.commit_index + 1;
            ctx->append_snapshot_log(ctx, ctx->persistent.commit_index, ctx->persistent.term);
        }
    }
diff --git a/node.c b/node.c
index c01e92f..4900f1c 100644
--- a/node.c
+++ b/node.c
@@ -48,6 +48,13 @@ void libfloat_del_node(libfloat_ctx_t *ctx, libfloat_node_id_t id)
    {
        node = kh_val(ctx->nodes, iterator);

        if (ctx->me == node)
        {
            /* Don't delete myself from the cluster, it will break things */
            ERROR(ctx, "libfloat_del_node: Try to delete myself from the cluster, please fix your implementation");
            return;
        }

        ctx->n_nodes--;
        kh_del(libfloat_node_id_t, ctx->nodes, iterator);
        ctx->free(node);
-- 
2.46.0
Patrik Cyvoct <patrik@ptrk.io>
Details
Message ID
<uIjSfX1xGzAGhZsaexk3EHCqQAsZETMlH_oeh2s4G8B03qnnMcWg8oBNkPEK2to4UusEm1LMc5yn6PmcmWyg6EUjPfabw5rrzzmnLNnxstU=@ptrk.io>
In-Reply-To
<20240823135134.721214-1-lsolofrizzo@scaleway.com> (view parent)
DKIM signature
pass
Download raw message
6 months ago 
LG

-------- Original Message --------
On 23/08/2024 15:51, Louis Solofrizzo <lsolofrizzo@scaleway.com> wrote:

>  Because it will break the ctx->me pointer in the context, and will crash
>  horribly.
>  
>  Signed-off-by: Louis Solofrizzo <lsolofrizzo@scaleway.com>
>  ---
>   log.c  | 2 +-
>   node.c | 7 +++++++
>   2 files changed, 8 insertions(+), 1 deletion(-)
>  
>  diff --git a/log.c b/log.c
>  index 9f43c18..544c344 100644
>  --- a/log.c
>  +++ b/log.c
>  @@ -181,7 +181,7 @@ bool libfloat_add_log(libfloat_ctx_t *ctx, libfloat_commit_type_t commit_type, l
>           /* User asked for snapshots, let's check it */
>           if (ctx->persistent.commit_index - ctx->persistent.snapshot.index >= ctx->conf.compact_every_n_log)
>           {
>  -            ctx->soft_compact_last_log = ctx->persistent.commit_index + 1;
>  +            ctx->soft_compact_last_log = ctx->persistent.commit_index + 1;
>               ctx->append_snapshot_log(ctx, ctx->persistent.commit_index, ctx->persistent.term);
>           }
>       }
>  diff --git a/node.c b/node.c
>  index c01e92f..4900f1c 100644
>  --- a/node.c
>  +++ b/node.c
>  @@ -48,6 +48,13 @@ void libfloat_del_node(libfloat_ctx_t *ctx, libfloat_node_id_t id)
>       {
>           node = kh_val(ctx->nodes, iterator);
>  
>  +        if (ctx->me == node)
>  +        {
>  +            /* Don't delete myself from the cluster, it will break things */
>  +            ERROR(ctx, "libfloat_del_node: Try to delete myself from the cluster, please fix your implementation");
>  +            return;
>  +        }
>  +
>           ctx->n_nodes--;
>           kh_del(libfloat_node_id_t, ctx->nodes, iterator);
>           ctx->free(node);
>  --
>  2.46.0
>  
>
Reply to thread Export thread (mbox)