US/Eastern
From Nicole Tietz-Sokolskaya to ~ntietz/yet-another-rust-resource-discuss
Thanks Marc! I'll get this fixed soon. Can I credit you on the credits page acknowledgements? If so let me know what name you'd like (full or abbreviated) and I'll get that added when I submit the fix. (Or, feel free to submit a patch containing both the typo fix and adding yourself to acknowledgments, if you want!) -Nicole
From Nicole Tietz-Sokolskaya to ~ntietz/isabella-db-discuss
Applied both patches (and squashed them into one) and pushed into main. Thank you for the contribution! https://git.sr.ht/~ntietz/isabella-db/commit/4b23f45 On 9/25/23 11:18 PM, Sam Calvert wrote: > --- > pgn/src/lib.rs | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/pgn/src/lib.rs b/pgn/src/lib.rs > index 97f76ed..92bc831 100644 > --- a/pgn/src/lib.rs
From Nicholas Tietz-Sokolsky to ~ntietz/isabella-db-devel
Applied, thank you!
From Nicholas Tietz-Sokolsky to ~ntietz/isabella-db-devel
--- Cargo.lock | 30 ++++++++++++++++++++++++++++++ pgn/Cargo.toml | 2 ++ pgn/src/parse/file.rs | 2 +- pgn/src/parse/mod.rs | 7 ++++--- pgn/src/parse/moves.rs | 4 ++-- pgn/src/parse/san.rs | 2 +- pgn/src/parse/tag.rs | 9 ++------- 7 files changed, 42 insertions(+), 14 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 86e7764..fa492bc 100644 --- a/Cargo.lock +++ b/Cargo.lock [message trimmed]
From Nicholas Tietz-Sokolsky to ~cbondurant/lipuma-devel
This looks pretty good to me. I like the pattern of dispatching to the tool object, which will then know how to handle the events. I wonder if all of the events are necessary—are things like mousewheel in there for future expansion? I left one suggestion that I think could make it simpler, but this way is good (and of course, your project not mine!). > --- > I hope these are properly formatted! Test patch email Seemed to work! > +#[derive(Data, Clone, PartialEq, Eq)] > +enum ToolState { > + Drawing,
From Nicholas Tietz-Sokolsky to ~ntietz/isabella-db-devel
This design doc covers the basic design I'm trying to implement with Isabella and is an intended plan for the initial work. I have a short "roadmap" of things to do so that it's broken into smaller pieces. --- docs/0001-initial-design-and-plan.md | 191 +++++++++++++++++++++++++++ 1 file changed, 191 insertions(+) create mode 100644 docs/0001-initial-design-and-plan.md diff --git a/docs/0001-initial-design-and-plan.md b/docs/0001-initial-design-and-plan.md new file mode 100644 index 0000000..f5aca7e --- /dev/null +++ b/docs/0001-initial-design-and-plan.md @@ -0,0 +1,191 @@ [message trimmed]
From Nicholas Tietz-Sokolsky to ~ntietz/isabella-db-devel
I got some informal feedback from a friend on this and intend to merge it today. > +```python > +# get the games that match the first filter > +games = db.retrieve(filters[0]) > + > +for filter in filters: > + games = games.filter(filter) > +``` > + The first filter is done twice. This should say `for filter in filters[1:`.
From Nicholas Tietz-Sokolsky to ~ntietz/isabella-db-devel
This design doc covers the basic design I'm trying to implement with Isabella and is an intended plan for the initial work. I have a short "roadmap" of things to do so that it's broken into smaller pieces. --- docs/0001-initial-design-and-plan.md | 191 +++++++++++++++++++++++++++ 1 file changed, 191 insertions(+) create mode 100644 docs/0001-initial-design-and-plan.md diff --git a/docs/0001-initial-design-and-plan.md b/docs/0001-initial-design-and-plan.md new file mode 100644 index 0000000..d0038c5 --- /dev/null +++ b/docs/0001-initial-design-and-plan.md @@ -0,0 +1,191 @@ [message trimmed]