On Mon Jan 15, 2024 at 6:12 PM UTC, ~papiris wrote:
> This patchset addresses some caveats that were present in my first btrfs
> patchset; and makes it possible to switch between snapshots taken of
> "/".

(Hm, I just typed out a whole mail and sent it... but apparently it is
gone :\ )

Hi Jacob,

thanks a lot for these improvements, highly appreciated!

I have some review comments, so I didn't apply it directly:
* /tmp has been moved to tmpfs recently, but not for all devices. It

Hi Jacob,

here are a few review comments, so I didn't directly apply it yet. Note that
pmbootstrap.git has been moved as explained here:
https://postmarketos.org/blog/2024/01/17/moving-pmbootstrap/

If you could post the next version to gitlab.com it would make it
easier, however if you strongly prefer using git send e-mail then we can
also finish this series up over e-mail.

Some general comments:
* The commit message titles are too long, should be 50 characters max
  (see also: https://cbea.ms/git-commit/)
* It looks like the first three patches of this serious should be

On Sat, 13 Jan 2024 20:33:56 +0800, xtex wrote:
> From: xtex <xtexchooser@duck.com>
> 
> 

Applied, thanks!

[1/3] helpers/envkernel.fish: export pmbootstrap_dir
      commit: 81fff2c6d6ad3d566641ad4942578365b6cdf234
[2/3] helpers/envkernel.fish: set prompt prefix in fish-shell
      commit: fc3d8b06b338a41605ab6e340e923158f5d2e9d2
[3/3] helpers/envkernel.fish: add deactivate & reactivate function for fish
      commit: 59898f515ac5e70e194b7b3ba392f90df4d26c64

On Mon, 15 Jan 2024 19:27:57 +0100, ~andrisas wrote:
> 


Applied, thanks!

[1/1] flasher: heimdall-bootimg: add support for '--no-reboot' and '--resume'
      commit: e0e3e213ba24720afa431b13f0f878c6fd9dd108

Best regards,
-- 
Oliver Smith <ollieparanoid@postmarketos.org>

On Mon Jan 15, 2024 at 6:27 PM UTC, ~andrisas wrote:
> From: Andras Sebok <sebokandris2009@gmail.com>

Thanks for the update, let's merge it!

Reviewed-by: Oliver Smith <ollieparanoid@postmarketos.org>

>
> ---
>  pmb/config/__init__.py   | 11 +++++++----
>  pmb/flasher/run.py       | 10 ++++++++++
>  pmb/flasher/variables.py | 12 +++++++++++-
>  pmb/parse/arguments.py   | 13 +++++++++++++
>  4 files changed, 41 insertions(+), 5 deletions(-)

On Sat Jan 13, 2024 at 12:33 PM UTC, xtex wrote:
> From: xtex <xtexchooser@duck.com>
>

All patches form this series look good to me, thanks!

Reviewed-by: Oliver Smith <ollieparanoid@postmarketos.org>

> Signed-off-by: xtex <xtexchooser@duck.com>
> ---
>  helpers/envkernel.fish | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/helpers/envkernel.fish b/helpers/envkernel.fish

On Sat, 23 Dec 2023 01:57:07 +0100, ~papiris wrote:
> 


Applied, thanks!

[1/1] install: initial implementation of flat btrfs layout
      commit: 392e82db07aecdbe69e8f1a5cfefe7e7db9293cb

Best regards,
-- 
Oliver Smith <ollieparanoid@postmarketos.org>

On Fri, 8 Dec 2023 23:27:08 +0100, Oliver Smith wrote:
> Make sure the user has at least 256 MiB set as their installation size,
> refuse to start the installation otherwise. The default was changed in
> 2021, 03e9fb05 ("pmb.config.init.boot_size: set to 256 MiB (MR 2037)").
> 
> If the user ran "pmbootstrap init" before that commit, the pmbootstrap
> config will have the old default set. It is very annoying when you do an
> installation with it and only realize it when you run into errors, e.g.
> while upgrading. I had that when testing the upgrade to the v23.12
> release and also adjusted postmarketos-release-upgrade to warn if the
> boot partition is smaller than expected.
> 
> [...]

On Mon, 8 Jan 2024 23:27:36 +0100, Luca Weiss wrote:
> Add support for passing through the correct argument for Python
> (gpep517) and Rust to newapkbuild.
> 
> 

Applied, thanks!

[1/1] pmb.config: add new newapkbuild arguments
      commit: abad57e232005894b02d6417fc0c21aab51068c7

Best regards,
-- 
Oliver Smith <ollieparanoid@postmarketos.org>

On Thu, 14 Dec 2023 15:40:51 -0800, Clayton Craft wrote:
> I zap chroots a lot, since I've found that it often "fixes" a lot of
> weird issues that come about if you have stale chroots laying around.
> So a common pattern I do is "pmb zap && pmb install ...". Having an
> option to pmb install let's me simplify this.
> 
> 

Applied, thanks!

[1/1] pmb.install: add --zap option
      commit: 1020ea1a8b0c30bec57d038f19a08ad21455e6c2

Best regards,