From orwell96 to ~gpcf/advtrains-devel
Hi Athozus,
I know it has been some time. Maybe I should check mails on this address more often, but I have recently reinstalled my laptop and had so far not setup the email client.
Regarding the door patches, I need to check them in more detail. But I would like to finish my work on the route programming (route_prog_rework) before I do such things.
I hope you are not too upset because of this. Thanks for understanding.
Regards,
orwell
Am Fri, 29 Dec 2023 12:29:00 +0100
schrieb "Y. Wang" <yw05@forksworld.de>:
> On 22/10/2023 00:27, Athozus wrote:
From orwell96 to ~gpcf/advtrains-devel
Hi 1F616EMO, I have merged your patches. On this occasion I also created a new release. Thanks for your contributions. Regards, orwell Am Sun, 30 Jun 2024 06:20:42 +0800 schrieb 1F616EMO <yiufamily.hh@gmail.com>: > From: 1F616EMO <root@1f616emo.xyz> > > This patch fixes the following problem: > > * TCB marker is not removed on TCB removal
From orwell96 to ~gpcf/advtrains-devel
Hi SwissalpS,
Sorry for getting back to you only now. I figured I should finally check on some of the patches.
I have two different patches from you in the inbox regarding the is_ground_content fixes. The other one "is ground content revision" I am unable to apply (git-am reports error).
Can I ask you to send again the correct version of the patch? Then I'll integrate it ASAP. Thank you very much.
Regards, orwell
Am Tue, 12 Mar 2024 13:43:50 +0100
schrieb Luke aka SwissalpS <Luke@SwissalpS.ws>:
> see https://github.com/pandorabox-io/pandorabox.io/issues/836
From orwell (claws) to ~gpcf/advtrains-devel
Hi Maverick, Thanks for reporting this, I oversaw one call in path_invalidate_ahead. Should be fixed now, please try again whether the unloading rails now work correctly in track loops. Regards, orwell
From orwell (claws) to ~gpcf/advtrains-devel
Hi Maverick, I have pushed a commit to master fixing the issue with the track loops. Can you rebase your patch onto this and test it? Once it works I would like to merge it and maybe even publish a release (there hasn't been one for some time). Thank you! Regards, orwell
From orwell (claws) to ~gpcf/advtrains-devel
Hi, - (?)TODO ramp doesn't activate if track is a closed loop. Oh no. This issue is slowly becoming a nightmare. It breaks the coupling system, it breaks path projection, it breaks the loading rails... There needs to be done a change in the occupation system, so that it can handle the same train having this position at multiple path items (or at least make the lowest index take precedence) I need to think about that separately.
From orwell (claws) to ~gpcf/advtrains-devel
Hi again, Just noticed you added a patch here an hour ago... Which means we were working in parallel. My remark still holds though, and I believe my implementation is correct. Regards, orwell
From orwell (claws) to ~gpcf/advtrains-devel
Hi, yes, generally this is the right way to do. However you need to be careful because the index does not necessarily match the real position (an index of 1 can be a distance greater than 1) Since I have some time today, I added such a function in 283efc4. You should be able to use it right away. Regards, orwell
From orwell (claws) to ~gpcf/advtrains-devel
Hi, sorry for the late reply. I hope you are still interested in bringing the livery system forward. This rework of the livery system is quite a large change, and I think it would make sense to put this in a dedicated branch rather than squeeze it into patches. I remember we were establishing a livery team once. Who was the leader of this, and can we pick up this topic again (maybe in one more meeting e.g. on IRC)? Would you volunteer to take the lead in the livery area? Regards,
From orwell (claws) to ~gpcf/advtrains-devel
Hi, what's the state of this? Is this ready to be merged or is there still work required? Regards, orwell