~ov

Recent activity

Re: [PATCH aerc v1] fix: send real COLUMNS value to filters 6 days ago

From Vitaly Ovchinnikov to ~rjarry/aerc-devel

> Previously filters received a COLUMNS value of 80 no matter the width
> of the terminal.

I don't see any difference to the built-in image preview. It is of about
the same width with and without the patch. Even if I put a specific
number instead of the terminal width, like 200 - the picture don't
change.

-- Vitaly

Re: Tmux and emoji corruption ☀️ ♂️ ☀️l 8 days ago

From Vitaly Ovchinnikov to ~rjarry/aerc-devel

Hi Tim,

> Could you try recreating this in all of those terminals but with
> `VAXIS_FORCE_UNICODE=1` set? I was able to reproduce in all terminals I have
> installed + tmux, and when setting this it goes away.

I can confirm this fixes the glitch for me (tmux + alacritty at mac).

I used to have a similar problem with other emojis in email subjects,
but it never was that stable to report. Hope it was the same stuff.

Meanwhile, is is OK to use that environment variable as a daily driver?
Any possible issues with it? Extra logging? Slowdowns? Anything?

Re: [PATCH aerc v2] rfc822: make header parsing less pedantic 17 days ago

From Vitaly Ovchinnikov to ~rjarry/aerc-devel

> When receiving invalid headers, just log the errors and move on with our
> life. When failing to decode addresses, do whatever is possible to at
> least make the message readable.

Looks good, this fixes the "no email" From field I had a problem with
and also improves Subject parsing in one of the bad spam emails I was
going to report next :)

I would suggest to put that text into `Name` field instead of `Email`
though. Currently I get `From: <someone>`, while it is probably better
to have it like `From: someone <>`.

Tested-by: Vitaly Ovchinnikov <v@ovch.ru>

Re: [PATCH aerc] rfc822: make header parsing less pedantic 17 days ago

From Vitaly Ovchinnikov to ~rjarry/aerc-devel

> When receiving invalid Date, Bcc, In-Reply-To headers, just log the
> errors and move on with our life.

What about essential headers? Right now I get messages missed in aerc if
`From` is wrong. Shouldn't we display them anyways?

I posted a minimal sample a few days ago:
https://lists.sr.ht/~rjarry/aerc-devel/patches/53640

-- Vitaly

Re: [PATCH aerc] rfc822: be liberal with invalid address headers 22 days ago

From Vitaly Ovchinnikov to ~rjarry/aerc-devel

> Missing messages is generally no good.
> Could you share those emails? It'd be easier to reproduce...

The minimal example of "invisible" message is:

==============================
From: Someone
To: root@localhost
Subject: Hello
Date: Sat, 29 Jun 2024 17:38:01 +0000

That's a message here...
==============================

Re: [PATCH aerc] rfc822: be liberal with invalid address headers 22 days ago

From Vitaly Ovchinnikov to ~rjarry/aerc-devel

> Yep, I can confirm it works fine when build from the latest master.

OK, after testing the new version, I think I found a regression from the
17th of June.

I have a maildir of manually-created emails with the From field looking
this way:

	From: hello

So, no email there, at all, just a name. The real `From` is slightly
more complex, as it is base-64 encoded, but the idea is the same.

I agree that this might violate the standard, but the problem is that

Re: [PATCH aerc] rfc822: be liberal with invalid address headers 22 days ago

From Vitaly Ovchinnikov to ~rjarry/aerc-devel

> Are you on last master?

I used a very old version from the 17th of June :)

> Afaik, this should be fixed after https://git.sr.ht/~rjarry/aerc/log?from=0efcf2b3b08de22bcd5994a671c2b276db3488eb#log-0efcf2b3b08de22bcd5994a671c2b276db3488eb

Yep, I can confirm it works fine when build from the latest master.

Ahead-of-time fix for me!

-- Vitaly

Re: [PATCH aerc] rfc822: be liberal with invalid address headers 22 days ago

From Vitaly Ovchinnikov to ~rjarry/aerc-devel

> Some email clients format email addresses with quotes around B encoded

Hold my beer... Here's what I get from one quite a big financial system
(I changed the address for privacy reasons):

	From: =?utf-8?B?aGVsbG9Ad29ybGQuY29t?= <hello@world.com>

After decoding the name part it turns into:

	hello@world.com <hello@world.com>

When opening such an email in aerc, I get this in From field:

	"hello@world.com <hello@world.com>" <>

Re: [PATCH aerc] vaxis: update to 0.9.0 a month ago

From Vitaly Ovchinnikov to ~rjarry/aerc-devel

> Ah I found the issue.

Perfect! Thank you.

> This would be a breaking change in Vaxis but one that I think it worth
> making.

Well, I believe we should be able to paste long text anyways. Looking
forward to testing the new version.

-- Vitaly

Re: [PATCH aerc] vaxis: update to 0.9.0 a month ago

From Vitaly Ovchinnikov to ~rjarry/aerc-devel

> Ah yes I remember now. I wasn't able to figure out the issue from the
> alacritty.recording, and i can't reproduce locally. Do you have a
> linux VM you could test in? I wonder if this is somehow a mac-only
> issue?

I've just reproduced it on FreeBSD directly in both Alacritty and xterm
and on Linux via SSH from Mac. So it doesn't look Mac-specific to me.

Note that this is still Vaxis 0.8.5 or something, the one which is used
in current aerc. If the patched version has a chance to behave better -
let me know.

Here are the steps, I wonder if someone else could reproduce that.