On Thu, Nov 07, 2024 at 06:59:11PM -0500, Aren wrote:
>On Thu, Nov 07, 2024 at 09:29:21PM +0100, Maarten van Gompel wrote:
>> On Tue Nov 5, 2024 at 12:32 PM CET, Peter John Hartman wrote:
>> > If a user swipes up, they will dismiss the notification without doing
>> > its action, but if they touch the notification they will execute its
>> > action.
>>
>> So if I understand correctly up until now we had no actions when
>> tapping popups? Then this patch certainly makes sense yes.
>
>We currently have actions, from what I understand the issue is that they
>also get executed when swiping up, not just when tapped.

Yeah, that's it.  If you swipe up on a pile of sms notifs, it opens them

Applied.

On Tue, Aug 29, 2023 at 08:57:37PM +0200, Willow Barraco wrote:
>As this does not works for a long time, and this is mostly Pinephone
>specific, we drop this from Sxmo.
>
>If someone want to investigate futher to keep something similar, I would
>recomment to find a more global solution than this Sxmo specific trick.
>
>Signed-off-by: Willow Barraco <contact@willowbarraco.fr>
>---
> .../three_button_touchscreen/sxmo_hook_postwake.sh       | 6 ------
> .../three_button_touchscreen/sxmo_hook_unlock.sh         | 9 ---------
> scripts/deviceprofiles/README.md                         | 4 ----

On Wed, Aug 30, 2023 at 10:19:37AM +0200, Willow Barraco wrote:
>> Last I checked (Spring) this was still needed, although, obviously,
>> hacky af...  Did something change?
>
>Yes, it doesn't works anymore. At least on my device. Does it works on
>yours?

OK.  Let me check again.

--
sic dicit magister P
https://phartman.sites.luc.edu/
GPG keyID 0xE0DBD3D6 (CAE6 3A6F 755F 7BC3 36CA  330D B3E6 39C6 E0DB D3D6)

On Wed, Aug 30, 2023 at 12:24:29PM +0200, Maarten van Gompel wrote:
>On Wed Aug 30, 2023 at 10:20 AM CEST, Willow Barraco wrote:
>> > I'm down with this...
>>
>> wdym?
>
>That's means he's ok with the change. I am too, it simplifies stuff if
>we don't have to maintain bare alsa support.

Yeah!  I've been dreaming of the day we can drop alsa support :D  IIRC 
the Poco F1 needed alsa stuff for a bit but I think those days are over.

iirc we can do -aiv which might be better... i'd have to doublecheck the 
manpage, but the -i is also nice for interactive.  I would never do a 
straight -a or -v without the -i


On Tue, Aug 29, 2023 at 08:59:07PM +0200, Willow Barraco wrote:
>Signed-off-by: Willow Barraco <contact@willowbarraco.fr>
>---
> scripts/core/sxmo_upgrade.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/scripts/core/sxmo_upgrade.sh b/scripts/core/sxmo_upgrade.sh
>index 03be28a..c6cef93 100755
>--- a/scripts/core/sxmo_upgrade.sh

I'm down with this...

On Tue, Aug 29, 2023 at 08:58:03PM +0200, Willow Barraco wrote:
>Now that we support Pipewire and Pulseaudio, and that we automatically
>determine available output ports, this is useless and badly supported.
>
>Signed-off-by: Willow Barraco <contact@willowbarraco.fr>
>---
> scripts/core/sxmo_audio.sh                    | 197 +++++-------------
> scripts/deviceprofiles/README.md              |   9 -
> ...sxmo_deviceprofile_pine64,pinephone-1.2.sh |   1 -
> 3 files changed, 57 insertions(+), 150 deletions(-)
>
>diff --git a/scripts/core/sxmo_audio.sh b/scripts/core/sxmo_audio.sh

Last I checked (Spring) this was still needed, although, obviously, 
hacky af...  Did something change?

On Tue, Aug 29, 2023 at 08:57:37PM +0200, Willow Barraco wrote:
>As this does not works for a long time, and this is mostly Pinephone
>specific, we drop this from Sxmo.
>
>If someone want to investigate futher to keep something similar, I would
>recomment to find a more global solution than this Sxmo specific trick.
>
>Signed-off-by: Willow Barraco <contact@willowbarraco.fr>
>---
> .../three_button_touchscreen/sxmo_hook_postwake.sh       | 6 ------
> .../three_button_touchscreen/sxmo_hook_unlock.sh         | 9 ---------

Applied, thank you!

On Sun, Jun 18, 2023 at 10:21:26PM +0200, Hanspeter Portner wrote:
>Configurations with multiple VPNs currently fail to show the networks
>dialog due to a failing sed invocation due to multiple lines in
>VPNDEVICE env var:
>
>    $ nmcli con show --active
>
>    NAME         UUID                                  TYPE       DEVICE
>    wired        xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx  ethernet   eth0
>    mullvad-nl5  xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx  wireguard  mullvad-nl5
>    lo           xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx  loopback   lo
>    wg-forge     xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx  wireguard  wg-forge

Thank you! Applied.

On Fri, Jun 09, 2023 at 05:59:45PM +0000, Joshua Murphy wrote:
>---
> configs/default_hooks/sxmo_hook_statusbar.sh | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/configs/default_hooks/sxmo_hook_statusbar.sh b/configs/default_hooks/sxmo_hook_statusbar.sh
>index cc5344a..3825f2f 100755
>--- a/configs/default_hooks/sxmo_hook_statusbar.sh
>+++ b/configs/default_hooks/sxmo_hook_statusbar.sh
>@@ -227,7 +227,7 @@ set_wifi() {
>
> 	# if they have a vpn nmcli c shown --active should also list:

Applied!

--
sic dicit magister P
https://phartman.sites.luc.edu/
GPG keyID 0xE0DBD3D6 (CAE6 3A6F 755F 7BC3 36CA  330D B3E6 39C6 E0DB D3D6)