~pkal/public-inbox

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH autocrypt 0/1] Add missing `-hook` suffix in readme hook name

Details
Message ID
<167327107700.30850.8042316662611802985-0@git.sr.ht>
DKIM signature
missing
Download raw message
I guess you forgot the `-hook` suffix because `setup` usually does that
for you, same as `use-package` which I am still using. I haven't really
tested this, I didn't even really use the package, just started testing
it and therefore read the readme.

Btw, cool package, I wasn't aware of it until I checked emacs-news by
Sacha Chua and saw your post about taking a break of emacs development.
Don't feel guilty, I'm sure you feel responsible but you're also
responsible for yourself.

I still haven't done many patch-submissions on sourcehut, right now am
using the online tool, hopefully am not missing this up.

Cheers, Michael Eliachevitch

Michael Eliachevitch (1):
  Add missing `-hook` suffix in readme hook name

 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.34.5

[PATCH autocrypt 1/1] Add missing `-hook` suffix in readme hook name

Details
Message ID
<167327107700.30850.8042316662611802985-1@git.sr.ht>
In-Reply-To
<167327107700.30850.8042316662611802985-0@git.sr.ht> (view parent)
DKIM signature
missing
Download raw message
Patch: +1 -1
From: Michael Eliachevitch <m.eliachevitch@posteo.de>

---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 072b9d0..57ea0b9 100644
--- a/README.md
+++ b/README.md
@@ -34,7 +34,7 @@ inject headers using `message-mode` as follows:

~~~elisp
(add-hook 'rmail-mode-hook #'autocrypt-mode)
(add-hook 'message-mode #'autocrypt-mode)
(add-hook 'message-mode-hook #'autocrypt-mode)
~~~

alternatively, using [`setup`][setup]:
-- 
2.34.5
Details
Message ID
<87r0w362m0.fsf@posteo.net>
In-Reply-To
<167327107700.30850.8042316662611802985-0@git.sr.ht> (view parent)
DKIM signature
missing
Download raw message
~meliache <meliache@git.sr.ht> writes:

> I guess you forgot the `-hook` suffix because `setup` usually does that
> for you, same as `use-package` which I am still using. I haven't really
> tested this, I didn't even really use the package, just started testing
> it and therefore read the readme.

I'd class it as a typo, but yes you are right this is a mistake.

> Btw, cool package, I wasn't aware of it until I checked emacs-news by
> Sacha Chua and saw your post about taking a break of emacs development.
> Don't feel guilty, I'm sure you feel responsible but you're also
> responsible for yourself.

Thanks, but I don't feel guilty just tired :)

> I still haven't done many patch-submissions on sourcehut, right now am
> using the online tool, hopefully am not missing this up.

I can't seem to apply it directly, the way I'd usually apply a patch,
but I can make the change myself and attribute it to yourself.

Thanks either-way.

> Cheers, Michael Eliachevitch
>
> Michael Eliachevitch (1):
>   Add missing `-hook` suffix in readme hook name
>
>  README.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
Reply to thread Export thread (mbox)