This thread contains a patchset. You're looking at the original emails,
but you may wish to use the patch review UI.
Review patch
[PATCH setup] fix broken keyword :with-feature
From: Hilde <hilde.rhyne@disroot.org>
Fix typo in :with-feature definition, as per
https://lists.sr.ht/~pkal/public-inbox/%3Cm0edq8dqj7.fsf%40disroot.org%3E
---
setup.el | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/setup.el b/setup.el
index d5e49be..229f324 100644
--- a/setup.el
+++ b/setup.el
@@ -379,12 +379,12 @@ VAL into one s-expression."
(intern (format "%s-mode" feature)))))
(setup-bind body
(feature feature)
- (mode (or (get features 'setup-mode) mode))
- (func (or (get features 'setup-func) mode))
- (hook (or (get features 'setup-hook)
+ (mode (or (get feature 'setup-mode) mode))
+ (func (or (get feature 'setup-func) mode))
+ (hook (or (get feature 'setup-hook)
(get mode 'setup-hook)
(intern (format "%s-hook" mode))))
- (map (or (get features 'setup-map)
+ (map (or (get feature 'setup-map)
(get mode 'setup-map)
(intern (format "%s-map" mode))))))
body)
--
2.34.7
Thanks, I pushed the patch!
~hilde <hilde@git.sr.ht> writes:
> From: Hilde <hilde.rhyne@disroot.org>
>
> Fix typo in :with-feature definition, as per
> https://lists.sr.ht/~pkal/public-inbox/%3Cm0edq8dqj7.fsf%40disroot.org%3E
> ---
> setup.el | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/setup.el b/setup.el
> index d5e49be..229f324 100644
> --- a/setup.el
> +++ b/setup.el
> @@ -379,12 +379,12 @@ VAL into one s-expression."
> (intern (format "%s-mode" feature)))))
> (setup-bind body
> (feature feature)
> - (mode (or (get features 'setup-mode) mode))
> - (func (or (get features 'setup-func) mode))
> - (hook (or (get features 'setup-hook)
> + (mode (or (get feature 'setup-mode) mode))
> + (func (or (get feature 'setup-func) mode))
> + (hook (or (get feature 'setup-hook)
> (get mode 'setup-hook)
> (intern (format "%s-hook" mode))))
> - (map (or (get features 'setup-map)
> + (map (or (get feature 'setup-map)
> (get mode 'setup-map)
> (intern (format "%s-map" mode))))))
> body)