~pkal/public-inbox

5 2

autocrypt with mu4e

Details
Message ID
<875ye6bh0r.fsf@posteo.net>
DKIM signature
missing
Download raw message
Mu4e is now using mu4e-view-rendered-hook instead of
mu4e-view-mode-hook.
From the NEWS file:

    - ~mu4e-view-mode-hook~ now fires much earlier, before the message is
      rendered. If you have hook-functions that depend on the message contents,
      instead you should use the new ~mu4e-view-rendered-hook~.

Autocrypt is actually using mu4e-view-mode-hook which break with
recentest mu4e, consider using instead mu4e-view-rendered-hook.

(if (fboundp 'mu4e-view-rendered-hook) use_it else use mu4e-view-mode-hook)

Thanks.

-- 
Thierry
Details
Message ID
<87v8m6dnhy.fsf@posteo.net>
In-Reply-To
<875ye6bh0r.fsf@posteo.net> (view parent)
DKIM signature
missing
Download raw message
Thierry Volpiatto <thievol@posteo.net> writes:

> Mu4e is now using mu4e-view-rendered-hook instead of
> mu4e-view-mode-hook.
> From the NEWS file:
>
>     - ~mu4e-view-mode-hook~ now fires much earlier, before the message is
>       rendered. If you have hook-functions that depend on the message contents,
>       instead you should use the new ~mu4e-view-rendered-hook~.
>
> Autocrypt is actually using mu4e-view-mode-hook which break with
> recentest mu4e, consider using instead mu4e-view-rendered-hook.

Thanks, done!

> (if (fboundp 'mu4e-view-rendered-hook) use_it else use mu4e-view-mode-hook)

Shouldn't this be `boundp'?  I have at least pushed it as such, correct
my if I am wrong.

> Thanks.
Details
Message ID
<874jtqq900.fsf@posteo.net>
In-Reply-To
<87v8m6dnhy.fsf@posteo.net> (view parent)
DKIM signature
missing
Download raw message
Philip Kaludercic <philipk@posteo.net> writes:

> Shouldn't this be `boundp'?

Yes of course, sorry!

Thanks.

-- 
Thierry
Details
Message ID
<87ili6vtmv.fsf@posteo.net>
In-Reply-To
<87v8m6dnhy.fsf@posteo.net> (view parent)
DKIM signature
missing
Download raw message
Philip Kaludercic <philipk@posteo.net> writes:

> Thierry Volpiatto <thievol@posteo.net> writes:
>
>> Mu4e is now using mu4e-view-rendered-hook instead of
>> mu4e-view-mode-hook.
>> From the NEWS file:
>>
>>     - ~mu4e-view-mode-hook~ now fires much earlier, before the message is
>>       rendered. If you have hook-functions that depend on the message contents,
>>       instead you should use the new ~mu4e-view-rendered-hook~.
>>
>> Autocrypt is actually using mu4e-view-mode-hook which break with
>> recentest mu4e, consider using instead mu4e-view-rendered-hook.
>
> Thanks, done!
>
>> (if (fboundp 'mu4e-view-rendered-hook) use_it else use mu4e-view-mode-hook)
>
> Shouldn't this be `boundp'?  I have at least pushed it as such, correct
> my if I am wrong.

Probably you want to remove the hook from the right place as well (in autocrypt-uninstall).

>> Thanks.


-- 
Thierry
Details
Message ID
<87o7rxeids.fsf@posteo.net>
In-Reply-To
<87ili6vtmv.fsf@posteo.net> (view parent)
DKIM signature
missing
Download raw message
Thierry Volpiatto <thievol@posteo.net> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>> Thierry Volpiatto <thievol@posteo.net> writes:
>>
>>> Mu4e is now using mu4e-view-rendered-hook instead of
>>> mu4e-view-mode-hook.
>>> From the NEWS file:
>>>
>>>     - ~mu4e-view-mode-hook~ now fires much earlier, before the message is
>>>       rendered. If you have hook-functions that depend on the message contents,
>>>       instead you should use the new ~mu4e-view-rendered-hook~.
>>>
>>> Autocrypt is actually using mu4e-view-mode-hook which break with
>>> recentest mu4e, consider using instead mu4e-view-rendered-hook.
>>
>> Thanks, done!
>>
>>> (if (fboundp 'mu4e-view-rendered-hook) use_it else use mu4e-view-mode-hook)
>>
>> Shouldn't this be `boundp'?  I have at least pushed it as such, correct
>> my if I am wrong.
>
> Probably you want to remove the hook from the right place as well (in autocrypt-uninstall).

Of course, I fixed that as well.  Thanks for the reminder.

>>> Thanks.
Details
Message ID
<87zgbhtj3q.fsf@posteo.net>
In-Reply-To
<87o7rxeids.fsf@posteo.net> (view parent)
DKIM signature
missing
Download raw message
Philip Kaludercic <philipk@posteo.net> writes:

> Thierry Volpiatto <thievol@posteo.net> writes:
>
>> Philip Kaludercic <philipk@posteo.net> writes:
>>
>>> Thierry Volpiatto <thievol@posteo.net> writes:
>>>
>>>> Mu4e is now using mu4e-view-rendered-hook instead of
>>>> mu4e-view-mode-hook.
>>>> From the NEWS file:
>>>>
>>>>     - ~mu4e-view-mode-hook~ now fires much earlier, before the message is
>>>>       rendered. If you have hook-functions that depend on the message contents,
>>>>       instead you should use the new ~mu4e-view-rendered-hook~.
>>>>
>>>> Autocrypt is actually using mu4e-view-mode-hook which break with
>>>> recentest mu4e, consider using instead mu4e-view-rendered-hook.
>>>
>>> Thanks, done!
>>>
>>>> (if (fboundp 'mu4e-view-rendered-hook) use_it else use mu4e-view-mode-hook)
>>>
>>> Shouldn't this be `boundp'?  I have at least pushed it as such, correct
>>> my if I am wrong.
>>
>> Probably you want to remove the hook from the right place as well (in autocrypt-uninstall).
>
> Of course, I fixed that as well.  Thanks for the reminder.

Thanks!

-- 
Thierry
Reply to thread Export thread (mbox)