autocrypt.el: Add MUA support for notmuch v1 PROPOSED

Sandra Snan: 1
 Add MUA support for notmuch

 3 files changed, 96 insertions(+), 0 deletions(-)
I have new data fresh from ever more testing!

TL;DR about the message-mode issues: don't worry, do nothing. 
Deets follow.

Turns out this format-flowed issue:

Sandra Snan <sandra.snan@idiomdrottning.org> writes:
Philip Kaludercic <philipk@posteo.net> writes:
It still works, it's just that I have to remember who I only have 
in autocrypt and who I only have in the keyring (and some are in 
both).  This is related to message and not to this notmuch patch.
Yes, I wanted to talk to you about that; I noticed that line after 
sending the patch and I didn't wanna send a new one just to remove 
it, but now that you've pointed it out I will. The reason I wrote 
two years ago was based on your mu4e stuff, but this new version 
is all different.

Also I was trying some sorta CC-0 thing to not have to FSF assign, 
but, now that I have signed the FSF papers it's GPL all the way.♥
Don't worry, that line of code goes away with (require 'notmuch).♥
Of all your comments so far, which have been great and have been 
stuff I could either explain here and/or fix in the next version 
patch, here is the first thing I really need your help on because 
I'm on Emacs 28.

So you mean it takes a list of modes like this?

    (derived-mode-p '(notmuch-show-mode notmuch-search-mode 

That's so strange to me.

How can we make something that works in both old and new?
    (and (derived-mode-p 'notmuch-show-mode) 
         (derived-mode-p 'notmuch-search-mode) (derived-mode-p 

Would ↑ this ↑ work in both? Working off the guess / assumtion 
that it's yes, I'll send a v2 that does it that way, if that's not 
right either I'll have to send a v3.

I can change how mu4e does it in the same commit since it has the 
same format.
Sandra Snan <sandra.snan@idiomdrottning.org> writes:
Sandra Snan <sandra.snan@idiomdrottning.org> writes:
Export patchset (mbox)
How do I use this?

Copy & paste the following snippet into your terminal to import this patchset into git:

curl -s https://lists.sr.ht/~pkal/public-inbox/patches/47695/mbox | git am -3
Learn more about email & git

[PATCH autocrypt.el] Add MUA support for notmuch Export this patch

I think I have the autoload stuff set up wrong because this gets
"missing install implementation for notmuch" unless I have this:

    (require 'autocrypt-notmuch)

in my init.el.

Here is the setup I use:

    (straight-use-package '(autocrypt :host sr.ht :repo "~pkal/autocrypt"))

    (require 'autocrypt-notmuch)
    (add-hook 'message-mode-hook #'autocrypt-mode)
    (add-hook 'notmuch-show-hook #'autocrypt-mode)
    (add-hook 'notmuch-search-hook #'autocrypt-mode)
    (add-hook 'notmuch-tree-hook #'autocrypt-mode)

Works great.

It hooks into replying to messages rather than showing messages, and
the reason for that is that notmuch often shows many messages at a
time, from different people, some who are on autocrypt and some who
Things get added to autocrypt-data.el just fine.

However, when I run gpg --list-keys the newly added keys don't show up
there, and if I have <#secure method=pgpmime mode=signencrypt> it
refuses because of the keys not being in the gpg keyring.

If I remove <#secure method=pgpmime mode=signencrypt> from the message
before sending it, it does encrypt but that's an inconvenience since I
have the gpg keyring method for people who aren't on autocrypt; I have
to know which people are in autocrypt-data.el and could safely have
the <#secure method=pgpmime mode=signencrypt> removed.
That is a message-mode issue, and I didn't touch the message-mode part
of things, but just FWIW.

 README.md            |  1 +
 autocrypt-notmuch.el | 94 ++++++++++++++++++++++++++++++++++++++++++++
 autocrypt.el         |  1 +
 3 files changed, 96 insertions(+)
 create mode 100644 autocrypt-notmuch.el
diff --git a/README.md b/README.md
index b1af7e6..b2fa3eb 100644
--- a/README.md
+++ b/README.md
@@ -10,6 +10,7 @@ Currently, it supports:
- Rmail, as a viewer
- Gnus, as a viewer
- mu4e, as a viewer
- notmuch, as a viewer
- message, as a composer

As of writing, this package doesn't fully implement the autocrypt
diff --git a/autocrypt-notmuch.el b/autocrypt-notmuch.el
new file mode 100644
index 0000000..1a2784a
--- /dev/null
+++ b/autocrypt-notmuch.el
@@ -0,0 +1,94 @@
;; Copyright (C) 2020-2023  Free Software Foundation, Inc.

;;; autocrypt-notmuch.el --- Autocrypt for notmuch -*- lexical-binding:nil -*-

;; Author: Idiomdrottning <sandra.snan@idiomdrottning.org>
;; Based on autocrypt MUA extensions by Philip Kaludercic

;; This program is free software; you can redistribute it and/or modify
;; it under the terms of the GNU General Public License as published by
;; the Free Software Foundation, either version 3 of the License, or
;; (at your option) any later version.

;; This program is distributed in the hope that it will be useful,
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
;; GNU General Public License for more details.

;; You should have received a copy of the GNU General Public License
;; along with this program.  If not, see <https://www.gnu.org/licenses/>.

;;; Commentary:

;; MUA specific functions for notmuch

;; Setup example:
;; (add-hook 'message-mode-hook #'autocrypt-mode)
;; (add-hook 'notmuch-show-hook #'autocrypt-mode)
;; (add-hook 'notmuch-search-hook #'autocrypt-mode)
;; (add-hook 'notmuch-tree-hook #'autocrypt-mode)

;;; Code:

(require 'autocrypt)

(declare-function notmuch-call-notmuch-sexp "notmuch")
(declare-function notmuch-command-notmuch-sexp "notmuch")
(declare-function notmuch-search-find-thread-id "notmuch")
(declare-function notmuch-show-get-message-id "notmuch")
(declare-function notmuch-tree-get-message-id "notmuch")

(defvar autocrypt-message-id)
(defvar notmuch-command (if (boundp 'notmuch-command) notmuch-command "notmuch"))

(defun autocrypt-notmuch-search-rep-adv (&rest r)
  (let* ((thread-id (notmuch-search-find-thread-id))
             (plist-get (notmuch-call-notmuch-sexp "reply" "--format=sexp" thread-id) :original)
    (when autocrypt-message-id

(defun autocrypt-notmuch-tree-rep-adv (&rest r)
  (let ((autocrypt-message-id (notmuch-tree-get-message-id)))

(defun autocrypt-notmuch-show-rep-adv (&rest r)
  (let ((autocrypt-message-id (notmuch-show-get-message-id)))

(defun autocrypt-notmuch-process-sexp-original (original)
  (let ((autocrypt-message-id (plist-get original :id)))

(defun autocrypt-notmuch--install ()
  "Install autocrypt hooks for notmuch."
  (if (boundp 'notmuch-mua-reply-functions)
      (add-hook 'notmuch-mua-reply-functions #'autocrypt-notmuch-process-sexp-original)
      (advice-add 'notmuch-search-reply-to-thread-sender :before #'autocrypt-notmuch-search-rep-adv)
      (advice-add 'notmuch-tree-reply-sender :before #'autocrypt-notmuch-tree-rep-adv)
      (advice-add 'notmuch-show-reply :before #'autocrypt-notmuch-show-rep-adv))))

(defun autocrypt-notmuch--uninstall ()
  "Remove autocrypt hooks for notmuch."
  (remove-hook 'notmuch-mua-reply-functions #'autocrypt-notmuch-process-sexp-original)
  (advice-remove 'notmuch-search-reply-to-thread-sender #'autocrypt-notmuch-search-rep-adv)
  (advice-remove 'notmuch-tree-reply-sender #'autocrypt-notmuch-tree-rep-adv)
  (advice-remove 'notmuch-show-reply #'autocrypt-notmuch-show-rep-adv))

(defun autocrypt-notmuch--get-header (header)
  "Ask notmuch to return `header'."
    (let ((coding-system-for-read 'no-conversion))
      (call-process notmuch-command
                    nil t nil "show" "--format=raw" "--body=false"
    (mail-fetch-field header)))

(provide 'autocrypt-notmuch)

;;; autocrypt-notmuch.el ends here
diff --git a/autocrypt.el b/autocrypt.el
index d03c86b..1c1b136 100644
--- a/autocrypt.el
+++ b/autocrypt.el
@@ -117,6 +117,7 @@ Every member of this list has to be an instance of the

(defvar autocrypt-backends
  (list (lambda () (and (derived-mode-p 'mu4e-main-mode 'mu4e-view-mode) 'mu4e))
        (lambda () (and (derived-mode-p 'notmuch-show-mode 'notmuch-search-mode 'notmuch-tree-mode) 'notmuch))
        (lambda () (and (derived-mode-p 'gnus-mode) 'gnus))
        (lambda () (and (derived-mode-p 'rmail-mode) 'rmail))
        (lambda () (and (derived-mode-p 'message-mode) 'message))
Another weird thing about message-mode is that format-flowed /
use-hard-newlines doesn't work quite right on messages that get
encrypted, but that's again not really an autocrypt specific issue
If you have any questions about the patch just LMK
Sandra Snan <sandra.snan@idiomdrottning.org> writes:
Perhaps we should look into requiring notmuch here?  Also, if you use
`declare-function', you should also specify the assumed argument list,
so that the byte compiler can warn you more effectively when calling a
function the wrong way.
Sandra Snan <sandra.snan@idiomdrottning.org> writes:
I don't know anything about that either.

Sandra Snan <sandra.snan@idiomdrottning.org> writes:
Sorry, I was just somewhat busy the last few days and didn't manage to
respond to your patch in time.