On Mon Mar 20, 2023 at 3:47 PM CET, Tim Culverhouse wrote:
> On Sun Mar 19, 2023 at 4:53 PM CDT, Moritz Poldrack wrote:
> > I think it should be consistent… preferrably only the capital letters or
> > is there a deeper reasoning? For "normal" search terms the known -v from
> > grep might be a better choice.
>
> No deeper reasoning. I was trying to stay consistent with what we
> already have (-x / -X) and for how I would end up using it ("!").
>
> I actually am not a huge fan of our search syntax...the flags are not
> intuitive to me, and I'd rather have something like notmuch syntax, but
> with POSIX operators instead of words ('date:today.. && from:rjarry' vs 
> 'date:today.. and from:rjarry')
>

On Sun Mar 19, 2023 at 10:46 PM CET, Tim Culverhouse wrote:
> Implement inverted search via flags or '!' prefixes. Complex searches
> can chained, however their exact functionality on IMAP servers is not
     ^
     ` be?

> always the same. In general, capital letter flags will invert, and
> generic terms for subject, -b, or -a can be inverted with a "!" prefix.

I think it should be consistent… preferrably only the capital letters or
is there a deeper reasoning? For "normal" search terms the known -v from
grep might be a better choice.

>

On Fri Mar 17, 2023 at 8:35 PM CET, Robin Jarry wrote:
> Moritz Poldrack, Mar 17, 2023 at 06:50:
> > >     - Command execution is now synchronous and returns an error if the hook
> > >       shell command fails. Child processes are always reaped (no zombies).
> > Not sure which part could cause zombies, but I would make it at least
> > optional with things like `aerc-startup` as it's running in the main
> > thread.
>
> I changed the way the hooks are called so that they are called in
> async goroutines. However, your first version did only fork() child
> processes without ever calling waitpid() on them. This indeed leads PIDs
> and if aerc crashes will leave zombie processes. I only changed the
> implementation so that all forked processes are waited.

On Fri Mar 17, 2023 at 1:13 AM CET, Robin Jarry wrote:
> From: Moritz Poldrack <git@moritz.sh>
>
> Deprecate triggers and replace them with hooks. Now that aerc supports
> running arbitrary ex commands over IPC, it is possible to run internal
> aerc commands *and* shell commands via external shell scripts. Hooks
> only allow running shell commands. Hooks info is passed via environment
> variables.
>
> Implements: https://todo.sr.ht/~rjarry/aerc/136
> Signed-off-by: Moritz Poldrack <git@moritz.sh>
> Signed-off-by: Robin Jarry <robin@jarry.cc>
> ---
>

This was recently discussed on IRC:

<mjw> ddevault, sr.ht sent me email saying "Your card was declined." is 
there any more information available?
<ddevault> yes
<ddevault> our billing system has issues right now
<ddevault> it's probably not your fault
<ddevault> it will retry daily and should go through within a few days

But I think being able to top up early would be nice too.

-- 
Moritz Poldrack
https://moritz.sh

Reviewed-by: Moritz Poldrack <moritz@poldrack.dev>
-- 
Moritz Poldrack
https://moritz.sh

On Wed Mar 15, 2023 at 11:37 PM CET, Robin Jarry wrote:
> Moritz Poldrack, Mar 15, 2023 at 22:52:
> > From: Moritz Poldrack <git@moritz.sh>
> >
> > The linter goes completely crazy when building with notmuch while
> > notmuch is not installed. With an otherwise successful lint, the
> > following output is generated:
> >
> > worker/notmuch/lib/database.go:14:10: could not import github.com/zenhack/go.notmuch (-: # github.com/zenhack/go.notmuch
> > ../../go/pkg/mod/github.com/brunnre8/go.notmuch@v0.0.0-20201126061756-caa2daf7093c/configList.go:9:11: fatal error: notmuch.h: No such file or directory
> >     9 | // #include <notmuch.h>
> >       |           ^~~~~~~~~~~
> > compilation terminated.) (typecheck)
> > 	notmuch "github.com/zenhack/go.notmuch"

From: Moritz Poldrack <git@moritz.sh>

The linter goes completely crazy when building with notmuch while
notmuch is not installed. With an otherwise successful lint, the
following output is generated:

worker/notmuch/lib/database.go:14:10: could not import github.com/zenhack/go.notmuch (-: # github.com/zenhack/go.notmuch
../../go/pkg/mod/github.com/brunnre8/go.notmuch@v0.0.0-20201126061756-caa2daf7093c/configList.go:9:11: fatal error: notmuch.h: No such file or directory
    9 | // #include <notmuch.h>
      |           ^~~~~~~~~~~
compilation terminated.) (typecheck)
	notmuch "github.com/zenhack/go.notmuch"
	       ^
commands/eml.go:4:2: "bytes" imported and not used (typecheck)
[message trimmed]

From: Moritz Poldrack <git@moritz.sh>

Add a hook to run when aerc shuts down. The environment is supplemented
with the duration aerc was alive for.

The command has to exit quickly as child processes are killed when their
parents (in this case aerc) terminates. Prolonging the duration the
hook has to run, or waiting for it to complete has not been implemented
to keep the terminal responsive.

References: https://todo.sr.ht/~rjarry/aerc/136
Signed-off-by: Moritz Poldrack <git@moritz.sh>
---
 CHANGELOG.md               |  2 +-
[message trimmed]

From: Moritz Poldrack <git@moritz.sh>

Add a hook to run when aerc starts up. The environment is supplemented
with aerc's version and the path to it's binary.

References: https://todo.sr.ht/~rjarry/aerc/136
References: https://todo.sr.ht/~rjarry/aerc/139
Signed-off-by: Moritz Poldrack <git@moritz.sh>
---
 CHANGELOG.md              |  2 +-
 aerc.go                   |  5 +++++
 config/aerc.conf          |  4 ++++
 config/hooks.go           |  2 ++
 doc/aerc-config.5.scd     | 11 +++++++++++
[message trimmed]