~postmarketos/pmbootstrap-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 2

[PATCH pmbootstrap] pmb.parse.arch: Include comma after last dictionary items

Details
Message ID
<167883228237.9452.6945199441942129608-0@git.sr.ht>
DKIM signature
missing
Download raw message
Patch: +2 -2
From: Jami Kettunen <jami.kettunen@protonmail.com>

See https://lists.sr.ht/~postmarketos/pmbootstrap-devel/patches/39643#feedback-272128:1018-1194
---
 pmb/parse/arch.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pmb/parse/arch.py b/pmb/parse/arch.py
index 6237a556..89bce31a 100644
--- a/pmb/parse/arch.py
+++ b/pmb/parse/arch.py
@@ -14,7 +14,7 @@ def alpine_native():
        "aarch64": "aarch64",
        "arm64": "aarch64",
        "armv6l": "armhf",
        "armv7l": "armv7"
        "armv7l": "armv7",
    }
    if machine in mapping:
        return mapping[machine]
@@ -65,7 +65,7 @@ def alpine_to_kernel(arch):
        "arm*": "arm",
        "ppc*": "powerpc",
        "s390*": "s390",
        "riscv64*": "riscv"
        "riscv64*": "riscv",
    }
    for pattern, arch_kernel in mapping.items():
        if fnmatch.fnmatch(arch, pattern):
-- 
2.34.7

[pmbootstrap/patches/.build.yml] build failed

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CR6GOBBDONHH.15V79IGPAXOY5@cirno2>
In-Reply-To
<167883228237.9452.6945199441942129608-0@git.sr.ht> (view parent)
DKIM signature
missing
Download raw message
pmbootstrap/patches/.build.yml: FAILED in 14m3s

[pmb.parse.arch: Include comma after last dictionary items][0] from [~deathmist][1]

[0]: https://lists.sr.ht/~postmarketos/pmbootstrap-devel/patches/39725
[1]: jami.kettunen@protonmail.com

✗ #957246 FAILED pmbootstrap/patches/.build.yml https://builds.sr.ht/~postmarketos/job/957246

Re: [PATCH pmbootstrap] pmb.parse.arch: Include comma after last dictionary items

Details
Message ID
<CR7N8WY7AK5F.EADGWW04SYRL@pm-mail-aerc>
In-Reply-To
<167883228237.9452.6945199441942129608-0@git.sr.ht> (view parent)
DKIM signature
missing
Download raw message
On Tue Mar 14, 2023 at 11:01 PM CET, ~deathmist wrote:
> From: Jami Kettunen <jami.kettunen@protonmail.com>
>
> See https://lists.sr.ht/~postmarketos/pmbootstrap-devel/patches/39643#feedback-272128:1018-1194

Reviewed-by: Oliver Smith <ollieparanoid@postmarketos.org>
> ---
>  pmb/parse/arch.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/pmb/parse/arch.py b/pmb/parse/arch.py
> index 6237a556..89bce31a 100644
> --- a/pmb/parse/arch.py
> +++ b/pmb/parse/arch.py
> @@ -14,7 +14,7 @@ def alpine_native():
>          "aarch64": "aarch64",
>          "arm64": "aarch64",
>          "armv6l": "armhf",
> -        "armv7l": "armv7"
> +        "armv7l": "armv7",
>      }
>      if machine in mapping:
>          return mapping[machine]
> @@ -65,7 +65,7 @@ def alpine_to_kernel(arch):
>          "arm*": "arm",
>          "ppc*": "powerpc",
>          "s390*": "s390",
> -        "riscv64*": "riscv"
> +        "riscv64*": "riscv",
>      }
>      for pattern, arch_kernel in mapping.items():
>          if fnmatch.fnmatch(arch, pattern):
> -- 
> 2.34.7

Re: [PATCH pmbootstrap] pmb.parse.arch: Include comma after last dictionary items

Details
Message ID
<CR7NPVO29MOB.3OHVDUHX3X4V7@pm-mail-aerc>
In-Reply-To
<167883228237.9452.6945199441942129608-0@git.sr.ht> (view parent)
DKIM signature
missing
Download raw message
On Tue Mar 14, 2023 at 11:01 PM CET, ~deathmist wrote:
> From: Jami Kettunen <jami.kettunen@protonmail.com>
>
> See https://lists.sr.ht/~postmarketos/pmbootstrap-devel/patches/39643#feedback-272128:1018-1194

Applied, thanks!

[1/1] pmb.parse.arch: Include comma after last dictionary items
      commit: 2f9bdb7a6642c8644bef8152c76340e4448b2e7c

> ---
>  pmb/parse/arch.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/pmb/parse/arch.py b/pmb/parse/arch.py
> index 6237a556..89bce31a 100644
> --- a/pmb/parse/arch.py
> +++ b/pmb/parse/arch.py
> @@ -14,7 +14,7 @@ def alpine_native():
>          "aarch64": "aarch64",
>          "arm64": "aarch64",
>          "armv6l": "armhf",
> -        "armv7l": "armv7"
> +        "armv7l": "armv7",
>      }
>      if machine in mapping:
>          return mapping[machine]
> @@ -65,7 +65,7 @@ def alpine_to_kernel(arch):
>          "arm*": "arm",
>          "ppc*": "powerpc",
>          "s390*": "s390",
> -        "riscv64*": "riscv"
> +        "riscv64*": "riscv",
>      }
>      for pattern, arch_kernel in mapping.items():
>          if fnmatch.fnmatch(arch, pattern):
> -- 
> 2.34.7
Reply to thread Export thread (mbox)