[PATCH pmbootstrap] pmb.install.format: Write boot mountpoint to log

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch

3 2

[PATCH pmbootstrap] pmb.install.format: Write boot mountpoint to log

~apollo3zehn <apollo3zehn@git.sr.ht>

Details

Message ID: <170397557240.20130.18133458588122463459-0@git.sr.ht>
DKIM signature: missing

Download raw message

9 months ago

Patch: +1 -1

From: Apollo3zehn <git@m1.apollo3zehn.net>

---
 pmb/install/format.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pmb/install/format.py b/pmb/install/format.py
index 6eebd1c6..e29806db 100644
--- a/pmb/install/format.py
+++ b/pmb/install/format.py
@@ -25,7 +25,7 @@ def format_and_mount_boot(args, device, boot_label):
     filesystem = args.deviceinfo["boot_filesystem"] or "ext2"
     install_fsprogs(args, filesystem)
     logging.info(f"(native) format {device} (boot, {filesystem}), mount to"
-                 " mountpoint")
+                 f" {mountpoint}")
     if filesystem == "fat16":
         pmb.chroot.root(args, ["mkfs.fat", "-F", "16", "-n", boot_label,
                                device])
-- 
2.38.5

[pmbootstrap/patches/.build.yml] build success

builds.sr.ht <builds@sr.ht>

Details

Message ID: <CY21885B2N3L.7QEZNV5OM2NP@cirno2>
In-Reply-To: <170397557240.20130.18133458588122463459-0@git.sr.ht> (view parent)
DKIM signature: missing

Download raw message

9 months ago

pmbootstrap/patches/.build.yml: SUCCESS in 14m4s

[pmb.install.format: Write boot mountpoint to log][0] from [~apollo3zehn][1]

[0]: https://lists.sr.ht/~postmarketos/pmbootstrap-devel/patches/48184
[1]: sourcehut@m1.apollo3zehn.net

✓ #1124047 SUCCESS pmbootstrap/patches/.build.yml https://builds.sr.ht/~postmarketos/job/1124047

Oliver Smith <ollieparanoid@postmarketos.org>

Details

Message ID: <CYA971CEH8LV.38TMA1CRT2GTV@pm-mail-aerc>
In-Reply-To: <170397557240.20130.18133458588122463459-0@git.sr.ht> (view parent)
DKIM signature: missing

Download raw message

9 months ago

On Fri Dec 29, 2023 at 1:23 PM CET, ~apollo3zehn wrote:
> From: Apollo3zehn <git@m1.apollo3zehn.net>
>

Thanks!

Reviewed-by: Oliver Smith <ollieparanoid@postmarketos.org>

> ---
>  pmb/install/format.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pmb/install/format.py b/pmb/install/format.py
> index 6eebd1c6..e29806db 100644
> --- a/pmb/install/format.py
> +++ b/pmb/install/format.py
> @@ -25,7 +25,7 @@ def format_and_mount_boot(args, device, boot_label):
>      filesystem = args.deviceinfo["boot_filesystem"] or "ext2"
>      install_fsprogs(args, filesystem)
>      logging.info(f"(native) format {device} (boot, {filesystem}), mount to"
> -                 " mountpoint")
> +                 f" {mountpoint}")
>      if filesystem == "fat16":
>          pmb.chroot.root(args, ["mkfs.fat", "-F", "16", "-n", boot_label,
>                                 device])
> -- 
> 2.38.5

Oliver Smith <ollieparanoid@postmarketos.org>

Details

Message ID: <170481592330.2313.3890610573589715118.b4-ty@postmarketos.org>
In-Reply-To: <170397557240.20130.18133458588122463459-0@git.sr.ht> (view parent)
DKIM signature: missing

Download raw message

9 months ago

On Fri, 29 Dec 2023 13:23:58 +0100, ~apollo3zehn wrote:
> 


Applied, thanks!

[1/1] pmb.install.format: Write boot mountpoint to log
      commit: 09b4e5e33696c6ce704de5135e9f281d913625c9

Best regards,
-- 
Oliver Smith <ollieparanoid@postmarketos.org>