On Sonntag, 21. Mai 2023 09:01:48 CEST Newbyte wrote:
> ---> pmb/__init__.py | 2 ++> 1 file changed, 2 insertions(+)> > diff --git a/pmb/__init__.py b/pmb/__init__.py> index 18612e24..97bf1e5b 100644> --- a/pmb/__init__.py> +++ b/pmb/__init__.py> @@ -90,6 +90,8 @@ def main():> " get more output, e.g. 'pmbootstrap"> " --details-to-stdout init'.")> print(log_hint)> + print("Before you report this error, ensure that pmbootstrap is "> + "up to date.")
How about immediately printing the version number (pmb.__version__) and
linking to the releases page?
https://gitlab.com/postmarketOS/pmbootstrap/-/releases
That way the user doesn't have to search for both but conveniently has both
ready.
Regards
Luca
> return 1
On Tue May 23, 2023 at 5:19 PM CEST, Luca Weiss wrote:
> On Sonntag, 21. Mai 2023 09:01:48 CEST Newbyte wrote:> > ---> > pmb/__init__.py | 2 ++> > 1 file changed, 2 insertions(+)> > > > diff --git a/pmb/__init__.py b/pmb/__init__.py> > index 18612e24..97bf1e5b 100644> > --- a/pmb/__init__.py> > +++ b/pmb/__init__.py> > @@ -90,6 +90,8 @@ def main():> > " get more output, e.g. 'pmbootstrap"> > " --details-to-stdout init'.")> > print(log_hint)> > + print("Before you report this error, ensure that pmbootstrap is "> > + "up to date.")
Thanks for the patch, Newbyte!
Reviewed-by: Oliver Smith <ollieparanoid@postmarketos.org>
>> How about immediately printing the version number (pmb.__version__) and > linking to the releases page?>> https://gitlab.com/postmarketOS/pmbootstrap/-/releases>> That way the user doesn't have to search for both but conveniently has both > ready.
Good idea! This would be the right URL:
https://git.sr.ht/~postmarketos/pmbootstrap/refs
(It just shows git tags, the other URL is for gitlab.com releases which
are made by clicking buttons in the UI. We don't do that anymore for
quite some time as it is just extra effort.)
I'll add it before merge.
>> Regards> Luca>> > return 1
On Sun, 21 May 2023 09:01:48 +0200, Newbyte wrote:
>
Applied, thanks!
[1/1] pmb: Remind users to ensure pmbootstrap is updated before reporting errors
commit: 40fc6f4fd4f0c9b5c112df12b5562f036f17f4fb
Best regards,
--
Oliver Smith <ollieparanoid@postmarketos.org>