~postmarketos/pmbootstrap-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 2

[PATCH pmbootstrap] pmb.helpers.frontend: Also clear testsuite log when running log -c

Details
Message ID
<20230603102910.164433-1-newbyte@postmarketos.org>
DKIM signature
missing
Download raw message
Patch: +3 -1
---
 pmb/helpers/frontend.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/pmb/helpers/frontend.py b/pmb/helpers/frontend.py
index c9b76ab6..d8d80bff 100644
--- a/pmb/helpers/frontend.py
+++ b/pmb/helpers/frontend.py
@@ -531,14 +531,16 @@ def work_migrate(args):


def log(args):
    log_testsuite = f"{args.work}/log_testsuite.txt"

    if args.clear_log:
        pmb.helpers.run.user(args, ["truncate", "-s", "0", args.log])
        pmb.helpers.run.user(args, ["truncate", "-s", "0", log_testsuite])

    cmd = ["tail", "-n", args.lines, "-F"]

    # Follow the testsuite's log file too if it exists. It will be created when
    # starting a test case that writes to it (git -C test grep log_testsuite).
    log_testsuite = f"{args.work}/log_testsuite.txt"
    if os.path.exists(log_testsuite):
        cmd += [log_testsuite]

-- 
2.40.1

[pmbootstrap/patches/.build.yml] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CT2YIGDRYEIT.2AG8QIZC4N28E@cirno2>
In-Reply-To
<20230603102910.164433-1-newbyte@postmarketos.org> (view parent)
DKIM signature
missing
Download raw message
pmbootstrap/patches/.build.yml: SUCCESS in 20m44s

[pmb.helpers.frontend: Also clear testsuite log when running log -c][0] from [Newbyte][1]

[0]: https://lists.sr.ht/~postmarketos/pmbootstrap-devel/patches/41613
[1]: newbyte@postmarketos.org

✓ #1000738 SUCCESS pmbootstrap/patches/.build.yml https://builds.sr.ht/~postmarketos/job/1000738
Details
Message ID
<CT3RLGCKAW25.1R0MBEQU0NAQ@pm-mail-aerc>
In-Reply-To
<20230603102910.164433-1-newbyte@postmarketos.org> (view parent)
DKIM signature
missing
Download raw message
On Sat Jun 3, 2023 at 12:29 PM CEST, Newbyte wrote:
> ---

Thanks!

Reviewed-by: Oliver Smith <ollieparanoid@postmarketos.org>

>  pmb/helpers/frontend.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/pmb/helpers/frontend.py b/pmb/helpers/frontend.py
> index c9b76ab6..d8d80bff 100644
> --- a/pmb/helpers/frontend.py
> +++ b/pmb/helpers/frontend.py
> @@ -531,14 +531,16 @@ def work_migrate(args):
>  
>  
>  def log(args):
> +    log_testsuite = f"{args.work}/log_testsuite.txt"
> +
>      if args.clear_log:
>          pmb.helpers.run.user(args, ["truncate", "-s", "0", args.log])
> +        pmb.helpers.run.user(args, ["truncate", "-s", "0", log_testsuite])
>  
>      cmd = ["tail", "-n", args.lines, "-F"]
>  
>      # Follow the testsuite's log file too if it exists. It will be created when
>      # starting a test case that writes to it (git -C test grep log_testsuite).
> -    log_testsuite = f"{args.work}/log_testsuite.txt"
>      if os.path.exists(log_testsuite):
>          cmd += [log_testsuite]
>  
> -- 
> 2.40.1
Details
Message ID
<168587172541.2949.6187914499867156334.b4-ty@postmarketos.org>
In-Reply-To
<20230603102910.164433-1-newbyte@postmarketos.org> (view parent)
DKIM signature
missing
Download raw message
On Sat, 03 Jun 2023 12:29:10 +0200, Newbyte wrote:
> 


Applied, thanks!

[1/1] pmb.helpers.frontend: Also clear testsuite log when running log -c
      commit: 09870a46a0892e29b54eee7419046186d42504c1

Best regards,
-- 
Oliver Smith <ollieparanoid@postmarketos.org>
Reply to thread Export thread (mbox)