~postmarketos/pmbootstrap-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 2

[PATCH pmbootstrap] pmb.qemu.run: replace removed -soundhw option

Details
Message ID
<20230605102320.739043-1-luca@z3ntu.xyz>
DKIM signature
missing
Download raw message
Patch: +1 -2
In the QEMU 7.1 release the deprecated -soundhw option was removed.
Replace it with -audio so we can have audio working again in QEMU.

See also https://www.qemu.org/docs/master/about/removed-features.html
---
 pmb/qemu/run.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/pmb/qemu/run.py b/pmb/qemu/run.py
index 46e2d752..fdfe5447 100644
--- a/pmb/qemu/run.py
+++ b/pmb/qemu/run.py
@@ -229,8 +229,7 @@ def command_qemu(args, arch, img_path, img_path_2nd=None):

    # Audio support
    if args.qemu_audio:
        command += ["-audiodev", args.qemu_audio + ",id=audio"]
        command += ["-soundhw", "hda"]
        command += ["-audio", f"{args.qemu_audio},model=hda"]

    return (command, env)

-- 
2.40.1

[pmbootstrap/patches/.build.yml] build failed

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CT4N9VDN2HEM.2D94ZOHG5GIIX@cirno2>
In-Reply-To
<20230605102320.739043-1-luca@z3ntu.xyz> (view parent)
DKIM signature
missing
Download raw message
pmbootstrap/patches/.build.yml: FAILED in 5m28s

[pmb.qemu.run: replace removed -soundhw option][0] from [Luca Weiss][1]

[0]: https://lists.sr.ht/~postmarketos/pmbootstrap-devel/patches/41656
[1]: luca@z3ntu.xyz

✗ #1001719 FAILED pmbootstrap/patches/.build.yml https://builds.sr.ht/~postmarketos/job/1001719
Details
Message ID
<CT4NZI9MPJT1.YXPH2WH8555J@pm-mail-aerc>
In-Reply-To
<20230605102320.739043-1-luca@z3ntu.xyz> (view parent)
DKIM signature
missing
Download raw message
On Mon Jun 5, 2023 at 12:23 PM CEST, Luca Weiss wrote:
> In the QEMU 7.1 release the deprecated -soundhw option was removed.
> Replace it with -audio so we can have audio working again in QEMU.
>
> See also https://www.qemu.org/docs/master/about/removed-features.html

Reviewed-by: Oliver Smith <ollieparanoid@postmarketos.org>

> ---
>  pmb/qemu/run.py | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/pmb/qemu/run.py b/pmb/qemu/run.py
> index 46e2d752..fdfe5447 100644
> --- a/pmb/qemu/run.py
> +++ b/pmb/qemu/run.py
> @@ -229,8 +229,7 @@ def command_qemu(args, arch, img_path, img_path_2nd=None):
>  
>      # Audio support
>      if args.qemu_audio:
> -        command += ["-audiodev", args.qemu_audio + ",id=audio"]
> -        command += ["-soundhw", "hda"]
> +        command += ["-audio", f"{args.qemu_audio},model=hda"]
>  
>      return (command, env)
>  
> -- 
> 2.40.1
Details
Message ID
<168596393294.2614.1732221846656528426.b4-ty@postmarketos.org>
In-Reply-To
<20230605102320.739043-1-luca@z3ntu.xyz> (view parent)
DKIM signature
missing
Download raw message
On Mon, 05 Jun 2023 12:23:20 +0200, Luca Weiss wrote:
> In the QEMU 7.1 release the deprecated -soundhw option was removed.
> Replace it with -audio so we can have audio working again in QEMU.
> 
> See also https://www.qemu.org/docs/master/about/removed-features.html
> 
> 

Applied, thanks!

[1/1] pmb.qemu.run: replace removed -soundhw option
      commit: d68d5fcf20f7e48fe64b6a9b23d5406aa0756f55

Best regards,
-- 
Oliver Smith <ollieparanoid@postmarketos.org>
Reply to thread Export thread (mbox)